Re: [gentoo-dev] [PATCH 10/11] ruby-ng.eclass: use shopt directly, not via estack.eclass

[Sam James <sam@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]


Petr Vaněk <arkamar@atlas.cz> writes:

> On Thu, Jun 15, 2023 at 04:52:37PM +0100, Sam James wrote:
>> ulm points out that estack.eclass is particularly inefficient (although
>> it'll get slightly better once https://github.com/gentoo/gentoo/pull/31437
>> is fixed).
>> 
>> Let's just manually roll it like llvm.eclass does.
>> 
>> Bug: https://bugs.gentoo.org/908465
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>>  eclass/ruby-ng.eclass | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
>> index 14f4414337d6f..8fe26057e7ffe 100644
>> --- a/eclass/ruby-ng.eclass
>> +++ b/eclass/ruby-ng.eclass
>> @@ -163,7 +163,8 @@ _RUBY_ATOMS_SAMELIB_RESULT=""
>>  _ruby_atoms_samelib() {
>>  	_RUBY_ATOMS_SAMELIB_RESULT=""
>>  
>> -	eshopts_push -o noglob
>> +        local shopt_save=$(shopt -p -o noglob)
>    ^~~~~~~~
> 	Wrong indentation - expanded tab instead of tab
>> +	set -f

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]