From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101145-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 72A9415815E
	for <garchives@archives.gentoo.org>; Thu,  8 Feb 2024 07:03:00 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 65517E2AA2;
	Thu,  8 Feb 2024 07:02:57 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id DD826E2A97
	for <gentoo-dev@lists.gentoo.org>; Thu,  8 Feb 2024 07:02:56 +0000 (UTC)
References: <20240203162422.91906-1-xgqt@gentoo.org>
User-agent: mu4e 1.10.8; emacs 30.0.50
From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: dotnet@gentoo.org, Maciej =?utf-8?Q?Bar=C4=87?= <xgqt@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes
 and style tweaks for edge cases
Date: Thu, 08 Feb 2024 07:02:27 +0000
Organization: Gentoo
In-reply-to: <20240203162422.91906-1-xgqt@gentoo.org>
Message-ID: <87jznftp43.fsf@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 58f58242-6ca8-46cc-b460-b21260b31be0
X-Archives-Hash: db76b58db1367090a3b92800cff5a806


Maciej Bar=C4=87 <xgqt@gentoo.org> writes:

> Signed-off-by: Maciej Bar=C4=87 <xgqt@gentoo.org>
> ---

The series lgtm but please add some commit messages to them explaining
the motivation / why we're doing it now if applicable. No need to
re-send to ML once that's done.

Thanks!

>  eclass/dotnet-pkg-base.eclass | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/eclass/dotnet-pkg-base.eclass b/eclass/dotnet-pkg-base.eclass
> index 1a9d31120..e7484a6c5 100644
> --- a/eclass/dotnet-pkg-base.eclass
> +++ b/eclass/dotnet-pkg-base.eclass
> @@ -63,18 +63,24 @@ DOTNET_PKG_BDEPS=3D""
>=20=20
>  # Have this guard to be sure that *DEPS are not added to
>  # the "dev-dotnet/dotnet-runtime-nugets" package dependencies.
> -if [[ ${CATEGORY}/${PN} !=3D dev-dotnet/dotnet-runtime-nugets ]] ; then
> +if [[ "${CATEGORY}/${PN}" !=3D dev-dotnet/dotnet-runtime-nugets ]] ; then
>  	if [[ -z ${DOTNET_PKG_COMPAT} ]] ; then
>  		die "${ECLASS}: DOTNET_PKG_COMPAT not set"
>  	fi
>=20=20
> -	DOTNET_PKG_RDEPS+=3D" virtual/dotnet-sdk:${DOTNET_PKG_COMPAT} "
> -	DOTNET_PKG_BDEPS+=3D" ${DOTNET_PKG_RDEPS} "
> +	DOTNET_PKG_RDEPS+=3D"
> +		virtual/dotnet-sdk:${DOTNET_PKG_COMPAT}
> +	"
> +	DOTNET_PKG_BDEPS+=3D"
> +		${DOTNET_PKG_RDEPS}
> +	"
>=20=20
>  	# Special package "dev-dotnet/csharp-gentoodotnetinfo" used for informa=
tion
>  	# gathering, example for usage see the "dotnet-pkg-base_info" function.
> -	if [[ ${CATEGORY}/${PN} !=3D dev-dotnet/csharp-gentoodotnetinfo ]] ; th=
en
> -		DOTNET_PKG_BDEPS+=3D" dev-dotnet/csharp-gentoodotnetinfo "
> +	if [[ "${CATEGORY}/${PN}" !=3D dev-dotnet/csharp-gentoodotnetinfo ]] ; =
then
> +		DOTNET_PKG_BDEPS+=3D"
> +			dev-dotnet/csharp-gentoodotnetinfo
> +		"
>  	fi
>=20=20
>  	IUSE+=3D" debug "