From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: dotnet@gentoo.org, "Maciej Barć" <xgqt@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases
Date: Thu, 08 Feb 2024 07:02:27 +0000 [thread overview]
Message-ID: <87jznftp43.fsf@gentoo.org> (raw)
In-Reply-To: <20240203162422.91906-1-xgqt@gentoo.org>
Maciej Barć <xgqt@gentoo.org> writes:
> Signed-off-by: Maciej Barć <xgqt@gentoo.org>
> ---
The series lgtm but please add some commit messages to them explaining
the motivation / why we're doing it now if applicable. No need to
re-send to ML once that's done.
Thanks!
> eclass/dotnet-pkg-base.eclass | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/eclass/dotnet-pkg-base.eclass b/eclass/dotnet-pkg-base.eclass
> index 1a9d31120..e7484a6c5 100644
> --- a/eclass/dotnet-pkg-base.eclass
> +++ b/eclass/dotnet-pkg-base.eclass
> @@ -63,18 +63,24 @@ DOTNET_PKG_BDEPS=""
>
> # Have this guard to be sure that *DEPS are not added to
> # the "dev-dotnet/dotnet-runtime-nugets" package dependencies.
> -if [[ ${CATEGORY}/${PN} != dev-dotnet/dotnet-runtime-nugets ]] ; then
> +if [[ "${CATEGORY}/${PN}" != dev-dotnet/dotnet-runtime-nugets ]] ; then
> if [[ -z ${DOTNET_PKG_COMPAT} ]] ; then
> die "${ECLASS}: DOTNET_PKG_COMPAT not set"
> fi
>
> - DOTNET_PKG_RDEPS+=" virtual/dotnet-sdk:${DOTNET_PKG_COMPAT} "
> - DOTNET_PKG_BDEPS+=" ${DOTNET_PKG_RDEPS} "
> + DOTNET_PKG_RDEPS+="
> + virtual/dotnet-sdk:${DOTNET_PKG_COMPAT}
> + "
> + DOTNET_PKG_BDEPS+="
> + ${DOTNET_PKG_RDEPS}
> + "
>
> # Special package "dev-dotnet/csharp-gentoodotnetinfo" used for information
> # gathering, example for usage see the "dotnet-pkg-base_info" function.
> - if [[ ${CATEGORY}/${PN} != dev-dotnet/csharp-gentoodotnetinfo ]] ; then
> - DOTNET_PKG_BDEPS+=" dev-dotnet/csharp-gentoodotnetinfo "
> + if [[ "${CATEGORY}/${PN}" != dev-dotnet/csharp-gentoodotnetinfo ]] ; then
> + DOTNET_PKG_BDEPS+="
> + dev-dotnet/csharp-gentoodotnetinfo
> + "
> fi
>
> IUSE+=" debug "
next prev parent reply other threads:[~2024-02-08 7:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 16:24 [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases Maciej Barć
2024-02-03 16:24 ` [gentoo-dev] [PATCH 2/7] eclass/dotnet-pkg-base.eclass: deprecate wring-style names Maciej Barć
2024-02-03 16:53 ` Ulrich Mueller
2024-02-03 17:09 ` Maciej Barć
2024-02-03 16:24 ` [gentoo-dev] [PATCH 3/7] eclass/dotnet-pkg-base.eclass: dotnet-pkg-base_test - remove directory magic Maciej Barć
2024-02-03 16:24 ` [gentoo-dev] [PATCH 4/7] eclass/dotnet-pkg*: add dotnet-pkg_remove-bad Maciej Barć
2024-02-03 16:24 ` [gentoo-dev] [PATCH 5/7] eclass/dotnet-pkg.eclass: add dotnet-pkg_force-compat Maciej Barć
2024-02-03 16:55 ` Ulrich Mueller
2024-02-03 16:24 ` [gentoo-dev] [PATCH 6/7] eclass/dotnet-pkg-base.eclass: set DOTNET_ROOT Maciej Barć
2024-02-03 16:24 ` [gentoo-dev] [PATCH 7/7] eclass/dotnet-pkg.eclass: prepare for safely using Nuget Maciej Barć
2024-02-03 16:57 ` Ulrich Mueller
2024-02-03 17:07 ` Maciej Barć
2024-02-03 16:51 ` [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases Ulrich Mueller
2024-02-08 7:02 ` Sam James [this message]
2024-02-08 8:36 ` Maciej Barć
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jznftp43.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=dotnet@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=xgqt@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox