Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases

[Sam James <sam@gentoo.org>]

Maciej Barć <xgqt@gentoo.org> writes:

> Signed-off-by: Maciej Barć <xgqt@gentoo.org>
> ---

The series lgtm but please add some commit messages to them explaining
the motivation / why we're doing it now if applicable. No need to
re-send to ML once that's done.

Thanks!

>  eclass/dotnet-pkg-base.eclass | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/eclass/dotnet-pkg-base.eclass b/eclass/dotnet-pkg-base.eclass
> index 1a9d31120..e7484a6c5 100644
> --- a/eclass/dotnet-pkg-base.eclass
> +++ b/eclass/dotnet-pkg-base.eclass
> @@ -63,18 +63,24 @@ DOTNET_PKG_BDEPS=""
>  
>  # Have this guard to be sure that *DEPS are not added to
>  # the "dev-dotnet/dotnet-runtime-nugets" package dependencies.
> -if [[ ${CATEGORY}/${PN} != dev-dotnet/dotnet-runtime-nugets ]] ; then
> +if [[ "${CATEGORY}/${PN}" != dev-dotnet/dotnet-runtime-nugets ]] ; then
>  	if [[ -z ${DOTNET_PKG_COMPAT} ]] ; then
>  		die "${ECLASS}: DOTNET_PKG_COMPAT not set"
>  	fi
>  
> -	DOTNET_PKG_RDEPS+=" virtual/dotnet-sdk:${DOTNET_PKG_COMPAT} "
> -	DOTNET_PKG_BDEPS+=" ${DOTNET_PKG_RDEPS} "
> +	DOTNET_PKG_RDEPS+="
> +		virtual/dotnet-sdk:${DOTNET_PKG_COMPAT}
> +	"
> +	DOTNET_PKG_BDEPS+="
> +		${DOTNET_PKG_RDEPS}
> +	"
>  
>  	# Special package "dev-dotnet/csharp-gentoodotnetinfo" used for information
>  	# gathering, example for usage see the "dotnet-pkg-base_info" function.
> -	if [[ ${CATEGORY}/${PN} != dev-dotnet/csharp-gentoodotnetinfo ]] ; then
> -		DOTNET_PKG_BDEPS+=" dev-dotnet/csharp-gentoodotnetinfo "
> +	if [[ "${CATEGORY}/${PN}" != dev-dotnet/csharp-gentoodotnetinfo ]] ; then
> +		DOTNET_PKG_BDEPS+="
> +			dev-dotnet/csharp-gentoodotnetinfo
> +		"
>  	fi
>  
>  	IUSE+=" debug "