From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5993415806E for ; Fri, 26 May 2023 05:08:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6A30BE086D; Fri, 26 May 2023 05:08:33 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 12289E0856 for ; Fri, 26 May 2023 05:08:33 +0000 (UTC) References: <20230526040219.10852-1-ionen@gentoo.org> <20230526040219.10852-2-ionen@gentoo.org> User-agent: mu4e 1.10.3; emacs 29.0.91 From: Sam James To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/4] profiles/use.desc: create USE=strip global USE flag Date: Fri, 26 May 2023 06:06:46 +0100 In-reply-to: <20230526040219.10852-2-ionen@gentoo.org> Message-ID: <87h6rzznlg.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: bb7e85fc-6a59-4372-9d24-6b61982fefd7 X-Archives-Hash: 5f1d5a34ffdea5055f59907bb0a415bf --=-=-= Content-Type: text/plain Ionen Wolkens writes: > Primarily intended for use by linux-mod-r1.eclass, which needs > a global IUSE to control stripping of kernel modules *before* > signatures and compression (alternative would be to simply never > strip, but that seem sub-optimal). > > Originally meant to be USE=modules-strip or similar, but this can > have a more general use case when portage does not know how to > strip special files properly while the ebuild does. > > Notable is mingw ebuilds (wine-*, dxvk, vkd3d-proton, mingw64-*). > If portage uses x86_64-pc-linux-strip on, e.g. mingw64-toolchain's > runtime libraries, then at least the 32bit toolchain ends up broken > and cannot compile anything anymore. But then dostrip -x results in > unstripped files while we can use x86_64-w64-mingw32-strip in the > ebuild potentially saving 60MB+. Currently this is done through > USE=debug, but does not feel fully fitting given this isn't about > adding debugging paths (or even symbols, or anything) and is merely > "do not strip". > > No USE in ::gentoo currently contain the word "strip" and defining > it should not conflict. This sounds fine (and a good idea), but we may want some indication in the USE flag description (eh), a QA policy to indicate it's only for special situations, or some note in the devmanual. Can see people getting this wrong and trying to use it in ebuilds which would work otherwise. But maybe the "special" in the USE description is enough? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZHA+zF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZAQkAD8DR58fezYzoj5DjjWLTyLlCbXHLkRcnQrjsqI komh2GYA/0hdI5iA8gtfYH2d3SrDkrWxrODm3v111jf/91NHk7gL =g9kp -----END PGP SIGNATURE----- --=-=-=--