From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 923F11581E7 for ; Fri, 26 Apr 2024 08:34:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4DAB5E2A05; Fri, 26 Apr 2024 08:34:50 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EFB86E29F0 for ; Fri, 26 Apr 2024 08:34:49 +0000 (UTC) From: =?utf-8?Q?Arsen_Arsenovi=C4=87?= To: Alfredo Tupone Cc: gentoo-dev@lists.gentoo.org, toolchain@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work In-Reply-To: <20240425154537.32502-1-tupone@gentoo.org> (Alfredo Tupone's message of "Thu, 25 Apr 2024 17:44:05 +0200") Organization: Gentoo References: <20240425154537.32502-1-tupone@gentoo.org> User-Agent: mu4e 1.12.4; emacs 30.0.50 Date: Fri, 26 Apr 2024 10:34:44 +0200 Message-ID: <87h6foldy3.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 389f8b83-5f2b-42c8-8c58-42273c38b14d X-Archives-Hash: 11d35c50ceca42671c3f30477dfba7e6 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable looks OK at a glance, but could you summarize the issues the patch set fixes in the commit messages (and reword them to follow convention generally)? it is important to have context while looking at a git log. Alfredo Tupone writes: > Signed-off-by: Alfredo Tupone > --- > eclass/toolchain.eclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass > index a5d4345e7fbf..fd820f60f45d 100644 > --- a/eclass/toolchain.eclass > +++ b/eclass/toolchain.eclass > @@ -288,31 +288,31 @@ if [[ ${PN} !=3D kgcc64 && ${PN} !=3D gcc-* ]] ; th= en > IUSE+=3D" objc-gc" TC_FEATURES+=3D( objc-gc ) > IUSE+=3D" libssp objc++" >=20=20 > # Stop forcing openmp on by default in the eclass. Gradually phase it o= ut. > # See bug #890999. > if tc_version_is_at_least 13.0.0_pre20221218 ; then > IUSE+=3D" openmp" > else > IUSE+=3D" +openmp" > fi >=20=20 > IUSE+=3D" fixed-point" > IUSE+=3D" go" > IUSE+=3D" +sanitize" TC_FEATURES+=3D( sanitize ) > IUSE+=3D" graphite" TC_FEATURES+=3D( graphite ) > - IUSE+=3D" ada" > + IUSE+=3D" ada" TC_FEATURES+=3D( ada ) does this apply for all versions of GCC? > IUSE+=3D" vtv" > IUSE+=3D" jit" > IUSE+=3D" +pie +ssp pch" >=20=20 > IUSE+=3D" systemtap" TC_FEATURES+=3D( systemtap ) >=20=20 > tc_version_is_at_least 9.0 && IUSE+=3D" d" TC_FEATURES+=3D( d ) > tc_version_is_at_least 9.1 && IUSE+=3D" lto" > tc_version_is_at_least 10 && IUSE+=3D" cet" > tc_version_is_at_least 10 && IUSE+=3D" zstd" TC_FEATURES+=3D( zstd ) > tc_version_is_at_least 11 && IUSE+=3D" valgrind" TC_FEATURES+=3D( valgr= ind ) > tc_version_is_at_least 11 && IUSE+=3D" custom-cflags" > tc_version_is_at_least 12 && IUSE+=3D" ieee-long-double" > tc_version_is_at_least 12.2.1_p20221203 ${PV} && IUSE+=3D" default-znow" > tc_version_is_at_least 12.2.1_p20221203 ${PV} && IUSE+=3D" default-stac= k-clash-protection" =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIcEARYKAC8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZitnJBEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk0kBAQDWvfdjKiQv4B3W4BBKhUpjMx6V8p+Sp3gp 62smyPGKpgD+ISDJM/TT9RJ+hnynk+9BLU5jcLWH8e7mIhBhyp1taw0= =yC4z -----END PGP SIGNATURE----- --=-=-=--