Re: [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work

["Arsen Arsenović" <arsen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1960 bytes --]

looks OK at a glance, but could you summarize the issues the patch set
fixes in the commit messages (and reword them to follow convention
generally)?  it is important to have context while looking at a git log.

Alfredo Tupone <tupone@gentoo.org> writes:

> Signed-off-by: Alfredo Tupone <tupone@gentoo.org>
> ---
>  eclass/toolchain.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index a5d4345e7fbf..fd820f60f45d 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -288,31 +288,31 @@ if [[ ${PN} != kgcc64 && ${PN} != gcc-* ]] ; then
>  	IUSE+=" objc-gc" TC_FEATURES+=( objc-gc )
>  	IUSE+=" libssp objc++"
>  
>  	# Stop forcing openmp on by default in the eclass. Gradually phase it out.
>  	# See bug #890999.
>  	if tc_version_is_at_least 13.0.0_pre20221218 ; then
>  		IUSE+=" openmp"
>  	else
>  		IUSE+=" +openmp"
>  	fi
>  
>  	IUSE+=" fixed-point"
>  	IUSE+=" go"
>  	IUSE+=" +sanitize"  TC_FEATURES+=( sanitize )
>  	IUSE+=" graphite" TC_FEATURES+=( graphite )
> -	IUSE+=" ada"
> +	IUSE+=" ada" TC_FEATURES+=( ada )

does this apply for all versions of GCC?

>  	IUSE+=" vtv"
>  	IUSE+=" jit"
>  	IUSE+=" +pie +ssp pch"
>  
>  	IUSE+=" systemtap" TC_FEATURES+=( systemtap )
>  
>  	tc_version_is_at_least 9.0 && IUSE+=" d" TC_FEATURES+=( d )
>  	tc_version_is_at_least 9.1 && IUSE+=" lto"
>  	tc_version_is_at_least 10 && IUSE+=" cet"
>  	tc_version_is_at_least 10 && IUSE+=" zstd" TC_FEATURES+=( zstd )
>  	tc_version_is_at_least 11 && IUSE+=" valgrind" TC_FEATURES+=( valgrind )
>  	tc_version_is_at_least 11 && IUSE+=" custom-cflags"
>  	tc_version_is_at_least 12 && IUSE+=" ieee-long-double"
>  	tc_version_is_at_least 12.2.1_p20221203 ${PV} && IUSE+=" default-znow"
>  	tc_version_is_at_least 12.2.1_p20221203 ${PV} && IUSE+=" default-stack-clash-protection"

-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 251 bytes --]