From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 63D9F138262 for ; Fri, 20 May 2016 23:09:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 23FAB1429C; Fri, 20 May 2016 23:09:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2C9CB14234 for ; Fri, 20 May 2016 23:09:16 +0000 (UTC) Received: from localhost (cpc92302-cmbg19-2-0-cust189.5-4.cable.virginm.net [82.1.208.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aidecoe) by smtp.gentoo.org (Postfix) with ESMTPSA id BE84A340B09; Fri, 20 May 2016 23:09:14 +0000 (UTC) From: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= To: Peter Stuge Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] rebar.eclass: Build Erlang/OTP projects using dev-util/rebar In-Reply-To: <20160518232658.GM26940@foo.stuge.se> References: <1463610918-4062-1-git-send-email-aidecoe@gentoo.org> <20160518232658.GM26940@foo.stuge.se> User-Agent: Notmuch/0.22 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sat, 21 May 2016 00:09:11 +0100 Message-ID: <87eg8wwcmg.fsf@freja.aidecoe.name> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 40484c8c-492c-4b5e-a437-3c2f7eb078ca X-Archives-Hash: 3d10caabecca4cf14f45681392d069a0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Peter Stuge writes: >> + pushd "${EPREFIX}$(get_erl_libs)" >/dev/null >> + for p in ${pn} ${pn}-*; do >> + if [[ -d ${p} ]]; then >> + echo "${p#${pn}-}" >> + return 0 > > No popd on success? Thanks for catching this up! Fixed. >> + local tmpf=3D"$(emktemp)" >> + >> + cat "${f}" >"${tmpf}" || return 1 >> + awk "$@" "${tmpf}" >"${f}" >> +} > > Wouldn't it be nicer to cut cat, awk > $tmpf && mv $tmpf $f ? No. Please see separate review of eawk where it is explained. Thanks, =2D- Amadeusz =C5=BBo=C5=82nowski --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 iQJ8BAEBCgBmBQJXP5kXXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCMzcyRTFENjI5NUM1MzYwQTQwODQyRUZD QkNDODAyM0Y1OUUxNzA0AAoJEMvMgCP1nhcEWiMP/0TfDW6BnZjWYhy8iGArvRVU R2FWDRN6dKJhFE+Y9l5MYcMr5tFWUv7U05K+me3UpDG4cnihL8IhBvHPETxh5Hbe 5eJrdKElPx8JzuqzIAZrWcOBh8YkUQ/mfBxhwCnlvEVCPQ1oPz9YJpspx3YffLdv +T2icIdmzaMkCTVLjJL6NqsKQfcx+mvEU6LXaTuYYXWVx+TIccdF8JxHFWol8uDg d2vexLgTJBIMqbcWTkCpoYMPArTqVixZXsqkbSj+sSBSfcjorLs4eWD5+rdMzl7Q Bpg1hNsXV4YKOTn3v+7yB+gLWJwCmwZvNA1Q6XE8UsLmOHSR/E+M8N7s8Gk84cUB aLPphnru+xhGd1h0/7rQVv7IsnHuJzVc9tai1r/E1YUmXu7IyuIfzvld7MRGZvEN ZOOPhXYu89ubGGpjg9RoSJO0XRJw3lPDkuC0S8D5vNncgc9Siou5qteZ1vcbFory rRJibZ0nqgGvitRRrukEFsdkyXIVYu0SOggw2+HCOeS/lff3sS3P/eSJBbc7SDgs xQWOUkbKBmb9LBOgmiXUbeBEyBrqax4h2jTszDU5LYyAwK6+LQqhpoSdqXmLy/1j G6zI2MAUyY9ssqmsehrbpmgL+kuwZHNyoNMi4u4/pL+lOY0b1pSW2RmLH2hAPwE1 vziApCw46MsSPTMHWULf =uvKH -----END PGP SIGNATURE----- --=-=-=--