From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-99969-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 65CAF158009
	for <garchives@archives.gentoo.org>; Mon, 26 Jun 2023 15:24:49 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id D431AE088F;
	Mon, 26 Jun 2023 15:24:45 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 9D806E087B
	for <gentoo-dev@lists.gentoo.org>; Mon, 26 Jun 2023 15:24:45 +0000 (UTC)
References: <20230626095716.1292297-1-sam@gentoo.org> <u1qhypl2g@gentoo.org>
User-agent: mu4e 1.10.4; emacs 29.0.92
From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: base-system@gentoo.org, kde@gentoo.org
Subject: Re: [gentoo-dev] [PATCH] cmake.eclass: workaround S=${WORKDIR}
 creating builddir above ${WORKDIR}
Date: Mon, 26 Jun 2023 16:24:19 +0100
In-reply-to: <u1qhypl2g@gentoo.org>
Message-ID: <87edly2qmf.fsf@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
X-Archives-Salt: b31b82a4-af08-4f41-9dd8-45ff2bc66593
X-Archives-Hash: c1e85a509b2ce522ba13194b78e37855

--=-=-=
Content-Type: text/plain


Ulrich Mueller <ulm@gentoo.org> writes:

>>>>>> On Mon, 26 Jun 2023, Sam James wrote:
>
>> +
>> +		# Avoid creating ${WORKDIR}_build (which is above WORKDIR).
>> +		# TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
>> +		# See bug #889420.
>> +		if [[ ${S} == ${WORKDIR} && ${BUILD_DIR} == ${WORKDIR}_build ]] ; then
>
> I'd suggest adding quotes to the RHS of the expression, to prevent
> globbing.

I'm fine with quoting the RHS, but I don't think it's worth making the
other changes given this works and it's already an edge case.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZJmtuF8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB
NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv
by5vcmcACgkQc4QJ9SDfkZDglgD/fN4/k3Klbwuzz2h5sxN4IAVYi4kkDEZlpAaf
tQHwWEcBAPdNdKPO4rrXYP4zLlLNpn0iialVcEFYsnNgwOIETnUI
=tVoU
-----END PGP SIGNATURE-----
--=-=-=--