From: "Amadeusz Żołnowski" <aidecoe@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] rebar.eclass: Build Erlang/OTP projects using dev-util/rebar
Date: Sat, 21 May 2016 09:35:49 +0100 [thread overview]
Message-ID: <87a8jjx0yi.fsf@freja.aidecoe.name> (raw)
In-Reply-To: <20160521090058.5133ab74.mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
Michał Górny <mgorny@gentoo.org> writes:
>> >> + [[ -d include ]] && doins -r include
>> >> + [[ -d bin ]] && for bin in bin/*; do dobin "$bin"; done
>> >
>> > Please don't do inlines like this.
>>
>> Is there a particular problem with this?
>
> Readability and maintainability. At some point someone may want to
> extend this, and it will no longer work as one-liner.
That's rather subjective. Given the context I find concise. When
uninlined it takes 4 lines more, gets out of context and looks more
noisy to me. If someone would like to extend the inline version it could
be uninlined at that point.
--
Amadeusz Żołnowski
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 950 bytes --]
next prev parent reply other threads:[~2016-05-21 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 22:35 [gentoo-dev] [PATCH] rebar.eclass: Build Erlang/OTP projects using dev-util/rebar aidecoe
2016-05-18 23:26 ` Peter Stuge
2016-05-20 23:09 ` Amadeusz Żołnowski
2016-05-19 4:39 ` Michał Górny
2016-05-20 23:06 ` Amadeusz Żołnowski
2016-05-21 7:00 ` Michał Górny
2016-05-21 8:35 ` Amadeusz Żołnowski [this message]
2016-05-21 13:26 ` aidecoe
2016-05-21 20:48 ` Michał Górny
2016-05-21 22:11 ` Amadeusz Żołnowski
2016-05-21 23:19 ` aidecoe
2016-05-21 23:22 ` [gentoo-dev] [PATCH 2/2] Add tests for rebar.eclass aidecoe
2016-05-22 21:14 ` [gentoo-dev] [PATCH] rebar.eclass: Build Erlang/OTP projects using dev-util/rebar Michał Górny
2016-05-22 22:07 ` Amadeusz Żołnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8jjx0yi.fsf@freja.aidecoe.name \
--to=aidecoe@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox