public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] .github: Add pull request template
Date: Fri, 03 May 2024 05:41:09 +0100	[thread overview]
Message-ID: <877cgbld7e.fsf@gentoo.org> (raw)
In-Reply-To: <20240501133259.48778-1-mgorny@gentoo.org> (=?utf-8?Q?=22Mich?= =?utf-8?Q?a=C5=82_G=C3=B3rny=22's?= message of "Wed, 1 May 2024 15:32:21 +0200")

Michał Górny <mgorny@gentoo.org> writes:

> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  .github/pull_request_template.md | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 .github/pull_request_template.md
>
> The idea is to increase awareness of the AI policy, as well as other
> rules, and to inform users before they submit a PR.
>
> Screenshots @ https://github.com/gentoo/gentoo/pull/36503
>
>
> diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
> new file mode 100644
> index 000000000000..9e6fe061db11
> --- /dev/null
> +++ b/.github/pull_request_template.md
> @@ -0,0 +1,12 @@
> +<!-- Please put the pull request description above -->
> +
> +---
> +
> +Please check all the boxes that apply:
> +
> +- [ ] I can submit this contribution in agreement with the [Copyright Policy](https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin).
> +- [ ] This contribution has not been created with the assistance of
> Natural Language Processing artificial intelligence tools, in
> accordance with [AI
> policy](https://wiki.gentoo.org/wiki/Project:Council/AI_policy).
> +- [ ] I have certified the above via adding a `Signed-off-by` line to *every* commit in the pull request.
> +- [ ] I have run `pkgcheck scan --commits --net` to check for issues with my commits.
> +
> +Please note that all boxes must be checked for the pull request to be merged.

I'm OK with the proposal as-is, but would be interested in hearing
suggestions to alleviate ulm's concern of developers feeling they must
tick every single box as well. But that might not be doable.

xgqt's comments wrt testing are interesting but maybe better with us
linking to a checklist instead, rather than something users have to
declare in the github PR. Not sure.

Anyway, thanks for this, I've wanted this for a while anyway as it's
more elegant than the Larry bot method. Glad you came around ;)

thanks,
sam


      parent reply	other threads:[~2024-05-03  4:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 13:32 [gentoo-dev] [PATCH] .github: Add pull request template Michał Górny
2024-05-01 14:27 ` Maciej Barć
2024-05-01 14:47   ` Eli Schwartz
2024-05-01 15:02     ` Maciej Barć
2024-05-01 15:15       ` Eli Schwartz
2024-05-01 15:18         ` Maciej Barć
2024-05-01 14:59   ` Michał Górny
2024-05-01 15:14     ` Maciej Barć
2024-05-01 14:28 ` Ionen Wolkens
2024-05-01 14:38   ` Maciej Barć
2024-05-01 14:54     ` Eli Schwartz
2024-05-01 15:01     ` Ulrich Mueller
2024-05-01 15:05       ` Maciej Barć
2024-05-01 15:52         ` Ulrich Mueller
2024-05-01 16:00           ` Maciej Barć
2024-05-01 15:00   ` Michał Górny
2024-05-03  4:41   ` Sam James
2024-05-03  4:41 ` Sam James [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cgbld7e.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=mgorny@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox