From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7D16315802F for ; Wed, 29 Mar 2023 16:32:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 49E6B2BC029; Wed, 29 Mar 2023 16:32:00 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0B10F2BC00D for ; Wed, 29 Mar 2023 16:32:00 +0000 (UTC) References: <20230329154857.4068761-1-sam@gentoo.org> <20230329154857.4068761-2-sam@gentoo.org> User-agent: mu4e 1.8.14; emacs 29.0.60 From: Sam James To: Ulrich Mueller Cc: gentoo-dev@lists.gentoo.org, ruby@gentoo.org Subject: Re: [gentoo-dev] [PATCH v2 2/3] ruby-ng.eclass: don't quote IUSE in has test Date: Wed, 29 Mar 2023 17:30:25 +0100 In-reply-to: Message-ID: <874jq31ptw.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: feea9144-0572-4d28-8571-381b44951af8 X-Archives-Hash: 1a46377e4be6694b89fc62b71610ae3c --=-=-= Content-Type: text/plain Ulrich Mueller writes: >>>>>> On Wed, 29 Mar 2023, Sam James wrote: > >> - if ! has test "$IUSE"; then >> + if ! has test ${IUSE}; then > > You cannot reliably test for a flag in IUSE with code like this. > PMS defines the function in_iuse() for this (unless the above is > in global scope, in which case you're out of luck). Yep, it is, unfortunately. I can try ripping it out entirely given it's not reliable, depending on how others feel about it. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZCRn+18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZAGSwD/QjuTlKKWSIxBe9hxih6043NHy1fSNXsLeWUM j2kWq0UBANksKUf2Dc8q7sREEkG2WOAQ2XU2OXgD1GFXcAiWBw0H =Q8Xk -----END PGP SIGNATURE----- --=-=-=--