From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E4CF6158008 for ; Fri, 16 Jun 2023 18:07:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 350EFE08F5; Fri, 16 Jun 2023 18:07:18 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E9A3FE08F2 for ; Fri, 16 Jun 2023 18:07:17 +0000 (UTC) References: <20230616120739.8656-1-mgorny@gentoo.org> <20230616120739.8656-5-mgorny@gentoo.org> <700dda53aa77b7a27e800df55d19d86ad1902bef.camel@gentoo.org> User-agent: mu4e 1.10.3; emacs 29.0.91 From: Sam James To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 4/5] cargo.eclass: Support separating crate names/versions via slash Date: Fri, 16 Jun 2023 19:06:45 +0100 In-reply-to: <700dda53aa77b7a27e800df55d19d86ad1902bef.camel@gentoo.org> Message-ID: <874jn7cmcv.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 2aa67c32-a9a1-40f2-b84a-3568df24e30e X-Archives-Hash: 9e3dc934e85652ed2489ac22ee5f7e6c --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Micha=C5=82 G=C3=B3rny writes: > On Fri, 2023-06-16 at 17:48 +0300, Denis Lisov wrote: >> Hello Micha=C5=82, >>=20 >> On Fri, Jun 16, 2023 at 3:09=E2=80=AFPM Micha=C5=82 G=C3=B3rny wrote: >> > Support specifying crate names and versions separated by forward slash= es >> > rather than hyphens. Since slashes are not valid in crate names, this >> > makes splitting the tokens trivial and free of regular expressions. >> > Effectively, the slash variant is roughly 180% faster: >>=20 >> As a developer using Rust I want to note that Cargo has a concept of >> "package ID specification"[1] that usually uses pkgname@version >> syntax, but AFAIK there's no prior art for using pkgname/version in >> the ecosystem. Could it make sense to use pkgname@version for >> consistency? >>=20 > > I suppose so. The only reason I've used slash is because that could be > used directly in URL. I think we should do it (@ delimiter) - it looks more natural in a Rust/car= go context. Thanks for the suggestion! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZIyk0F8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZAMhwEA7k5j4cj8erpLdz7bqd2HePkIYL0Tlfzcav57 CpaFV+oA/R0WZRxvV8OC30st3U8jPjER9ZOiIZccAE2Id4pK9KcO =lytJ -----END PGP SIGNATURE----- --=-=-=--