public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Arsen Arsenović" <arsen@gentoo.org>
To: Alfredo Tupone <tupone@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,  toolchain@gentoo.org
Subject: [gentoo-dev] Re: [PATCH 2/3] To build ada we need  a c++ compiler too
Date: Fri, 26 Apr 2024 10:29:43 +0200	[thread overview]
Message-ID: <874jbomsqw.fsf@gentoo.org> (raw)
In-Reply-To: <20240425154537.32502-2-tupone@gentoo.org> (Alfredo Tupone's message of "Thu, 25 Apr 2024 17:44:06 +0200")

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

Hi,

Alfredo Tupone <tupone@gentoo.org> writes:

> Signed-off-by: Alfredo Tupone <tupone@gentoo.org>
> ---
>  eclass/toolchain.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index fd820f60f45d..f8e06fa39884 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -2495,31 +2495,31 @@ should_we_gcc_config() {
>  #
>  # Also add a hook so special ebuilds (kgcc64) can control which languages
>  # exactly get enabled
>  gcc-lang-supported() {
>  	grep ^language=\"${1}\" "${S}"/gcc/*/config-lang.in > /dev/null || return 1
>  	[[ -z ${TOOLCHAIN_ALLOWED_LANGS} ]] && return 0
>  	has $1 ${TOOLCHAIN_ALLOWED_LANGS}
>  }
>  
>  _tc_use_if_iuse() {
>  	in_iuse $1 && use $1
>  }
>  
>  is_ada() {
>  	gcc-lang-supported ada || return 1
> -	_tc_use_if_iuse ada
> +	_tc_use_if_iuse cxx && _tc_use_if_iuse ada

Is this redundant?  Would gcc-lang-supported c++ (called through the ada
support check) not suffice?

>  }
>  
>  is_cxx() {
>  	gcc-lang-supported 'c++' || return 1
>  	_tc_use_if_iuse cxx
>  }
>  
>  is_d() {
>  	gcc-lang-supported d || return 1
>  	_tc_use_if_iuse d
>  }
>  
>  is_f77() {
>  	gcc-lang-supported f77 || return 1
>  	_tc_use_if_iuse fortran

-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

  reply	other threads:[~2024-04-26  8:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ada related changes to toolchain.eclass>
2024-04-25 15:44 ` [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Alfredo Tupone
2024-04-25 15:44   ` [gentoo-dev] [PATCH 2/3] To build ada we need a c++ compiler too Alfredo Tupone
2024-04-26  8:29     ` Arsen Arsenović [this message]
2024-04-26 18:06       ` [gentoo-dev] " Alfredo Tupone
2024-04-30  6:25         ` Sam James
2024-04-25 15:44   ` [gentoo-dev] [PATCH 3/3] A check that the compiler used to build ada is ada and not newer Alfredo Tupone
2024-04-26  8:34   ` [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Arsen Arsenović
2024-04-26 17:53     ` Alfredo Tupone
2024-04-30  8:51       ` Arsen Arsenović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jbomsqw.fsf@gentoo.org \
    --to=arsen@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=toolchain@gentoo.org \
    --cc=tupone@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox