Re: [gentoo-dev] [PATCH 1/5] gui-libs/gtk: add a "poison" macro support to disable X/wayland

[Sam James <sam@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

Eli Schwartz <eschwartz93@gmail.com> writes:

> On 6/26/24 5:03 AM, Sam James wrote:
>> Eli Schwartz <eschwartz93@gmail.com> writes:
>> 
>>> Many packages perform automagic dependencies on gdk's backend
>>> implementations by checking if the macro is defined and then using the
>>> code it unlocks, rather than having a buildsystem option such as
>>> -Dwayland=true.
>>>
>> Doesn't gtk3 need this too? Also, could we have an upstream report
>> making them aware of this for gtk4?
>
>
> Yes, gtk3 needs this too (and patches in this series depend on it).
>
> At https://github.com/gentoo/gentoo/pull/37259 there are 6 patches, not
> 5 -- I appear to have accidentally excluded the first patch when sending
> it to the list, unsure how that happened. It's almost ccompletely
> copy/paste from gtk4.

Thanks for clarifying - I was convinced I'd seen you show me it (I
probably saw it on the branch) but I didn't think to check the PR.

>
> As far as reporting this upstream goes, I'm somewhat nervous they will
> suggest you should simply build against what you use and require what
> you build against. It's not a completely unreasonable suggestion, in
> fact it's the one I described as option 4 and Gentoo simply cannot use
> it today since it would require new EAPI.

I tend to agree. I see this as kind of our fault / a Gentoo-ish problem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]