From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id F0E87138262 for ; Sat, 21 May 2016 16:08:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1CAB514258; Sat, 21 May 2016 16:08:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 199FD141C9 for ; Sat, 21 May 2016 16:08:49 +0000 (UTC) Received: from localhost (cpc92302-cmbg19-2-0-cust189.5-4.cable.virginm.net [82.1.208.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aidecoe) by smtp.gentoo.org (Postfix) with ESMTPSA id 9960D340C7A; Sat, 21 May 2016 16:08:48 +0000 (UTC) From: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= To: Mike Frysinger Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Add awk wrapper - eawk - edit file in place In-Reply-To: <20160521145816.GC26300@vapier.lan> References: <1463606702-16578-1-git-send-email-aidecoe@gentoo.org> <20160520030805.GV26300@vapier.lan> <87k2iowkxe.fsf@freja.aidecoe.name> <20160521145816.GC26300@vapier.lan> User-Agent: Notmuch/0.22 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sat, 21 May 2016 17:08:40 +0100 Message-ID: <8737pb5r7b.fsf@freja.aidecoe.name> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 3ef4d53e-060d-48c3-99aa-dcd1d01ce6c4 X-Archives-Hash: 0e4c6735b8d98ee69ef83d1bd92ad349 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mike Frysinger writes: >> The same "sed -i" is used. I have some configs to edit in place in >> src_prepare(). It's easier with awk rather than sed. > > again, provide an example. one or two uncommon use cases doesn't justify > being added to eutils. See rebar.eclass review where it is used. Later ejabberd ebuild I'm going to add uses it as well. This function is too generic to be in rebar.eclass, so I have decided to move it to eutils. What is the problem with adding it to eutils? =2D- Amadeusz =C5=BBo=C5=82nowski --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 iQJ8BAEBCgBmBQJXQIgIXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCMzcyRTFENjI5NUM1MzYwQTQwODQyRUZD QkNDODAyM0Y1OUUxNzA0AAoJEMvMgCP1nhcEqCEP/jl/MpQbHDtJ28HmnYsHfG0I 1GhCaOKwuuBKzx+ZtJnJrpRel93MgUcv4CTZg2wOERY7HjUHKIewswZkFZg/mNuW MFbiqq4Ug3xfgiWXzUwN0izEhGjqsxjouOd4G7O+VuZZu52TRzWAFkbO3UKGrksk 7zAuMdn1jMsMVC2faoKGBTq/BvMF927T5v0pRbTCp2hD8K9Ja8STTIGJUdue/Ljc WKDx8r2p/yeLAIihPKZsJ/vFMYW7oWX6kpeQAPCx5xhbaX+F3N5U34xzXncCLdH2 EyzZulqZdiJCjC5VMCtfrpqDD3epmoWZVxztz4pQFUNK29512HX38pCoZA7PTobx HS9UoSsiPF9/L3kAqLmbr7b5pLmw0zVWAQBY8GlNzpx/GLr/2vDrXHFp1iB1jGNM VTjnIewNmqG3e2gpfOGLk8fiPUC23gVuMPdyH5R5seAbHjYxuqZLPVIyUX7xh6lT aF4WOVxidTqh1B97dbgjUTa9HXnkXAmlbJUskt5Oibmt/IzSvl5VAmLBdWoNM7XK 4kU1AoZyRerA3qFOMRzcXHAsaZ2cgCyxm1fOkpx97I6v/BtKl5Syl4aT5i0AogAa aJ1k4sJ4JiiIulEG6AT3uo6eu6LVciOGWKLvKCqcu9AbCW9Alvck6YqnqkEMyqIJ ATbiipxReLqRPF7UGFf/ =9T1t -----END PGP SIGNATURE----- --=-=-=--