From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 68F0E158041 for ; Fri, 29 Mar 2024 18:46:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 25C71E2A91; Fri, 29 Mar 2024 18:46:50 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B3464E2A44 for ; Fri, 29 Mar 2024 18:46:49 +0000 (UTC) From: Sam James To: Eli Schwartz Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: make the FHS paths warning easier to read In-Reply-To: <20240329035439.11381-1-eschwartz93@gmail.com> (Eli Schwartz's message of "Thu, 28 Mar 2024 23:54:35 -0400") Organization: Gentoo References: <20240329035439.11381-1-eschwartz93@gmail.com> User-Agent: mu4e 1.12.2; emacs 30.0.50 Date: Fri, 29 Mar 2024 18:46:44 +0000 Message-ID: <8734s8c1uz.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 54f719b6-128d-4d12-a8ec-468bc9392aa2 X-Archives-Hash: dd7e681b59d4186298af2bbfdf0f9f72 --=-=-= Content-Type: text/plain Eli Schwartz writes: > * QA Notice: The ebuild is installing to one or more unexpected paths: > * > * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/legion_prof_files > * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/serializer_examples > * > * Please fix the ebuild to use correct FHS/Gentoo policy paths. > > This message is hard to understand. Is it saying that the resulting > package contains files prefixed with ${D} which would be immensely > broken? Is it saying that these paths are *directories* and the FHS does > not approve of directories in /usr/bin/*/? > > In fact, it's the latter. Fix this in two ways: > > - clarify that it's an unexpected directory, not just some kind of path > > - strip ${D} so that people can better visualize what sort of path gets > installed. This has the downside of not being able to copy/paste the > path in order to inspect the image directory, but I think this is a > very small downside. Usually by the time you see this message, portage > has cleaned up. And if it hasn't, you can still copy/paste that from: > > Completed installing sys-cluster/legion-9999 into /var/tmp/portage/sys-cluster/legion-9999/image > > Signed-off-by: Eli Schwartz > --- LGTM. Thanks. > metadata/install-qa-check.d/08gentoo-paths | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/metadata/install-qa-check.d/08gentoo-paths b/metadata/install-qa-check.d/08gentoo-paths > index 5b8607fd5f96..0b92a7a1c132 100644 > --- a/metadata/install-qa-check.d/08gentoo-paths > +++ b/metadata/install-qa-check.d/08gentoo-paths > @@ -70,9 +70,9 @@ gentoo_path_check() { > # report > # ------ > if [[ -n ${bad_paths[@]} ]]; then > - eqawarn "QA Notice: The ebuild is installing to one or more unexpected paths:" > + eqawarn "QA Notice: The ebuild is installing to one or more unexpected directories:" > eqawarn > - eqatag -v non-gentoo-paths "${bad_paths[@]}" > + eqatag -v non-gentoo-paths "${bad_paths[@]#${D%/}}" > eqawarn > eqawarn "Please fix the ebuild to use correct FHS/Gentoo policy paths." > fi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZgcMlV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZDePQEArUkMGPprjUvv2uQ+4FicHyEWWjqJ0ruhT15t UJ5sKboBAIoSZ/9HeLrw0L7D0RFTNBJpUj8CdKZwKvwz0hV8lZAF =FwQl -----END PGP SIGNATURE----- --=-=-=--