From: Sam James <sam@gentoo.org>
To: Eli Schwartz <eschwartz93@gmail.com>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: make the FHS paths warning easier to read
Date: Fri, 29 Mar 2024 18:46:44 +0000 [thread overview]
Message-ID: <8734s8c1uz.fsf@gentoo.org> (raw)
In-Reply-To: <20240329035439.11381-1-eschwartz93@gmail.com> (Eli Schwartz's message of "Thu, 28 Mar 2024 23:54:35 -0400")
[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]
Eli Schwartz <eschwartz93@gmail.com> writes:
> * QA Notice: The ebuild is installing to one or more unexpected paths:
> *
> * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/legion_prof_files
> * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/serializer_examples
> *
> * Please fix the ebuild to use correct FHS/Gentoo policy paths.
>
> This message is hard to understand. Is it saying that the resulting
> package contains files prefixed with ${D} which would be immensely
> broken? Is it saying that these paths are *directories* and the FHS does
> not approve of directories in /usr/bin/*/?
>
> In fact, it's the latter. Fix this in two ways:
>
> - clarify that it's an unexpected directory, not just some kind of path
>
> - strip ${D} so that people can better visualize what sort of path gets
> installed. This has the downside of not being able to copy/paste the
> path in order to inspect the image directory, but I think this is a
> very small downside. Usually by the time you see this message, portage
> has cleaned up. And if it hasn't, you can still copy/paste that from:
>
> Completed installing sys-cluster/legion-9999 into /var/tmp/portage/sys-cluster/legion-9999/image
>
> Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
> ---
LGTM. Thanks.
> metadata/install-qa-check.d/08gentoo-paths | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/metadata/install-qa-check.d/08gentoo-paths b/metadata/install-qa-check.d/08gentoo-paths
> index 5b8607fd5f96..0b92a7a1c132 100644
> --- a/metadata/install-qa-check.d/08gentoo-paths
> +++ b/metadata/install-qa-check.d/08gentoo-paths
> @@ -70,9 +70,9 @@ gentoo_path_check() {
> # report
> # ------
> if [[ -n ${bad_paths[@]} ]]; then
> - eqawarn "QA Notice: The ebuild is installing to one or more unexpected paths:"
> + eqawarn "QA Notice: The ebuild is installing to one or more unexpected directories:"
> eqawarn
> - eqatag -v non-gentoo-paths "${bad_paths[@]}"
> + eqatag -v non-gentoo-paths "${bad_paths[@]#${D%/}}"
> eqawarn
> eqawarn "Please fix the ebuild to use correct FHS/Gentoo policy paths."
> fi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]
prev parent reply other threads:[~2024-03-29 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 3:54 [gentoo-dev] [PATCH] metadata/install-qa-check.d: make the FHS paths warning easier to read Eli Schwartz
2024-03-29 4:54 ` Haelwenn (lanodan) Monnier
2024-03-29 18:49 ` Eli Schwartz
2024-03-29 14:17 ` Michał Górny
2024-03-29 18:46 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734s8c1uz.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=eschwartz93@gmail.com \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox