From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id EA184158064 for ; Tue, 30 Apr 2024 06:25:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3CC18E2A00; Tue, 30 Apr 2024 06:25:15 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C20B3E29F8 for ; Tue, 30 Apr 2024 06:25:14 +0000 (UTC) From: Sam James To: Alfredo Tupone Cc: Arsen =?utf-8?Q?Arsenovi=C4=87?= , gentoo-dev@lists.gentoo.org, toolchain@gentoo.org Subject: Re: [gentoo-dev] Re: [PATCH 2/3] To build ada we need a c++ compiler too In-Reply-To: <20240426200604.51bb9471@alfredo.tupone.it> (Alfredo Tupone's message of "Fri, 26 Apr 2024 20:06:04 +0200") Organization: Gentoo References: <20240425154537.32502-1-tupone@gentoo.org> <20240425154537.32502-2-tupone@gentoo.org> <874jbomsqw.fsf@gentoo.org> <20240426200604.51bb9471@alfredo.tupone.it> User-Agent: mu4e 1.12.4; emacs 30.0.50 Date: Tue, 30 Apr 2024 07:25:09 +0100 Message-ID: <871q6nv03e.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 0755656f-8cac-477f-8636-0f107b14e7be X-Archives-Hash: 0904bc95fd49f0d0a90dc424c1bb155d --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alfredo Tupone writes: > On Fri, 26 Apr 2024 10:29:43 +0200 > Arsen Arsenovi=C4=87 wrote: > >> > is_ada() { >> > gcc-lang-supported ada || return 1 >> > - _tc_use_if_iuse ada >> > + _tc_use_if_iuse cxx && _tc_use_if_iuse ada=20=20 >>=20 >> Is this redundant? Would gcc-lang-supported c++ (called through the >> ada support check) not suffice? > > From what I understand this test is checking that both USE=3Dcxx and > USE=3Dada are enabled, and both cxx and ada are supported by gcc. > > If not, gcc is built without the ada compiler It's fine with me if you commit these, just please add detail to the commit messages first. Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZjCOxl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZCr0QEA2NWJu+oD52DyhoNBtTg7Czk2UWKT03Ar/wMy lQdo6CYA/Ay3nDFkC6XkSekAPUaK3kQGM+SyVKR4JII+6uRR1IgB =Z/QI -----END PGP SIGNATURE----- --=-=-=--