From: Sam James <sam@gentoo.org>
To: Alfredo Tupone <tupone@gentoo.org>
Cc: "Arsen Arsenović" <arsen@gentoo.org>,
gentoo-dev@lists.gentoo.org, toolchain@gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH 2/3] To build ada we need a c++ compiler too
Date: Tue, 30 Apr 2024 07:25:09 +0100 [thread overview]
Message-ID: <871q6nv03e.fsf@gentoo.org> (raw)
In-Reply-To: <20240426200604.51bb9471@alfredo.tupone.it> (Alfredo Tupone's message of "Fri, 26 Apr 2024 20:06:04 +0200")
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
Alfredo Tupone <tupone@gentoo.org> writes:
> On Fri, 26 Apr 2024 10:29:43 +0200
> Arsen Arsenović <arsen@gentoo.org> wrote:
>
>> > is_ada() {
>> > gcc-lang-supported ada || return 1
>> > - _tc_use_if_iuse ada
>> > + _tc_use_if_iuse cxx && _tc_use_if_iuse ada
>>
>> Is this redundant? Would gcc-lang-supported c++ (called through the
>> ada support check) not suffice?
>
> From what I understand this test is checking that both USE=cxx and
> USE=ada are enabled, and both cxx and ada are supported by gcc.
>
> If not, gcc is built without the ada compiler
It's fine with me if you commit these, just please add detail to the
commit messages first. Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]
next prev parent reply other threads:[~2024-04-30 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ada related changes to toolchain.eclass>
2024-04-25 15:44 ` [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Alfredo Tupone
2024-04-25 15:44 ` [gentoo-dev] [PATCH 2/3] To build ada we need a c++ compiler too Alfredo Tupone
2024-04-26 8:29 ` [gentoo-dev] " Arsen Arsenović
2024-04-26 18:06 ` Alfredo Tupone
2024-04-30 6:25 ` Sam James [this message]
2024-04-25 15:44 ` [gentoo-dev] [PATCH 3/3] A check that the compiler used to build ada is ada and not newer Alfredo Tupone
2024-04-26 8:34 ` [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Arsen Arsenović
2024-04-26 17:53 ` Alfredo Tupone
2024-04-30 8:51 ` Arsen Arsenović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q6nv03e.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=arsen@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=toolchain@gentoo.org \
--cc=tupone@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox