* [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment
@ 2022-09-20 15:17 Petr Vaněk
2022-09-26 10:06 ` Michał Górny
0 siblings, 1 reply; 2+ messages in thread
From: Petr Vaněk @ 2022-09-20 15:17 UTC (permalink / raw
To: gentoo-dev; +Cc: Python team, Petr Vaněk
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
---
eclass/distutils-r1.eclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 60f81473c0a..27bd9207743 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -728,8 +728,8 @@ esetup.py() {
# to unmerge the package first.
#
# This function is not available in PEP517 mode. The eclass provides
-# a venv-style install unconditionally therefore, and therefore it
-# should no longer be necessary.
+# a venv-style install unconditionally and therefore it should no longer
+# be necessary.
distutils_install_for_testing() {
debug-print-function ${FUNCNAME} "${@}"
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment
2022-09-20 15:17 [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment Petr Vaněk
@ 2022-09-26 10:06 ` Michał Górny
0 siblings, 0 replies; 2+ messages in thread
From: Michał Górny @ 2022-09-26 10:06 UTC (permalink / raw
To: gentoo-dev; +Cc: Python team, Petr Vaněk
On Tue, 2022-09-20 at 17:17 +0200, Petr Vaněk wrote:
> Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
> ---
> eclass/distutils-r1.eclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 60f81473c0a..27bd9207743 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -728,8 +728,8 @@ esetup.py() {
> # to unmerge the package first.
> #
> # This function is not available in PEP517 mode. The eclass provides
> -# a venv-style install unconditionally therefore, and therefore it
> -# should no longer be necessary.
> +# a venv-style install unconditionally and therefore it should no longer
> +# be necessary.
> distutils_install_for_testing() {
> debug-print-function ${FUNCNAME} "${@}"
>
Thanks for the patch. While this is definitely good, I'm a bit
reluctant to force the big cache regen for this, so I'd rather wait till
we have some more changes in queue. I'm a bit afraid I won't remember
about it though.
--
Best regards,
Michał Górny
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-26 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-20 15:17 [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment Petr Vaněk
2022-09-26 10:06 ` Michał Górny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox