From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Python team" <python@gentoo.org>, "Petr Vaněk" <arkamar@atlas.cz>
Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment
Date: Mon, 26 Sep 2022 12:06:58 +0200 [thread overview]
Message-ID: <86cee4684c5d9a47b2823738754c3d562e2279a4.camel@gentoo.org> (raw)
In-Reply-To: <20220920151747.31074-1-arkamar@atlas.cz>
On Tue, 2022-09-20 at 17:17 +0200, Petr Vaněk wrote:
> Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
> ---
> eclass/distutils-r1.eclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 60f81473c0a..27bd9207743 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -728,8 +728,8 @@ esetup.py() {
> # to unmerge the package first.
> #
> # This function is not available in PEP517 mode. The eclass provides
> -# a venv-style install unconditionally therefore, and therefore it
> -# should no longer be necessary.
> +# a venv-style install unconditionally and therefore it should no longer
> +# be necessary.
> distutils_install_for_testing() {
> debug-print-function ${FUNCNAME} "${@}"
>
Thanks for the patch. While this is definitely good, I'm a bit
reluctant to force the big cache regen for this, so I'd rather wait till
we have some more changes in queue. I'm a bit afraid I won't remember
about it though.
--
Best regards,
Michał Górny
prev parent reply other threads:[~2022-09-26 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:17 [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment Petr Vaněk
2022-09-26 10:06 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cee4684c5d9a47b2823738754c3d562e2279a4.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=arkamar@atlas.cz \
--cc=gentoo-dev@lists.gentoo.org \
--cc=python@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox