From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id CD250158064 for ; Tue, 30 Apr 2024 08:51:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4BBF1E2A35; Tue, 30 Apr 2024 08:51:49 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F0306E2A31 for ; Tue, 30 Apr 2024 08:51:48 +0000 (UTC) From: =?utf-8?Q?Arsen_Arsenovi=C4=87?= To: Alfredo Tupone Cc: gentoo-dev@lists.gentoo.org, toolchain@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work In-Reply-To: <20240426195306.7700e271@alfredo.tupone.it> (Alfredo Tupone's message of "Fri, 26 Apr 2024 19:53:06 +0200") Organization: Gentoo References: <20240425154537.32502-1-tupone@gentoo.org> <87h6foldy3.fsf@gentoo.org> <20240426195306.7700e271@alfredo.tupone.it> User-Agent: mu4e 1.12.4; emacs 30.0.50 Date: Tue, 30 Apr 2024 10:51:43 +0200 Message-ID: <86bk5rutb4.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: a32ad84c-bc50-4c8c-b463-249de4680b27 X-Archives-Hash: fa5707075aa6ed5477b1935fc9c2078a --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alfredo Tupone writes: > On Fri, 26 Apr 2024 10:34:44 +0200 > Arsen Arsenovi=C4=87 wrote: > >> looks OK at a glance, but could you summarize the issues the patch set >> fixes in the commit messages (and reword them to follow convention >> generally)? it is important to have context while looking at a git >> log. > >> > - IUSE+=3D" ada" >> > + IUSE+=3D" ada" TC_FEATURES+=3D( ada )=20=20 > > The change is about adding TC_FEATURES+=3D( ada ) > > Some lines towards the end there is=20 > > > # TODO: Add a pkg_setup & pkg_pretend check for whether the active > compiler # supports Ada. > if tc_has_feature ada ; then > BDEPEND+=3D" ada? ( || ( sys-devel/gcc[ada] dev-lang/gnat-gpl[ada] ) > )" > fi > > > it looks to me that if TC_FEATURES+=3D( ada ) is missing, that dependency > is not added Indeed, but it would be nice to be able to tell that from the git log. >>=20 >> does this apply for all versions of GCC? > > I really don't know. Ada source are provided with gcc-8 too (the oldest > version in the tree). I personally built gcc-10..13 That's good enough for our case I think (given we only have 8+ at all, and only 11+ are unmasked). Overall, probably OK. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOcEARYKAI8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZjCxH18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk/aJAQDnWrJULKXY7TzW/nwF08PKQGf1QTJwkstD mxdmGxlzLwEA0uFFiTYkRxC5pJSui71S0M8tagSCHHjSgYFuaELFSQE= =PuiV -----END PGP SIGNATURE----- --=-=-=--