From: "Arsen Arsenović" <arsen@gentoo.org>
To: Alfredo Tupone <tupone@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, toolchain@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work
Date: Tue, 30 Apr 2024 10:51:43 +0200 [thread overview]
Message-ID: <86bk5rutb4.fsf@gentoo.org> (raw)
In-Reply-To: <20240426195306.7700e271@alfredo.tupone.it> (Alfredo Tupone's message of "Fri, 26 Apr 2024 19:53:06 +0200")
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
Alfredo Tupone <tupone@gentoo.org> writes:
> On Fri, 26 Apr 2024 10:34:44 +0200
> Arsen Arsenović <arsen@gentoo.org> wrote:
>
>> looks OK at a glance, but could you summarize the issues the patch set
>> fixes in the commit messages (and reword them to follow convention
>> generally)? it is important to have context while looking at a git
>> log.
>
>> > - IUSE+=" ada"
>> > + IUSE+=" ada" TC_FEATURES+=( ada )
>
> The change is about adding TC_FEATURES+=( ada )
>
> Some lines towards the end there is
>
>
> # TODO: Add a pkg_setup & pkg_pretend check for whether the active
> compiler # supports Ada.
> if tc_has_feature ada ; then
> BDEPEND+=" ada? ( || ( sys-devel/gcc[ada] dev-lang/gnat-gpl[ada] )
> )"
> fi
>
>
> it looks to me that if TC_FEATURES+=( ada ) is missing, that dependency
> is not added
Indeed, but it would be nice to be able to tell that from the git log.
>>
>> does this apply for all versions of GCC?
>
> I really don't know. Ada source are provided with gcc-8 too (the oldest
> version in the tree). I personally built gcc-10..13
That's good enough for our case I think (given we only have 8+ at all,
and only 11+ are unmasked).
Overall, probably OK.
--
Arsen Arsenović
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]
prev parent reply other threads:[~2024-04-30 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ada related changes to toolchain.eclass>
2024-04-25 15:44 ` [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Alfredo Tupone
2024-04-25 15:44 ` [gentoo-dev] [PATCH 2/3] To build ada we need a c++ compiler too Alfredo Tupone
2024-04-26 8:29 ` [gentoo-dev] " Arsen Arsenović
2024-04-26 18:06 ` Alfredo Tupone
2024-04-30 6:25 ` Sam James
2024-04-25 15:44 ` [gentoo-dev] [PATCH 3/3] A check that the compiler used to build ada is ada and not newer Alfredo Tupone
2024-04-26 8:34 ` [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Arsen Arsenović
2024-04-26 17:53 ` Alfredo Tupone
2024-04-30 8:51 ` Arsen Arsenović [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bk5rutb4.fsf@gentoo.org \
--to=arsen@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=toolchain@gentoo.org \
--cc=tupone@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox