From: "Arsen Arsenović" <arsen@gentoo.org>
To: "Arsen Arsenović" <arsen@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: [PATCH] unpacker.eclass: Don't assume the default tar is stdin
Date: Thu, 06 Apr 2023 17:40:58 +0200 [thread overview]
Message-ID: <861qkx81cy.fsf@gentoo.org> (raw)
In-Reply-To: <20230406153744.1467666-1-arsen@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
Arsen Arsenović <arsen@gentoo.org> writes:
> Despite common misconception, the default GNU tar tarfile is not stdin.
> On some systems, this can cause tar to fail to extract relevant files.
>
> See '(tar)file tutorial' for a description of how the default is picked.
>
> Bug: https://bugs.gentoo.org/903631
> Closes: https://bugs.gentoo.org/903914
> Closes: https://bugs.gentoo.org/903919
>
> Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
> ---
> This patch does not close https://bugs.gentoo.org/903631, as I intend to
> turn that into a tracker bug.
Or not - amended locally to close it. See c6.
> eclass/unpacker.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
> index 650de4bd3f75..652527b52ec6 100644
> --- a/eclass/unpacker.eclass
> +++ b/eclass/unpacker.eclass
> @@ -325,7 +325,7 @@ unpack_deb() {
> $(tc-getBUILD_AR) p "${deb}" "${f}" | ${decomp:-cat}
> assert "unpacking ${f} from ${deb} failed"
> fi
> - } | tar --no-same-owner -x
> + } | tar --no-same-owner -xf -
> assert "unpacking ${deb} failed"
> }
--
Arsen Arsenović
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]
next prev parent reply other threads:[~2023-04-06 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 15:37 [gentoo-dev] [PATCH] unpacker.eclass: Don't assume the default tar is stdin Arsen Arsenović
2023-04-06 15:40 ` Arsen Arsenović [this message]
2023-04-06 15:41 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861qkx81cy.fsf@gentoo.org \
--to=arsen@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox