[gentoo-dev] [PATCH] linux-info.eclass: Remove local function.Calling code removed on Aug 3,2010

[gentoo-dev] [PATCH] linux-info.eclass: Remove local function.Calling code removed on Aug 3,2010

[Mike Pagano]

[-- Attachment #1.1.1: Type: text/plain, Size: 1152 bytes --]

This function was only called locally and the last use was almost 12 years ago

See: https://gitlab.com/rindeal/gentoo-cvs-history-archive/-/commit/1715ad
cd9e404075340e5a5ed82f88928feeffd9

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
  eclass/linux-info.eclass | 20 --------------------
  1 file changed, 20 deletions(-)

diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
index 8c502812f8f..d2003874da0 100644
--- a/eclass/linux-info.eclass
+++ b/eclass/linux-info.eclass
@@ -438,26 +438,6 @@ kernel_is() {
  		"${1:-${KV_MAJOR:-0}}.${2:-${KV_MINOR:-0}}.${3:-${KV_PATCH:-0}}"
  }
  
-get_localversion() {
-	local lv_list i x
-
-	local shopt_save=$(shopt -p nullglob)
-	shopt -s nullglob
-	local files=( ${1}/localversion* )
-	${shopt_save}
-
-	# ignore files with ~ in it.
-	for i in "${files[@]}"; do
-		[[ -n ${i//*~*} ]] && lv_list="${lv_list} ${i}"
-	done
-
-	for i in ${lv_list}; do
-		x="${x}$(<${i})"
-	done
-	x=${x/ /}
-	echo ${x}
-}
-
  # Check if the Makefile is valid for direct parsing.
  # Check status results:
  # - PASS, use 'getfilevar' to extract values
-- 
2.35.1


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 14179 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[gentoo-dev] Re: [PATCH] linux-info.eclass: Remove local function.Calling code removed on Aug 3,2010

[Mike Pagano]

[-- Attachment #1.1.1: Type: text/plain, Size: 1392 bytes --]

On 5/12/22 14:29, Mike Pagano wrote:
> This function was only called locally and the last use was almost 12 
> years ago
> 
> See: https://gitlab.com/rindeal/gentoo-cvs-history-archive/-/commit/1715ad
> cd9e404075340e5a5ed82f88928feeffd9
> 
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>   eclass/linux-info.eclass | 20 --------------------
>   1 file changed, 20 deletions(-)
> 
> diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
> index 8c502812f8f..d2003874da0 100644
> --- a/eclass/linux-info.eclass
> +++ b/eclass/linux-info.eclass
> @@ -438,26 +438,6 @@ kernel_is() {
>           "${1:-${KV_MAJOR:-0}}.${2:-${KV_MINOR:-0}}.${3:-${KV_PATCH:-0}}"
>   }
> 
> -get_localversion() {
> -    local lv_list i x
> -
> -    local shopt_save=$(shopt -p nullglob)
> -    shopt -s nullglob
> -    local files=( ${1}/localversion* )
> -    ${shopt_save}
> -
> -    # ignore files with ~ in it.
> -    for i in "${files[@]}"; do
> -        [[ -n ${i//*~*} ]] && lv_list="${lv_list} ${i}"
> -    done
> -
> -    for i in ${lv_list}; do
> -        x="${x}$(<${i})"
> -    done
> -    x=${x/ /}
> -    echo ${x}
> -}
> -
>   # Check if the Makefile is valid for direct parsing.
>   # Check status results:
>   # - PASS, use 'getfilevar' to extract values

Committed


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 14179 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]