From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: ruby@gentoo.org, Naohiro Aota <naota@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 5/9] ruby-ng-gnome2.eclass: add test dependency
Date: Sun, 16 Feb 2020 06:42:26 +0100 [thread overview]
Message-ID: <83fb18c6ab25119b080ac7e7675d34a7315e5537.camel@gentoo.org> (raw)
In-Reply-To: <20200215121833.3631177-5-naota@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Sat, 2020-02-15 at 21:18 +0900, Naohiro Aota wrote:
> Signed-off-by: Naohiro Aota <naota@gentoo.org>
> ---
> eclass/ruby-ng-gnome2.eclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/ruby-ng-gnome2.eclass b/eclass/ruby-ng-gnome2.eclass
> index edb420c9a3a8..dc48a53c58cd 100644
> --- a/eclass/ruby-ng-gnome2.eclass
> +++ b/eclass/ruby-ng-gnome2.eclass
> @@ -29,7 +29,9 @@ inherit ruby-fakegem multilib versionator
> IUSE=""
>
> DEPEND="virtual/pkgconfig"
> -ruby_add_bdepend "dev-ruby/pkg-config"
> +ruby_add_bdepend "
> + dev-ruby/pkg-config
> + test? ( >=dev-ruby/test-unit-2 )"
I don't know if ruby has some deep magic for this but it looks
suspicious to set test?-deps without adding IUSE=test and RESTRICT.
> RUBY_S=ruby-gnome2-all-${PV}/${RUBY_FAKEGEM_NAME}
> SRC_URI="mirror://sourceforge/ruby-gnome2/ruby-gnome2-all-${PV}.tar.gz"
> HOMEPAGE="https://ruby-gnome2.osdn.jp/"
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
next prev parent reply other threads:[~2020-02-16 5:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 12:18 [gentoo-dev] [PATCH 1/9] ruby-ng-gnome2.eclass: drop support for 0.19.x Naohiro Aota
2020-02-15 12:18 ` [gentoo-dev] [PATCH 2/9] ruby-ng-gnome2.eclass: drop support for <EAPI=4 Naohiro Aota
2020-02-16 5:40 ` Michał Górny
2020-02-17 21:40 ` Naohiro Aota
2020-02-15 12:18 ` [gentoo-dev] [PATCH 3/9] ruby-ng-gnome2.eclass: fix LICENSE Naohiro Aota
2020-02-15 12:18 ` [gentoo-dev] [PATCH 4/9] ruby-ng-gnome2.eclass: drop subbinding variable Naohiro Aota
2020-02-15 12:18 ` [gentoo-dev] [PATCH 5/9] ruby-ng-gnome2.eclass: add test dependency Naohiro Aota
2020-02-16 5:42 ` Michał Górny [this message]
2020-02-15 12:18 ` [gentoo-dev] [PATCH 6/9] ruby-ng-gnome2.eclass: implement common test code Naohiro Aota
2020-02-16 5:36 ` Michał Górny
2020-02-15 12:18 ` [gentoo-dev] [PATCH 7/9] ruby-ng-gnome2.eclass: support non-build packages Naohiro Aota
2020-02-16 5:43 ` Michał Górny
2020-02-15 12:18 ` [gentoo-dev] [PATCH 8/9] ruby-ng-gnome2.eclass: fold common all_ruby_prepare Naohiro Aota
2020-02-16 5:44 ` Michał Górny
2020-02-15 12:18 ` [gentoo-dev] [PATCH 9/9] ruby-ng-gnome2.eclass: add support for 3.4.x Naohiro Aota
2020-02-16 5:48 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fb18c6ab25119b080ac7e7675d34a7315e5537.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=naota@gentoo.org \
--cc=ruby@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox