public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Evans <grknight@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] linux-info.eclass: drop unnecessary IUSE="kernel_linux"
Date: Tue, 4 Jan 2022 12:46:22 -0500	[thread overview]
Message-ID: <8228e4c5-81ad-8852-d20e-13ad44a1ca4b@gentoo.org> (raw)
In-Reply-To: <20220104102348.221452-2-sam@gentoo.org>


[-- Attachment #1.1: Type: text/plain, Size: 564 bytes --]

On 1/4/2022 5:23 AM, Sam James wrote:
> It's already an implicit IUSE, so we don't need this.
> 
> Signed-off-by: Sam James <sam@gentoo.org>
> ---

This seems a bit excessive for something that will not change the end 
compilations in any way.

This one could just stay and not hurt anything.

The commits by soap on the same topic of kernel_* and elibc_* could have 
been done differently and eased into.

I really disagree with this move which just forces recompilation on 
@world update to dozens of packages in an install for no gain.

Brian

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2022-01-04 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 10:23 [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux" Sam James
2022-01-04 10:23 ` [gentoo-dev] [PATCH 2/2] linux-info.eclass: " Sam James
2022-01-04 17:46   ` Brian Evans [this message]
2022-01-04 16:17 ` [gentoo-dev] [PATCH 1/2] linux-mod.eclass: " Mike Gilbert
2022-01-04 21:54   ` Michał Górny
2022-01-04 22:55     ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8228e4c5-81ad-8852-d20e-13ad44a1ca4b@gentoo.org \
    --to=grknight@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox