[gentoo-dev] bash-4.0-r1 for ~arch

[gentoo-dev] bash-4.0-r1 for ~arch

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

unless i see any new issues come up, bash-4.0-r1 will be going into ~arch this 
week.  now would be a good time to sync up and try bash-4.0 on your system :p.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On 19:27 Mon 02 Mar     , Mike Frysinger wrote:
> unless i see any new issues come up, bash-4.0-r1 will be going into ~arch this 
> week.  now would be a good time to sync up and try bash-4.0 on your system :p.
> -mike

comet $ source /usr/share/bash-completion/genkernel
-bash: /usr/share/bash-completion/genkernel: line 50: unexpected EOF while looking for matching `)'
-bash: /usr/share/bash-completion/genkernel: line 74: syntax error: unexpected end of file

48    # generate a list of completions for the argument; this replaces args with
49    # an array of results
50    args=( $(case $args in
51    ('<0-5>') compgen -W "$(echo {1..5})" -- "$rhs" ;;
52    ('<outfile>'|'<file>') compgen -A file -o plusdirs -- "$rhs" ;;
53    ('<dir>') compgen -A directory -S / -- "$rhs" ;;
54    ('<tbz2>') compgen -G '*.tbz2' -G '*.tar.bz2' -o plusdirs -- "$rhs" ;;
55    (*) compgen -o bashdefault -- "$rhs" ;; # punt
56    esac) )


Actually seems like quite a few of the bash-completion scripts have 
issues with 4.0 ... might want to just run through those.

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Caleb Cushing]

On Mon, Mar 2, 2009 at 10:56 PM, Donnie Berkholz <dberkholz@gentoo.org> wrote:
> Actually seems like quite a few of the bash-completion scripts have
> issues with 4.0 ... might want to just run through those.

nam-1.11.ebuild has the same error. repoman can't source it.

/mnt/sda8/portdev/tree/regen2/net-analyzer/nam/nam-1.11.ebuild: line
36: unexpected EOF while looking for matching `)'
/mnt/sda8/portdev/tree/regen2/net-analyzer/nam/nam-1.11.ebuild: line
75: syntax error: unexpected end of file
 *
 * ERROR: net-analyzer/nam-1.11 failed.
 * Call stack:
 *               ebuild.sh, line 1881:  Called die
 * The specific snippet of code:
 *      source "${EBUILD}" || die "error sourcing ebuild"
 *  The die message:
 *   error sourcing ebuild
 *
 * If you need support, post the topmost build error, and the call
stack if relevant.
 *
!!! getFetchMap(): aux_get() error reading net-analyzer/nam-1.11;
aborting.
Unable to generate manifest.

out of all the ebuilds in the tree... it seems to be the only one with
a problem given that -r1 doesn't seem to have the issue removing it
sounds like a good idea.
-- 
Caleb Cushing

http://xenoterracide.blogspot.com

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

On Tuesday 03 March 2009 01:25:49 Caleb Cushing wrote:
> On Mon, Mar 2, 2009 at 10:56 PM, Donnie Berkholz wrote:
> > Actually seems like quite a few of the bash-completion scripts have
> > issues with 4.0 ... might want to just run through those.
>
> nam-1.11.ebuild has the same error. repoman can't source it.

it isnt the same error

> /mnt/sda8/portdev/tree/regen2/net-analyzer/nam/nam-1.11.ebuild: line
> 36: unexpected EOF while looking for matching `)'
> /mnt/sda8/portdev/tree/regen2/net-analyzer/nam/nam-1.11.ebuild: line
> 75: syntax error: unexpected end of file

look closely and you'll see it's simply wrong.  it's a bug if older versions 
of bash didnt reject it.

no idea what the code is trying to do with: $(#i)

a bug should be filed if one isnt already
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Caleb Cushing]

On Tue, Mar 3, 2009 at 1:39 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> look closely and you'll see it's simply wrong.  it's a bug if older versions
> of bash didnt reject it.

they didn't. given it's the one ebuild that failed to source by emerge
--regen in the whole tree and therefore failed reverse-transfer,
further investigation seems like a waste of time considering
nam-1.11-r1 sources fine.

> no idea what the code is trying to do with: $(#i)
>
> a bug should be filed if one isnt already

I haven't, I suppose I could. I still suggest just removing it.


-- 
Caleb Cushing

http://xenoterracide.blogspot.com

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Monday 02 March 2009 22:56:27 Donnie Berkholz wrote:
> On 19:27 Mon 02 Mar     , Mike Frysinger wrote:
> > unless i see any new issues come up, bash-4.0-r1 will be going into ~arch
> > this week.  now would be a good time to sync up and try bash-4.0 on your
> > system :p. -mike
>
> comet $ source /usr/share/bash-completion/genkernel
> -bash: /usr/share/bash-completion/genkernel: line 50: unexpected EOF while
> looking for matching `)' -bash: /usr/share/bash-completion/genkernel: line
> 74: syntax error: unexpected end of file
>
> 50    args=( $(case $args in
> 55    (*) compgen -o bashdefault -- "$rhs" ;; # punt
> 56    esac) )

comments in subshelled case statements is causing the problem.  drop the '# 
punt' and it's fine.

> Actually seems like quite a few of the bash-completion scripts have
> issues with 4.0 ... might want to just run through those.

i dont use bash completion so i dont have any actually installed.  run `bash -
n` on each one on your system and let me know which ones result in errors.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[gentoo-dev] Re: bash-4.0-r1 for ~arch

[ABCD]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mike Frysinger wrote:
> On Monday 02 March 2009 22:56:27 Donnie Berkholz wrote:
>> On 19:27 Mon 02 Mar     , Mike Frysinger wrote:
>>> unless i see any new issues come up, bash-4.0-r1 will be going into ~arch
>>> this week.  now would be a good time to sync up and try bash-4.0 on your
>>> system :p. -mike
>> comet $ source /usr/share/bash-completion/genkernel
>> -bash: /usr/share/bash-completion/genkernel: line 50: unexpected EOF while
>> looking for matching `)' -bash: /usr/share/bash-completion/genkernel: line
>> 74: syntax error: unexpected end of file
>>
>> 50    args=( $(case $args in
>> 55    (*) compgen -o bashdefault -- "$rhs" ;; # punt
>> 56    esac) )
>
> comments in subshelled case statements is causing the problem.  drop the '#
> punt' and it's fine.
>
>> Actually seems like quite a few of the bash-completion scripts have
>> issues with 4.0 ... might want to just run through those.
>
> i dont use bash completion so i dont have any actually installed.  run `bash -
> n` on each one on your system and let me know which ones result in errors.
> -mike

With my tests using bash 3.2, I noticed that a number of the
bash-completion scripts use extglob, so you will need to use
`bash -O extglob -n $script` to check for validity.

- --
ABCD

(lurked for a long while, just never had a reason to post)

(this is a resend, I don't think my first one actually got sent properly
- - my apologies if this is a duplicate)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkms1QkACgkQOypDUo0oQOqTQgCgzMSClpp+GNJI3oD4tD4PPrlH
TCUAoN4Z1YKdPTj4k7+r8dTez/eqgPei
=hpiY
-----END PGP SIGNATURE-----

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 4031 bytes --]

On 01:27 Tue 03 Mar     , Mike Frysinger wrote:
> On Monday 02 March 2009 22:56:27 Donnie Berkholz wrote:
> > Actually seems like quite a few of the bash-completion scripts have
> > issues with 4.0 ... might want to just run through those.
> 
> i dont use bash completion so i dont have any actually installed.  run `bash -
> n` on each one on your system and let me know which ones result in errors.

for i in *; do bash -n $i || echo FAILED $i; done

base: line 117: syntax error in conditional expression: unexpected token `('
base: line 117: syntax error near `*$1+(['
base: line 117: `    [[ "$( bind -v )" = *$1+([[:space:]])on* ]]'
FAILED base
bittorrent: line 14: syntax error near unexpected token `('
bittorrent: line 14: `          --@(responsefile|saveas))'
FAILED bittorrent
bzr: line 29: syntax error in conditional expression: unexpected token `('
bzr: line 29: syntax error near `@($'
bzr: line 29: ` if [[ ${COMP_WORDS[1]} != @($helpCmds) ]] && \'
FAILED bzr
dep: line 13: syntax error in conditional expression: unexpected token `('
dep: line 13: syntax error near `--${_dep_completion_shopt_long[$j]}?(='
dep: line 13: `                         [[ "${COMP_WORDS[$i]}" == --${_dep_completion_shopt_long[$j]}?(=*) ]] || continue'
FAILED dep
dsniff: line 74: syntax error near unexpected token `('
dsniff: line 74: `              -@(r|w|f))'
FAILED dsniff
freeciv: line 14: syntax error near unexpected token `('
freeciv: line 14: `             -@(f|g|l|r|-file|-log|-gamelog|-read))'
FAILED freeciv
genkernel: line 50: unexpected EOF while looking for matching `)'
genkernel: line 74: syntax error: unexpected end of file
gentoo: line 350: syntax error in conditional expression: unexpected token `('
gentoo: line 350: syntax error near `"-@(S'
gentoo: line 350: `     if [[ ${action} == "--search" ]] || [[ ${COMP_LINE} == *" "-@(S|-searchdesc)* ]] || \'
FAILED gentoo
gkrellm: line 14: syntax error near unexpected token `('
gkrellm: line 14: `             -@(t|-theme))'
FAILED gkrellm
gpg2: line 17: syntax error near unexpected token `('
gpg2: line 17: `                -@(s|-sign|-clearsign|-options|-decrypt))'
FAILED gpg2
herdstat: line 81: syntax error in conditional expression: unexpected token `('
herdstat: line 81: syntax error near `?(-'
herdstat: line 81: `                if [[ ${prev} == ?(-)-m?(etadata) ]] ; then'
FAILED herdstat
mailman: line 19: syntax error near unexpected token `('
mailman: line 19: `             -@(r|d|-regular-members-file=|-digest-members-file=))'
FAILED mailman
mcrypt: line 14: syntax error near unexpected token `('
mcrypt: line 14: `              -@(g|-openpgp-z))'
FAILED mcrypt
mercurial: line 100: syntax error in conditional expression: unexpected token `('
mercurial: line 100: syntax error near `@($'
mercurial: line 100: `      if [[ ${COMP_WORDS[i-1]} == @($filters|$global_args) ]]; then'
FAILED mercurial
modules: line 62: syntax error near unexpected token `('
modules: line 62: `      @(add|display|help|load|show|whatis))'
FAILED modules
monodevelop: line 35: syntax error in conditional expression: unexpected token `('
monodevelop: line 35: syntax error near `@(b'
monodevelop: line 35: `         if [[ ${COMP_WORDS[i]} == @(build|generate-makefiles|setup) ]]; then'
FAILED monodevelop
R: line 113: syntax error in conditional expression: unexpected token `('
R: line 113: syntax error near `@(-'
R: line 113: `    if [[ ${COMP_WORDS[$COMP_CWORD-1]} == @(-v|--version|RHOME|-h|--help) ]] ; then'
FAILED R
subversion: line 72: syntax error in conditional expression: unexpected token `('
subversion: line 72: syntax error near `@(d'
subversion: line 72: `  if [[ $opt == @(dir|all) && -d "$f" ]] ; then'
FAILED subversion
_subversion: line 33: syntax error near unexpected token `('
_subversion: line 33: `                 -@(F|-file|-targets))'
FAILED _subversion



-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

On 23:54 Mon 02 Mar     , Donnie Berkholz wrote:
> On 01:27 Tue 03 Mar     , Mike Frysinger wrote:
> > On Monday 02 March 2009 22:56:27 Donnie Berkholz wrote:
> > > Actually seems like quite a few of the bash-completion scripts have
> > > issues with 4.0 ... might want to just run through those.
> > 
> > i dont use bash completion so i dont have any actually installed.  run `bash -
> > n` on each one on your system and let me know which ones result in errors.
> 
> for i in *; do bash -n $i || echo FAILED $i; done

Meh. extglob fixes all these, including genkernel. Annoying that 
anything besides our bash-completion framework doesn't handle this right 
(because .pre isn't sourced in each script).

Thanks for the pointer!

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On Tuesday 03 March 2009 02:56:21 Donnie Berkholz wrote:
> On 23:54 Mon 02 Mar     , Donnie Berkholz wrote:
> > On 01:27 Tue 03 Mar     , Mike Frysinger wrote:
> > > On Monday 02 March 2009 22:56:27 Donnie Berkholz wrote:
> > > > Actually seems like quite a few of the bash-completion scripts have
> > > > issues with 4.0 ... might want to just run through those.
> > >
> > > i dont use bash completion so i dont have any actually installed.  run
> > > `bash - n` on each one on your system and let me know which ones result
> > > in errors.
> >
> > for i in *; do bash -n $i || echo FAILED $i; done
>
> Meh. extglob fixes all these, including genkernel. Annoying that
> anything besides our bash-completion framework doesn't handle this right
> (because .pre isn't sourced in each script).
>
> Thanks for the pointer!

the genkernel one you pointed out originally is a bug and ive posted something 
upstream for it

all the others seem to be extglob related as they use the extended pathname 
expansion syntax
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] bash-4.0-r1 for ~arch

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

On Monday 02 March 2009 22:56:27 Donnie Berkholz wrote:
> On 19:27 Mon 02 Mar     , Mike Frysinger wrote:
> > unless i see any new issues come up, bash-4.0-r1 will be going into ~arch
> > this week.  now would be a good time to sync up and try bash-4.0 on your
> > system :p. -mike
>
> comet $ source /usr/share/bash-completion/genkernel
> -bash: /usr/share/bash-completion/genkernel: line 50: unexpected EOF while
> looking for matching `)'
> -bash: /usr/share/bash-completion/genkernel: line 74: syntax error:
> unexpected end of file

this is fixed now, so unless people can find any other regressions, i'll 
continue with my original plans
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]