From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org,"Justin Lecher (jlec)" <jlec@gentoo.org>
Cc: qa@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ###
Date: Mon, 28 Dec 2015 15:34:56 +0100 [thread overview]
Message-ID: <8109CFB6-B300-448B-BA98-E7FA2F954757@gentoo.org> (raw)
In-Reply-To: <56814725.6080807@gentoo.org>
Dnia 28 grudnia 2015 15:28:53 CET, "Justin Lecher (jlec)" <jlec@gentoo.org> napisał(a):
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA512
>
>On 28/12/15 15:24, Michał Górny wrote:
>> Dnia 28 grudnia 2015 09:43:51 CET, Justin Lecher <jlec@gentoo.org>
>> napisał(a):
>>> Signed-off-by: Justin Lecher <jlec@gentoo.org> ---
>>> eclass/check-reqs.eclass | 2 +- 1 file changed, 1 insertion(+), 1
>>> deletion(-)
>>>
>>> diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass
>>> index 138bfec..a32f8f8 100644 --- a/eclass/check-reqs.eclass +++
>>> b/eclass/check-reqs.eclass @@ -306,7 +306,7 @@ check-reqs_disk()
>>> { ${size} \ "disk space at \"${path}\""
>>>
>>> - space_megs=$(df -Pm "${1}" 2>/dev/null | awk 'FNR == 2 {print
>>> $4}') + space_megs=$(df -P -B 1048576 "${1}" 2>/dev/null | awk
>>> 'FNR == 2 {print $4}')
>>
>> I don't want to spoil the party but '-B' doesn't seem portable. I
>> don't see that option in FreeBSD man page.
>
>The source code says
>
>
>case 'm': /* obsolescent, exists for BSD compatibility */
>
>
>So it might silently go away. Let me have a look at the BSD sources.
POSIX gives you '-k -P' only, so you should probably stick to that.
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG/MacGPG2 v2.0
>
>iQJ8BAEBCgBmBQJWgUclXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
>ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
>OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiiUgP/itabhl/43o8fY79y/cuZuRW
>xmvQirepGlHrqVZvgOGiBxyK2q0wpVhrsgHe/hwkK/lV8NA+C0eOIUW2wlwLiyEN
>T6UavwPFdoZ4YgNuj9m8ZCNbZVrJUyEFP01RUWuHyEah6MFBg+D8Jtl8vWNlzZKm
>W8z3KPDTrDhpcg8i+r9D915RARpo9wraTc/LvK8QXF51YuBcn1MWsRjd50g2FQiu
>R6Epylw7EmAL4AT9bhx7skdBS2z5GRHJQFEObYqtxve0PDdXOvw8SOcxwcqQXCv2
>ZCEuVCURfOlOOVdL1mgfIJa/h1FMO3n1NjrZXFFZtVNs1T3sYm9/lyYjGuYQIFP3
>ITkIVPBunjgbmG+wNRFOonNRDnxY0Y8F0AiaDNi07WpbkAoo52oHz9gWL/hsdhDd
>vfH074JoIVtoXS6yeaESPSwOlurQ30bwhpAz7xzWLW8sWopyR+sGkuW7AQ9PkmZc
>mwVX6ZIWBdZ6Zk5Ae7UNi3Lc3akSrz4GkiAlbLmxg946BMrTfJFIPBFvR82TkkNw
>+mRPJUPuiCWDDDyDKNCpGb/YQB8kjkiWHZkr1Id7PLhIIDkeuccVqvEvzTNU22pk
>DdQkUt9L69FxTE8OtskEDueaINaBMtBpGpPh5K+arsKUt85jIX4oM25IXau8HAWx
>mDTncoD6QRn2dNXuf5gx
>=O924
>-----END PGP SIGNATURE-----
--
Best regards,
Michał Górny (by phone)
next prev parent reply other threads:[~2015-12-28 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 8:43 [gentoo-dev] [PATCH 0/9] Cleanup and EAPI=6 support for check-reqs.eclass Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 1/9] check-reqs.eclass: Only inherit eclass once Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 2/9] check-reqs.eclass: Use eqawarn() from eutils.eclass Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 3/9] check-reqs.eclass: Mark interal function with @INTERNAL Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 4/9] check-reqs.eclass: Fix typo Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ### Justin Lecher
2015-12-28 13:58 ` Andrew Savchenko
2015-12-28 14:16 ` Justin Lecher (jlec)
2015-12-28 14:24 ` Michał Górny
2015-12-28 14:28 ` Justin Lecher (jlec)
2015-12-28 14:34 ` Michał Górny [this message]
2015-12-28 15:27 ` [gentoo-dev] [PATCH] Replace df -m with df -k Justin Lecher
2015-12-28 15:27 ` [gentoo-dev] [PATCH] check-reqs.eclass: Replace obsolete df option -m with -k Justin Lecher
2015-12-28 15:41 ` Michał Górny
2015-12-28 15:45 ` Justin Lecher (jlec)
2015-12-28 8:43 ` [gentoo-dev] [PATCH 6/9] check-reqs.eclass: Ban obsolete functions in newer EAPIs Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 7/9] check-reqs.eclass: Sanitize MERGE_TYPE for EAPI < 4 Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 8/9] check-reqs.eclass: Require units for CHECKREQS_ in EAPIs > 5 Justin Lecher
2015-12-28 8:43 ` [gentoo-dev] [PATCH 9/9] check-reqs.eclass: Enable EAPI 6 support Justin Lecher
2015-12-28 9:35 ` [gentoo-dev] [PATCH 0/9] Cleanup and EAPI=6 support for check-reqs.eclass Andrew Savchenko
2015-12-28 9:40 ` Justin Lecher (jlec)
2015-12-28 12:34 ` Andrew Savchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8109CFB6-B300-448B-BA98-E7FA2F954757@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=jlec@gentoo.org \
--cc=qa@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox