From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1C88E138334 for ; Sun, 20 Oct 2019 19:28:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 260CDE0C7A; Sun, 20 Oct 2019 19:28:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CA914E0C4D for ; Sun, 20 Oct 2019 19:28:20 +0000 (UTC) Received: from thinkpad.fritz.box (unknown [IPv6:2001:4060:c005:3f00:9491:b020:96bd:fae]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: soap) by smtp.gentoo.org (Postfix) with ESMTPSA id 26BF334C0B7 for ; Sun, 20 Oct 2019 19:28:18 +0000 (UTC) Message-ID: <7eab22170d59598c0452906865c9eecd13027a82.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] font.eclass: Ban EAPIs < 5 From: David Seifert To: gentoo-dev@lists.gentoo.org Date: Sun, 20 Oct 2019 21:28:15 +0200 In-Reply-To: References: <20191020165012.3498212-1-soap@gentoo.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Archives-Salt: 1c2dc185-ae30-4e4d-967c-ac5132df5566 X-Archives-Hash: b9ae292445daded87bcd79582e82bfe1 On Sun, 2019-10-20 at 20:57 +0200, Ulrich Mueller wrote: > > > > > > On Sun, 20 Oct 2019, David Seifert wrote: > > > > - [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs > > > > installation > > > > failed" ; } # TODO old EAPI cleanup > > > > + einstalldocs > > > > > > > > # install common docs > > > > - for commondoc in COPYRIGHT README{,.md,.txt} NEWS > > > > AUTHORS BUGS > > > > ChangeLog FONTLOG.txt; do > > > > + for commondoc in COPYRIGHT FONTLOG.txt; do > > > > [[ -s ${commondoc} ]] && dodoc ${commondoc} > > > > done > > > This changes the set of installed files, if the DOCS variable is > > > defined. Is that intentional? > > You mean if it's *not* defined? > > No, if it *is* defined. For example, if an ebuild defines DOCS but > doesn't include README.txt in the list, then that file was previously > being installed, but isn't any longer with the eclass change. Now I got it. Yes, this is fine because most fonts actually override DOCS and include README in there. > > > > This doesn't change any functionality, but it adds an overlong > > > line > > > for no good reason. > > The idea was to avoid if statements if you can use the more > > succinct > > form. > > Then at least wrap the long line. Still, I doubt that it will improve > readability, as compared to the original if statement. I'll fix it before pushing. > > Ulrich