From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B9A53158064 for ; Wed, 1 May 2024 14:11:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9BD22E2A17; Wed, 1 May 2024 14:11:00 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 04C0BE2A0F for ; Wed, 1 May 2024 14:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714572653; x=1715177453; i=martin.dummer@gmx.net; bh=pTLSn1z/QmGQE88f15LaYtiK677v0DxR0wB0j/lRMWs=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:From:Subject: Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=I/Tq8d3kqIAC3INW45osRTRSTrxKhuZF200i5YBr+9sEyAe5gbtaSpfNIlwdTeIi Qzm0fSq3U1E/E2q0KzEU2NwgIIQhGr6Vg6XamerTxvRh1d06SMdECYTs6mJYhKZZv BFj2GHxCbjo5SORcfSrqbqeeiEBgS3fJ0mmhXh8UIL0oz2UuSMzuClWIhWhCffex4 aJkiDXBekD9ESEVpSuHUvP4HPtRwAPqHD19r3YsUb8QP+XD22GfewTMVThc/E7MgV gNW8OI/2+Y2btOTR280ZE2tkmscvNkbWfYKBi+FKSZIi7ahaQP99jQbLulcVWL9J9 DZV3LRgHFp1T6kNw7g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.166.209] ([146.52.8.170]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXGrE-1s9IBf285u-00XSrk for ; Wed, 01 May 2024 16:10:53 +0200 Message-ID: <7e5a29e3-43e4-4af9-b7c5-660501a027a8@gmx.net> Date: Wed, 1 May 2024 16:10:53 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: gentoo-dev@lists.gentoo.org Content-Language: en-US From: Martin Dummer Subject: [gentoo-dev] [PATCH] vdr-plugin-2.eclass: make qa warning conditional Autocrypt: addr=martin.dummer@gmx.net; keydata= xsFNBFyXOk0BEAC0SrM62OIarfdzmzMLdbTBiWU2hFyLxVD2NHTe2fRnwtH1ergBLyrjuXx3 xM529HDCVcIJoKGgfm5TbmhDN2o5TVeamh9YOzLG60424R+u0tjEh6py9Bjg3VcKT4u11VOU KQUkOVRkwSo5lsWu6JZ+CkpS+pOD42wl3gSOO6ZvtMF0YHudW8NKSaXNz7khMakIhiWqU1oe 1q3XBZswpb5i1x415Wx7SPovBTs7Aw8xDb5qSndBts1lE56mq0i77P0u3TUT1/yE5kzEh/Nv 0VwcFfs2VAQTKAfrZrFVY2PVis8uhqQrA6a74YSkHUEDL/6A3RoLE2w6ZbC/bIPhcpHnvTXa 1cm++Wp5mg9ivAul22Lxc1d2TqK2nAjqEu5BpdIjdhYtXDYR5rLF9fA5OBy2ycUOK5QXtr9n BbzljWrnlWp4pJBdBNH3UqwrLJi1qfGpbK0Qr0NYYfcrt+iGkvmWxdu/CmrNEz/DsBuWvHMY W0G0mtopwZ4M8jPaYjdwCV75DifjByidEIoy1W9MMsI/KA7e5ZHNjk34bJUV8cuxT3nyttCV +XZjXkQb3YuypKOdFuerUYSx9cGQSXZysdkdny/B4XB9cMEqrwcKw7sD8dlFO5Hqe8xxJC40 xRY5/HT1jzf/ZLiH9iJgX55t8ncLmJDBKeySRjEfLqajsj9scwARAQABzSVNYXJ0aW4gRHVt bWVyIDxtYXJ0aW4uZHVtbWVyQGdteC5uZXQ+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQW AgMBAh4BAheAFiEEh6On4PuhCLLmLjy5zl8+m23gXRIFAmYoG3kFCQxiGZMACgkQzl8+m23g XRLiCRAAl5n0n2TrCSgp10Mk0qljxplf/iP3U/+mWq7ZeXl6De23jTGKCtne4e+DVfiiEf8N d+9H7UsdHxfEg6ajQcbTcwPb1NrGxxwJVEhPB3dTg2jgLJaI7wSt8LJcTHwbHt9GDbOxhXRH 8jt+Cq3lmpFesa5j5Z7KUazI+yXrMirjdB4Oj32jjv+Uj0S0GDEXQzZGjWoE2r87KXjV5VQ8 PYpdSD6jIiVa+BAG5x6JgKHUNahB8IDk5Tf3SMUW7qyfssSUmOZDgR0mGOaSxSJj0CJxp9e2 JIHoD4z9VhaNDeeHkzgsNXZtqvTue9JteQTOM8/pwfdPRng2Aoux87U9D0SaUDuqO6WFOhRQ j2O76U55LFj4s+d4XjGVp3pF13iTPEgZ9sS5cvlYQ7V4Dh2aNJxY+Ubx3azzPDlvgUsyYpeZ 1r3hBDHjx8KBe04dyeOjOPOl8atIBmGIk9tSyQUE3qtRIycoFw/UZ/D7yiMcMygWuxJ0KLtl Hpqv1UJXRFNTNYW400I9P41cYz0LM7Nr1j005bIyGkhqBqnUapi9uXicPBj3+xEcfGPAd/OA 38qKPUPtg0hrQs9KzkGtYHtTommeApkuZOKHOBAwTQmEzEga0B56AT63dzKnqadF9Bttac8A GjIZfQOjhAqThWw/7Sko5PmplJMcadLU5hwCVPllVnbOwE0EXJc6TQEIALUoGvhnsqO76OLt dysas6bLdEFjqsU8AKqyPHAL7b9Fvd2d9J5JPED0aGRAuR6GPpRhLHNUWTxzeKGgCl/xMay1 Kuo+A0LOACHBXMFHHArl+WVS6bCbFKJyYGGyxik9bfdYfm8gMvMNmJUjdGyWGLJ6+Pp4Q1Iy 8KkT/JcbdhcJ2y2fnNOrAu+ba2C5Oc0lJwDzZ59PtvhtuxFlFdOGOulDDNjLHPWP0vXr8yjQ X7b54uVxUFSBqo+1rzUX6Bkz3TSjNpfMDAzC/MgwYVOlpTDAbKNl5yABGfjER0DueyQogA5K o2A1Tk410zc5uiOg0Y4jjgA6tBPZ/NH4kr1FWzsAEQEAAcLBfAQYAQgAJgIbDBYhBIejp+D7 oQiy5i48uc5fPptt4F0SBQJmKBt5BQkMYhmTAAoJEM5fPptt4F0SDEoP/1ooRd8JS4nMYtWU QvqcucVl7V/hw/G65OmdU504jbP5K3xgV3/nMBkVmPYqi/Gtp7LfNkMSflRZXyFGsFyhUIr4 0Eya3w+mS3EnbaRh1ODOe/wOcdMJq+SzrAPY+9AbbIXhRCNvrFpTWUpsGfR3Cz+V+sCZQ7fy sQF86JpEyR+Stm22wXsuvfIzIZID3SKz3IYC+iYgt5h46v/xHid4vVyRPDypOtZ7giYn4HC7 XArdyXoWf0Id5OtzZCWGcNlZqaKZEzfz1IPzmAN7b/vgwpVnMD708lqa7zuv2Dv138WmkIgV EzgAvwCIB6B9jrL28PFI5ocs+EK2aAQj6x8Ite8sk/ozs219X3An+G1Rt+JHHWZc5DOxQFBs faddCZcffEmrrCdzUKV1/ba40donE8l6CSWC9mWGb1z58PH+gfpiTFvOgANGmQMpa71gjSLW j2dd3MXzIs6cXz2KyzfCm0SVYvkpNWS1l9FGE9m0BO2Mc7+wvcsFHptQSSCg+lMK+FzgwN9M wFTdxQllmdseKG5OkntdRLbQiHYqEz/H+Enwh+3HfrCsumLavXvOwuXQV3Z7QXxrtzzIdykb TXyBqji3zxdNt4YNSTelO1JhuSlv+XOdEKTBdmX8zZLT4OpZM7jGHC0SPdzqLjAbjUgXzg+U aFP1F3EqAqsljh7JsazD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jGNvxwTxfg5xfb9aMYF0aTQQLHCEqyRYbYY2YvyoWQIpCcnDDA7 e1AUFqXZ8CMQ4yUag2J8IplmzAgn/apFCA9Is10FgNIiR7HmF4e+/PySV54UPQXi4UWUTv9 MlDXxwp6VL2iVxYaJ6FDfXKLswfpkvjUjjHqttAypR18pbVV7k8yNDsOlKW5JXiHFHxSaBP X4No9BScVLz86pFBppd0g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BUv55vv44BQ=;r+FCfar7cSDaSSQYMR0OwN8stQC zTUf06C0EGCiOmv2Rj3N7RpkUMzU3lGz72SE+hUYzBmC9XiivPOkMD3HV3cWUBHGgv/lNfEe3 9AsyaRcR9a/Giqbf5dQFJ5VtUg6Fft2JzsAsyUirRpJFlPvRQX2y1wNTWkJ/FTvq44Tl3M/Uf qJaaNzeZcdfbYdLMoLvKS/r/kaZtIeQFrPGIeOnoxogvFrE0QaFdS8+6C9DGCvF6IKpV4R//O +SanpR94r3/ADRc8nvvmFg+eRutcN6OEJR2JfgXtoJo2IFJUHq3Opaw78bwe8pgS1L4ZcFbkm VPe+DSkEm806C+hCuKeqdSH4LWgtLnI6G+gCVilCEi7CwYukF/LUC6tZ4b2xje7VBVGfD1v/p ZQeK3hyIwA5sUoKFNkzMJFJ49f8yL20MPPWAH5qXomP/r2UFT/bxxpdZBY5rkJU1C66vdPo2z y+lUFq0pb8sRfqgozYJd2y8c+/mysiAuZEm2+rvqua9GrCPBwmsLUUuCkUWJ1FlU7FRq2i96S vuTW/BUMgOufhNCrnxQjBM/FrgRCKtnh1EdMQnUnOahPd9D9sLZ+8NqQiZeDylg+jXYsWBrCY V0HLtHJGpNoJF8tbxAFFhsP3jfs4TlG8cSqRrNruQyIWxlGtWtG79cSf9OTKX/KezHQMlAVb/ 9RV4CnG5Jy0Wgvv1vIcLwF04ZFXpBLxzpSqsxBIvLQpyIgm3h5ggzZ6IEyny5q0/XVvEksJEq RadaRuFlDLxKmCxz4avNOYarGNKodAWhBaRjvfA9xh9CfUlyRwg5i8BRAMQN5pcDTpBRYXDTJ lUCe1x3mCXdrGC+QoZa3A3A76gwef2r5fAs2Tfbkrojr8= X-Archives-Salt: d53fbf6a-117f-414c-b52a-6e7287222aeb X-Archives-Hash: b2a2298d76b1da616cc99655449978b0 Since Agostino's tinderbox tests now report qa warning, the group vdr@gentoo.org has 101 open bugs assigned, most of them caused by qa warnings from vdr-plugin-2.eclass. Many vdr plugins need small adjustments because API or makefile changes in upstream media-video/vdr which can be easily fixed with small changes. These warnings are only useful for the vdr plugin maintainers, so I propose they should (only) be reported as QA-warnings when the global variable =C2=A0=C2=A0=C2=A0 VDR_MAINTAINER_MODE=3D"1" is set in make.conf This patch is also put to github in https://github.com/gentoo/gentoo/pull/36504 The PR is lacking many many "Closes: ...." tags, which I will fill in soon= . Any comments? =2D- Martin ######################################################################## commit 00a0a3237729ec4886e07d9869fdfd6e0cd5f985 Author: Martin Dummer Date:=C2=A0=C2=A0 Wed May 1 14:49:37 2024 +0200 =C2=A0=C2=A0=C2=A0 vdr-plugin-2.eclass: make qa warning conditional =C2=A0=C2=A0=C2=A0 many vdr plugins need small adjustments because API or= makefile changes =C2=A0=C2=A0=C2=A0 in upstream media-video/vdr which can be easily fixed = with small changes =C2=A0=C2=A0=C2=A0 These fixes should (only) be reported as QA-warnings w= hen the global variable =C2=A0=C2=A0=C2=A0 VDR_MAINTAINER_MODE=3D"1" =C2=A0=C2=A0=C2=A0 is set in make.conf =C2=A0=C2=A0=C2=A0 Signed-off-by: Martin Dummer diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass index 8f56511032c8..bc9a88db59a5 100644 =2D-- a/eclass/vdr-plugin-2.eclass +++ b/eclass/vdr-plugin-2.eclass @@ -160,7 +160,6 @@ vdr_create_header_checksum_file() { =C2=A0# Plugins failed on compile with wrong path of libsi includes, =C2=A0# this can be fixed by 'function + space separated list of files' =C2=A0fix_vdr_libsi_include() { -=C2=A0=C2=A0=C2=A0 eqawarn "QA Notice: Fixing include of libsi-headers" =C2=A0=C2=A0=C2=A0=C2=A0 local f =C2=A0=C2=A0=C2=A0=C2=A0 for f; do =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 sed -i "${f}" \ @@ -244,7 +243,7 @@ vdr_gettext_missing() { =C2=A0=C2=A0=C2=A0=C2=A0 # plugins without converting to gettext =C2=A0=C2=A0=C2=A0=C2=A0 local GETTEXT_MISSING=3D$( grep xgettext Makefil= e ) -=C2=A0=C2=A0=C2=A0 if [[ -z ${GETTEXT_MISSING} ]]; then +=C2=A0=C2=A0=C2=A0 if [[ -z ${GETTEXT_MISSING} && -n ${VDR_MAINTAINER_MOD= E} ]]; then =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Notice: Plugin is= n't converted to gettext handling!" =C2=A0=C2=A0=C2=A0=C2=A0 fi =C2=A0} @@ -306,11 +305,15 @@ vdr_i18n() { =C2=A0=C2=A0=C2=A0=C2=A0 if [[ -n ${I18N_OBJECT} ]]; then =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [[ "${KEEP_I18NOBJECT:-no}= " =3D "yes" ]]; then -=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Noti= ce: Forced to keep i18n.o" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [[ -n ${VDR_M= AINTAINER_MODE} ]]; then +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 eqawarn "QA Notice: Forced to keep i18n.o" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 else =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 sed -i "s:= i18n.o::g" Makefile \ =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2= =A0=C2=A0 || die "sed failed to remove i18n from Makefile" -=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Noti= ce: OBJECT i18n.o found, removed per sed" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [[ -n ${VDR_M= AINTAINER_MODE} ]]; then +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 eqawarn "QA Notice: OBJECT i18n.o found, removed per sed" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0=C2=A0 fi @@ -318,7 +321,9 @@ vdr_i18n() { =C2=A0=C2=A0=C2=A0=C2=A0 if [[ -n ${I18N_STRING} ]]; then =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 sed -i "s:^extern[[:space:]]*const[[:space:]]*tI18nPhrase://static const tI18nPhrase:" i18n.h \ =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 || die "se= d failed to replace tI18nPhrase" -=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Notice: obsolete tI18nP= hrase found, disabled per sed, please recheck" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [[ -n ${VDR_MAINTAINER_MODE} ]];= then +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Noti= ce: obsolete tI18nPhrase found, disabled per sed, please recheck" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0=C2=A0 fi =C2=A0} @@ -337,7 +342,9 @@ vdr_remove_i18n_include() { =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 || die "sed failed to remove = i18n_include" =C2=A0=C2=A0=C2=A0=C2=A0 done -=C2=A0=C2=A0=C2=A0 eqawarn "QA Notice: removed i18n.h include in ${@}" +=C2=A0=C2=A0=C2=A0 if [[ -n ${VDR_MAINTAINER_MODE} ]]; then +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Notice: removed i18n.h = include in ${@}" +=C2=A0=C2=A0=C2=A0 fi =C2=A0} =C2=A0# @FUNCTION: vdr-plugin-2_print_enable_command @@ -568,7 +575,9 @@ vdr-plugin-2_src_install() { =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 DESTDIR=3D"${D%/}" \ =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 || die "emake install (makefi= le target) failed" =C2=A0=C2=A0=C2=A0=C2=A0 else -=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Notice: Plugin use stil= l the old Makefile handling" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [[ -n ${VDR_MAINTAINER_MODE} ]];= then +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 eqawarn "QA Noti= ce: Plugin use still the old Makefile handling" +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 insinto "${VDR_PLUGIN_DIR}" =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 doins libvdr-*.so.* =C2=A0=C2=A0=C2=A0=C2=A0 fi