[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-print/hplip: hplip-2.7.10.ebuild ChangeLog hplip-2.7.12.ebuild hplip-2.7.12-r1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-print/hplip: hplip-2.7.10.ebuild ChangeLog hplip-2.7.12.ebuild hplip-2.7.12-r1.ebuild

[Donnie Berkholz]

On 15:08 Sun 13 Jan     , Denis Dupeyron (calchan) wrote:
> 1.1                  net-print/hplip/hplip-2.7.12-r1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-print/hplip/hplip-2.7.12-r1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-print/hplip/hplip-2.7.12-r1.ebuild?rev=1.1&content-type=text/plain

> pkg_setup() {
> 	if ! use ppds ; then
> 		ewarn "Not installing built-in PPD files, which is probably not what you want."
> 		ewarn "You need USE=ppds if you want to install them."
> 	fi
> 	if use minimal ; then
> 		ewarn "Installing hpijs driver only, make sure you know what you are doing."
> 	else
> 		use parport && linux-info_pkg_setup
> 	fi
> 
> 	# avoid collisions with cups-1.2 compat symlinks
> 	if [ -e "${ROOT}"/usr/lib/cups/backend/hp ] && [ -e "${ROOT}"/usr/libexec/cups/backend/hp ]; then
> 		rm -f "${ROOT}"/usr/libexec/cups/backend/hp{,fax};
> 	fi

This deletion should probably happen in pkg_preinst() instead, so that a 
compilation failure doesn't result in changes to the filesystem.

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-print/hplip: hplip-2.7.10.ebuild ChangeLog hplip-2.7.12.ebuild hplip-2.7.12-r1.ebuild

[Denis Dupeyron]

On Jan 14, 2008 6:39 AM, Donnie Berkholz <dberkholz@gentoo.org> wrote:
> On 15:08 Sun 13 Jan     , Denis Dupeyron (calchan) wrote:
> > 1.1                  net-print/hplip/hplip-2.7.12-r1.ebuild
> >       # avoid collisions with cups-1.2 compat symlinks
> >       if [ -e "${ROOT}"/usr/lib/cups/backend/hp ] && [ -e "${ROOT}"/usr/libexec/cups/backend/hp ]; then
> >               rm -f "${ROOT}"/usr/libexec/cups/backend/hp{,fax};
> >       fi
>
> This deletion should probably happen in pkg_preinst() instead, so that a
> compilation failure doesn't result in changes to the filesystem.

Good point, thanks. I changed it.

Denis.
-- 
gentoo-dev@lists.gentoo.org mailing list