public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Michael Orlitzky <mjo@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 6/9] acct-{group,user}.eclass: WIP eclasses to maintain users/groups
Date: Wed, 5 Jun 2019 17:14:10 -0400	[thread overview]
Message-ID: <7abcd69f-cee8-0acd-db7a-c88268902e17@gentoo.org> (raw)
In-Reply-To: <20190605091257.12127-7-mgorny@gentoo.org>

On 6/5/19 5:12 AM, Michał Górny wrote:
> +
> +	# check for ACCT_USER_ID collisions early
> +	if [[ -n ${ACCT_USER_ENFORCE_ID} ]]; then
> +		local pwd=$(egetent passwd "${ACCT_USER_ID}")
> +		if [[ -n ${pwd} ]]; then
> +			eerror "The required UID is already taken by another user."
> +			eerror "  UID: ${ACCT_USER_ID} (needed for ${PN})"
> +			eerror "  current user: ${pwd}"
> +			die "UID ${ACCT_USER_ID} taken already"
> +		fi
> +	fi
> +}

If we set ACCT_USER_ENFORCE_ID=true in ftp-0.ebuild and then "emerge
acct-user/ftp" again, the second one dies with

  * The required UID is already taken by another user.
  *   UID: 21 (needed for ftp)

This prevents "emerge -e @world" from working, and would prevent an
upgrade to ftp-1.ebuild in the future.

We could augment the checks to ignore the existing user/group if its
name agrees with the one we're trying to create, but now I'm having deja
vu. I think this is another reason why I decided to go with a dummy file
installed under /var/lib to catch collisions: the PM will necessarily
ignore collisions from the same package.


  parent reply	other threads:[~2019-06-05 21:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05  9:12 [gentoo-dev] [PATCH v2 0/9] User/group packages Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 1/9] user.eclass: Do not create user-group automatically Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 2/9] user.eclass: Prevent automated home creation in useradd Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 3/9] user.eclass: Support disabling home directory creation Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 4/9] user.eclass: Support forcing specified UID/GID Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 5/9] user.eclass: Die if no free UID/GID is found Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 6/9] acct-{group,user}.eclass: WIP eclasses to maintain users/groups Michał Górny
2019-06-05 11:46   ` Ulrich Mueller
2019-06-06  4:56     ` Michał Górny
2019-06-05 19:10   ` Pacho Ramos
2019-06-06  4:57     ` Michał Górny
2019-06-06  7:05       ` Ulrich Mueller
2019-06-05 21:14   ` Michael Orlitzky [this message]
2019-06-06  5:02     ` Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 7/9] acct-group/ftp: Add 'ftp' group (GID 21) Michał Górny
     [not found]   ` <3868289f-1e37-631a-daeb-d1a4b2454669@gentoo.org>
2019-06-07  5:01     ` Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 8/9] acct-user/ftp: Add 'ftp' user (UID 21) Michał Górny
2019-06-05  9:12 ` [gentoo-dev] [PATCH v2 9/9] net-ftp/ftpbase: Utilize {group,user}/ftp Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7abcd69f-cee8-0acd-db7a-c88268902e17@gentoo.org \
    --to=mjo@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox