From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2BE6615808B for ; Thu, 15 Feb 2024 14:09:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 381BEE2A86; Thu, 15 Feb 2024 14:09:27 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7E8BE2A7A for ; Thu, 15 Feb 2024 14:09:26 +0000 (UTC) Message-ID: <79a0ee19f7a12c73cab622bfd52103ff326d5d53.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] games-strategy/wargus: Fix running it with games-engines/stratagus[debug] From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Thu, 15 Feb 2024 15:09:21 +0100 In-Reply-To: <30d6545e-c1b3-4b30-bad8-74274adbded1@gentoo.org> References: <20240215125325.19959-1-zzam@gentoo.org> <30d6545e-c1b3-4b30-bad8-74274adbded1@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-LwsrGqrg/cPM6SrpJXP5" User-Agent: Evolution 3.50.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 45ce6cdd-30fc-4111-9204-d3724eabf00a X-Archives-Hash: f5813025bc12038de3f4d8f1ee083ffb --=-LwsrGqrg/cPM6SrpJXP5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2024-02-15 at 14:21 +0100, zzam@gentoo.org wrote: > Am 15.02.24 um 13:59 schrieb Eli Schwartz: > > On 2/15/24 7:53 AM, Matthias Schwarzott wrote: > > > When stratagus is compiled with USE=3Ddebug, its executable is called > > > /usr/bin/stratatgus-dbg. > > >=20 > > > Signed-off-by: Matthias Schwarzott > > > --- > > > games-strategy/wargus/wargus-3.3.2.ebuild | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/games-strategy/wargus/wargus-3.3.2.ebuild b/games-strate= gy/wargus/wargus-3.3.2.ebuild > > > index fff6023fa177..3295b2911d48 100644 > > > --- a/games-strategy/wargus/wargus-3.3.2.ebuild > > > +++ b/games-strategy/wargus/wargus-3.3.2.ebuild > > > @@ -1,4 +1,4 @@ > > > -# Copyright 1999-2022 Gentoo Authors > > > +# Copyright 1999-2024 Gentoo Authors > > > # Distributed under the terms of the GNU General Public License v2 > > > =20 > > > EAPI=3D8 > > > @@ -46,10 +46,12 @@ pkg_pretend() { > > > } > > > =20 > > > src_configure() { > > > + local suffix=3D > > > + has_version games-engines/stratagus[debug] && suffix=3D-dbg > > > local mycmakeargs=3D( > > > -DGAMEDIR=3D"${EPREFIX}/usr/bin" > > > -DBINDIR=3D"${EPREFIX}/usr/bin" > > > - -DSTRATAGUS=3D"${EPREFIX}/usr/bin/stratagus" > > > + -DSTRATAGUS=3D"${EPREFIX}/usr/bin/stratagus${suffix}" > > > -DSHAREDIR=3D"${EPREFIX}/usr/share/stratagus/wargus" > > > -DICONDIR=3D/usr/share/icons/hicolor/64x64/apps > > > -DWITH_STORMLIB=3D$(usex bne) > >=20 > >=20 > >=20 > > Ok so this just means the package will be broken if you change the USE > > flags for stratagus and wargus doesn't get rebuilt. > >=20 > Exactly. It would even be simpler to patch that renaming out. I will=20 > send a change to stratagus-ebuild. >=20 > > Why is the executable name different, anyway? > >=20 > I have no clue. My guess is to have a separate executable. >=20 > This is from stratagus CMakeLists.txt: > =3D=3D=3D=3D cut =3D=3D=3D > if(CMAKE_BUILD_TYPE STREQUAL "Debug") > set_target_properties(stratagus PROPERTIES OUTPUT_NAME stratagus-dbg) > endif() > =3D=3D=3D=3D cut =3D=3D=3D >=20 Wait, why are we changing CMAKE_BUILD_TYPE in the first place?! --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-LwsrGqrg/cPM6SrpJXP5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmXOGxESHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOimAIAI/NtlGJRi/2NhCbGmUVCPeUSeRYtPxj lvjchhwqZSgzsS/MVp7HJuWacjgTAPemrN3q5qVwyrDcxGcN1iAfgTSByMP5qSBf zp7x+GV7PCSgcmvzFzTGrgzagcO+4PCWLeIlhSZX81rq1HNu3ExpXGf1mBWsqYeT FQ91fZL8H/h3anb9WAsTtem9f2NyqsmyCEJg3j69lNmqWqkwagOi4CFxaUgBNXTC b9cttXneq7pp8FD4I+TLzS4zdd8okEz8mWBuCwkewsI2pj6MrgNipjLjNTP552LQ ANsJBT3krzCUn9nOF/NFjcJTvr/OVXQCZFdt+NFZoIkcle9IsF+Eu6k= =yWLo -----END PGP SIGNATURE----- --=-LwsrGqrg/cPM6SrpJXP5--