Re: [gentoo-dev] [PATCH] games-strategy/wargus: Fix running it with games-engines/stratagus[debug]

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2221 bytes --]

On Thu, 2024-02-15 at 14:21 +0100, zzam@gentoo.org wrote:
> Am 15.02.24 um 13:59 schrieb Eli Schwartz:
> > On 2/15/24 7:53 AM, Matthias Schwarzott wrote:
> > > When stratagus is compiled with USE=debug, its executable is called
> > > /usr/bin/stratatgus-dbg.
> > > 
> > > Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> > > ---
> > >   games-strategy/wargus/wargus-3.3.2.ebuild | 6 ++++--
> > >   1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/games-strategy/wargus/wargus-3.3.2.ebuild b/games-strategy/wargus/wargus-3.3.2.ebuild
> > > index fff6023fa177..3295b2911d48 100644
> > > --- a/games-strategy/wargus/wargus-3.3.2.ebuild
> > > +++ b/games-strategy/wargus/wargus-3.3.2.ebuild
> > > @@ -1,4 +1,4 @@
> > > -# Copyright 1999-2022 Gentoo Authors
> > > +# Copyright 1999-2024 Gentoo Authors
> > >   # Distributed under the terms of the GNU General Public License v2
> > >   
> > >   EAPI=8
> > > @@ -46,10 +46,12 @@ pkg_pretend() {
> > >   }
> > >   
> > >   src_configure() {
> > > +	local suffix=
> > > +	has_version games-engines/stratagus[debug] && suffix=-dbg
> > >   	local mycmakeargs=(
> > >   		-DGAMEDIR="${EPREFIX}/usr/bin"
> > >   		-DBINDIR="${EPREFIX}/usr/bin"
> > > -		-DSTRATAGUS="${EPREFIX}/usr/bin/stratagus"
> > > +		-DSTRATAGUS="${EPREFIX}/usr/bin/stratagus${suffix}"
> > >   		-DSHAREDIR="${EPREFIX}/usr/share/stratagus/wargus"
> > >   		-DICONDIR=/usr/share/icons/hicolor/64x64/apps
> > >   		-DWITH_STORMLIB=$(usex bne)
> > 
> > 
> > 
> > Ok so this just means the package will be broken if you change the USE
> > flags for stratagus and wargus doesn't get rebuilt.
> > 
> Exactly. It would even be simpler to patch that renaming out. I will 
> send a change to stratagus-ebuild.
> 
> > Why is the executable name different, anyway?
> > 
> I have no clue. My guess is to have a separate executable.
> 
> This is from stratagus CMakeLists.txt:
> ==== cut ===
> if(CMAKE_BUILD_TYPE STREQUAL "Debug")
> 	set_target_properties(stratagus PROPERTIES OUTPUT_NAME stratagus-dbg)
> endif()
> ==== cut ===
> 

Wait, why are we changing CMAKE_BUILD_TYPE in the first place?!

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]