From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9E40B138346 for ; Mon, 6 Jan 2020 18:13:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5B43BE0903; Mon, 6 Jan 2020 18:13:56 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C527CE08BB for ; Mon, 6 Jan 2020 18:13:55 +0000 (UTC) Received: from pomiot (c142-245.icpnet.pl [85.221.142.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id E4F1434DDB7; Mon, 6 Jan 2020 18:13:52 +0000 (UTC) Message-ID: <760bc1e5f08a133ae661fadcb5f46e7e68ac3754.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH v2 2/4] kernel-build.eclass: Build logic for dist-kernels From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Mon, 06 Jan 2020 19:13:48 +0100 In-Reply-To: References: <20200105062741.82357-1-mgorny@gentoo.org> <20200105062741.82357-2-mgorny@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-xGizV4uLQCnCdhe871tZ" User-Agent: Evolution 3.32.5 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: a8de1002-d4fe-491c-9acb-386b5082d7e5 X-Archives-Hash: c1c68febbdc4f1910ccda80ab1a40d6d --=-xGizV4uLQCnCdhe871tZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2020-01-06 at 13:07 -0500, Mike Gilbert wrote: > On Mon, Jan 6, 2020 at 12:54 PM Micha=C5=82 G=C3=B3rny wrote: > > On Mon, 2020-01-06 at 12:43 -0500, Mike Gilbert wrote: > > > On Sun, Jan 5, 2020 at 1:27 AM Micha=C5=82 G=C3=B3rny wrote: > > > > +# @FUNCTION: kernel-build_src_configure > > > > +# @DESCRIPTION: > > > > +# Prepare the toolchain for building the kernel, get the default .= config > > > > +# or restore savedconfig, and get build tree configured for modpre= p. > > > > +kernel-build_src_configure() { > > > > + debug-print-function ${FUNCNAME} "${@}" > > > > + > > > > + # force ld.bfd if we can find it easily > > > > + local LD=3D"$(tc-getLD)" > > > > + if type -P "${LD}.bfd" &>/dev/null; then > > > > + LD+=3D.bfd > > > > + fi > > >=20 > > > Is there some reason not to use the tc-ld-disable-gold function? > > >=20 > >=20 > > Yes. As the name says, it covers gold usage only and not lld. >=20 > It might be a good idea to copy this logic to handle multi-word LD values= . >=20 > https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/toolchain-funcs.ecl= ass#n498 >=20 > Or, a nicer alternative would be to refactor tc-ld-disable-gold into 2 > functions: move most of the logic into a new function > "tc-ld-force-bfd", and update tc-ld-disable-gold to call the former if > tc-ld-is-gold is true. I can write a patch for that if you agree. >=20 Sure, that sounds like a good idea. Please also replace which(1) with 'type' while at it. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-xGizV4uLQCnCdhe871tZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl4TeNxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA57kwf9E4Ye0M8epmNvIsCFhvoFE8u8cjBzy7MweTuddLZpwkpu/WRKQ1ZtyRSy QF3fMcg+9IIw3BZ4SKorR6JJCX89ikdCmBTwmukFeGNuB5D3NLQVHlUpc/znx9PM axvcCJI+EvZyk5/vmoXaZMYs5hky6noaGuT2Oh5YLVJXuHSj3koRcAKdJAXEc1RG nxO+x7Kx3hDn3gWtlcYaN+dngk44ykxpILRT9JnuuHG5YHIPVxULNCROC8x8PRgY QA6v/EHJcrsA5Z7lTRLQpBTB4ZNxU/Vnds/0wHCTwHmpp3JvhqQK+6yndfjIbCWz Fh+JksSjMaPE9iSWTe2VwUA0QJEtyA== =dxhA -----END PGP SIGNATURE----- --=-xGizV4uLQCnCdhe871tZ--