From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/6] virtualx.eclass: Add quoting to workaround vim syntax hl bug
Date: Wed, 27 Jul 2022 09:09:00 +0100 [thread overview]
Message-ID: <73AAED43-0DFC-4D0D-9514-F7737BE18268@gentoo.org> (raw)
In-Reply-To: <20220727071722.277530-2-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
> On 27 Jul 2022, at 08:17, Michał Górny <mgorny@gentoo.org> wrote:
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/virtualx.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Please reference the vim bug (guessing it's https://github.com/vim/vim/issues/10673)
in the commit message and in the eclass I guess so that we know when it's fixed.
I love my bug links, okay?
> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> index b7a25c897b4a..5c4b39164cff 100644
> --- a/eclass/virtualx.eclass
> +++ b/eclass/virtualx.eclass
> @@ -53,7 +53,7 @@ case ${VIRTUALX_REQUIRED} in
> *)
> BDEPEND="${VIRTUALX_REQUIRED}? ( ${VIRTUALX_DEPEND} )"
> IUSE="${VIRTUALX_REQUIRED}"
> - [[ ${VIRTUALX_REQUIRED} == test ]] &&
> + [[ ${VIRTUALX_REQUIRED} == "test" ]] &&
> RESTRICT+=" !test? ( test )"
> ;;
> esac
> --
> 2.35.1
>
>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
next prev parent reply other threads:[~2022-07-27 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 7:17 [gentoo-dev] [PATCH 0/6] virtualx.eclass: Use Xvfb -displayfd ... + cleanup Michał Górny
2022-07-27 7:17 ` [gentoo-dev] [PATCH 1/6] virtualx.eclass: Add quoting to workaround vim syntax hl bug Michał Górny
2022-07-27 8:05 ` Ulrich Mueller
2022-07-27 8:09 ` Sam James [this message]
2022-07-27 7:17 ` [gentoo-dev] [PATCH 2/6] virtualx.eclass: Pass xvfbargs as an array Michał Górny
2022-07-27 7:17 ` [gentoo-dev] [PATCH 3/6] virtualx.eclass: Remove unused XHOST Michał Górny
2022-07-27 7:17 ` [gentoo-dev] [PATCH 4/6] virtualx.eclass: Inline XVFB Michał Górny
2022-07-27 7:17 ` [gentoo-dev] [PATCH 5/6] virtualx.eclass: Let Xvfb figure out the free DISPLAY Michał Górny
2022-07-27 7:20 ` Sam James
2022-07-27 7:17 ` [gentoo-dev] [PATCH 6/6] virtualx.eclass: Do not disable sandbox Michał Górny
2022-07-27 7:20 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73AAED43-0DFC-4D0D-9514-F7737BE18268@gentoo.org \
--to=sam@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox