[gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

Someone needs to grow up here.

----------  Weitergeleitete Nachricht  ----------

Betreff: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/
Datum: Mittwoch, 11. März 2020, 09:24:16 CET
Von: Patrice Clement <monsieurp@gentoo.org>
An: gentoo-commits@lists.gentoo.org

commit:     81a65d7da5b5e8b9e48323d13da05525d08b9551
Author:     Patrice Clement <monsieurp <AT> gentoo <DOT> org>
AuthorDate: Wed Mar 11 08:21:58 2020 +0000
Commit:     Patrice Clement <monsieurp <AT> gentoo <DOT> org>
CommitDate: Wed Mar 11 08:24:03 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81a65d7d

app-office/calcurse: drop package to m-n.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Patrice Clement <monsieurp <AT> gentoo.org>

 app-office/calcurse/metadata.xml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/app-office/calcurse/metadata.xml b/app-office/calcurse/metadata.xml
index d5b9396fdc3..aa7b56c65ee 100644
--- a/app-office/calcurse/metadata.xml
+++ b/app-office/calcurse/metadata.xml
@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
-<maintainer type="person">
-	<email>monsieurp@gentoo.org</email>
-</maintainer>
+<!-- maintainer-needed -->
 <longdescription>Calcurse is a text-based personal organizer which helps 
keeping
 track of events and everyday tasks. It contains a calendar, a 'todo' list, 
and
 puts your appointments in order. The user interface is configurable, and one 
can


-------------------------------------------------------------
-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer 
(council, qa, toolchain, base-system, perl, libreoffice)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Alec Warner]

[-- Attachment #1: Type: text/plain, Size: 2547 bytes --]

On Thu, Mar 12, 2020 at 9:54 AM Andreas K. Huettel <dilfridge@gentoo.org>
wrote:

> Someone needs to grow up here.
>

Meh, to me (someone who can't commit to ::gentoo) I have a few concerns
here. First, I don't see a lot of QA reverts on the gentoo-dev list. Is it
common practice to post reverts publicly? Second, I'm not aware that we
would revert for things like this. Most of the items you mention look
fairly minor (maybe the python comment looks impactful?) Why can't we fix
these items in a future commit, rather than revert? What did Patrice's
commit break?

I'm also not sure intimating that people are acting like children is
helpful.

-A


>
> ----------  Weitergeleitete Nachricht  ----------
>
> Betreff: [gentoo-commits] repo/gentoo:master commit in:
> app-office/calcurse/
> Datum: Mittwoch, 11. März 2020, 09:24:16 CET
> Von: Patrice Clement <monsieurp@gentoo.org>
> An: gentoo-commits@lists.gentoo.org
>
> commit:     81a65d7da5b5e8b9e48323d13da05525d08b9551
> Author:     Patrice Clement <monsieurp <AT> gentoo <DOT> org>
> AuthorDate: Wed Mar 11 08:21:58 2020 +0000
> Commit:     Patrice Clement <monsieurp <AT> gentoo <DOT> org>
> CommitDate: Wed Mar 11 08:24:03 2020 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81a65d7d
>
> app-office/calcurse: drop package to m-n.
>
> Package-Manager: Portage-2.3.89, Repoman-2.3.20
> Signed-off-by: Patrice Clement <monsieurp <AT> gentoo.org>
>
>  app-office/calcurse/metadata.xml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/app-office/calcurse/metadata.xml
> b/app-office/calcurse/metadata.xml
> index d5b9396fdc3..aa7b56c65ee 100644
> --- a/app-office/calcurse/metadata.xml
> +++ b/app-office/calcurse/metadata.xml
> @@ -1,9 +1,7 @@
>  <?xml version="1.0" encoding="UTF-8"?>
>  <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
>  <pkgmetadata>
> -<maintainer type="person">
> -       <email>monsieurp@gentoo.org</email>
> -</maintainer>
> +<!-- maintainer-needed -->
>  <longdescription>Calcurse is a text-based personal organizer which helps
> keeping
>  track of events and everyday tasks. It contains a calendar, a 'todo'
> list,
> and
>  puts your appointments in order. The user interface is configurable, and
> one
> can
>
>
> -------------------------------------------------------------
> --
> Andreas K. Hüttel
> dilfridge@gentoo.org
> Gentoo Linux developer
> (council, qa, toolchain, base-system, perl, libreoffice)
>

[-- Attachment #2: Type: text/html, Size: 3811 bytes --]

Re: [gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Am Donnerstag, 12. März 2020, 19:44:15 CET schrieb Alec Warner:
> On Thu, Mar 12, 2020 at 9:54 AM Andreas K. Huettel <dilfridge@gentoo.org>
> 
> wrote:
> > Someone needs to grow up here.
> 
> Meh, to me (someone who can't commit to ::gentoo) I have a few concerns
> here. First, I don't see a lot of QA reverts on the gentoo-dev list. Is it
> common practice to post reverts publicly? 

It somehow depends on
* how abysmal, and
* how typical

> I'm also not sure intimating that people are acting like children is
> helpful.

You seem to to have not much interaction with the person in question.



-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer 
(council, qa, toolchain, base-system, perl, libreoffice)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

On Thu, 2020-03-12 at 11:44 -0700, Alec Warner wrote:
> On Thu, Mar 12, 2020 at 9:54 AM Andreas K. Huettel <dilfridge@gentoo.org>
> wrote:
> 
> > Someone needs to grow up here.
> > 
> 
> Meh, to me (someone who can't commit to ::gentoo) I have a few concerns
> here. First, I don't see a lot of QA reverts on the gentoo-dev list. Is it
> common practice to post reverts publicly?

I suppose that a part of the problem is the default Reply-To in these
mails.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

Am Donnerstag, 12. März 2020, 20:23:56 CET schrieb Michał Górny:
> On Thu, 2020-03-12 at 11:44 -0700, Alec Warner wrote:
> > On Thu, Mar 12, 2020 at 9:54 AM Andreas K. Huettel <dilfridge@gentoo.org>
> > 
> > wrote:
> > > Someone needs to grow up here.
> > 
> > Meh, to me (someone who can't commit to ::gentoo) I have a few concerns
> > here. First, I don't see a lot of QA reverts on the gentoo-dev list. Is it
> > common practice to post reverts publicly?
> 
> I suppose that a part of the problem is the default Reply-To in these
> mails.

Which was deliberately added...

-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer 
(council, qa, toolchain, base-system, perl, libreoffice)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Chí-Thanh Christopher Nguyễn]

Alec Warner schrieb:
> On Thu, Mar 12, 2020 at 9:54 AM Andreas K. Huettel <dilfridge@gentoo.org 
> <mailto:dilfridge@gentoo.org>> wrote:
> 
>     Someone needs to grow up here.
> 
> 
> Meh, to me (someone who can't commit to ::gentoo) I have a few concerns here. 
> First, I don't see a lot of QA reverts on the gentoo-dev list. Is it common 
> practice to post reverts publicly? Second, I'm not aware that we would revert 
> for things like this. Most of the items you mention look fairly minor (maybe 
> the python comment looks impactful?) Why can't we fix these items in a future 
> commit, rather than revert? What did Patrice's commit break?

If the issues are so serious that we have to prevent any breakage/regressions 
from reaching users, I guess an alternative response would have been to 
p.mask the offending new ebuild. Unless the commit caused some tree-wide 
breakage which I can't see here however.


Best regards,
Chí-Thanh Christopher Nguyễn

Re: [gentoo-dev] Fwd: [gentoo-commits] repo/gentoo:master commit in: app-office/calcurse/

[Rich Freeman]

On Fri, Mar 13, 2020 at 1:29 AM Chí-Thanh Christopher Nguyễn
<chithanh@gentoo.org> wrote:
>
> Alec Warner schrieb:
> > On Thu, Mar 12, 2020 at 9:54 AM Andreas K. Huettel <dilfridge@gentoo.org
> > <mailto:dilfridge@gentoo.org>> wrote:
> >
> >     Someone needs to grow up here.
> >
> >
> > Meh, to me (someone who can't commit to ::gentoo) I have a few concerns here.
> > First, I don't see a lot of QA reverts on the gentoo-dev list. Is it common
> > practice to post reverts publicly? Second, I'm not aware that we would revert
> > for things like this. Most of the items you mention look fairly minor (maybe
> > the python comment looks impactful?) Why can't we fix these items in a future
> > commit, rather than revert? What did Patrice's commit break?
>
> If the issues are so serious that we have to prevent any breakage/regressions
> from reaching users, I guess an alternative response would have been to
> p.mask the offending new ebuild. Unless the commit caused some tree-wide
> breakage which I can't see here however.

Don't really want to comment on where the line should have been drawn
on this particular case, but the idea of reverting commits doesn't
seem particularly abhorrent, and certainly commits that don't create a
new ebuild couldn't be addressed with masking unless we want to impact
end users.

It seems like the drama here is mostly about how this ended up on the
lists vs just being a discussion between QA and the committer/etc.
Reading between the lines I'm not sure if it was ever intended to be
on the list at least initially.

If this was intended for public consumption it probably wouldn't hurt
to note why (hey, we're singling out this commit because it has this
error we've been seeing a lot of lately and you can see how this sort
of thing could sneak in...).  Otherwise it just seems like it causes
drama without actually achieving the desired impact.

-- 
Rich