From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F40DF158008 for ; Fri, 16 Jun 2023 15:52:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3F698E0928; Fri, 16 Jun 2023 15:52:56 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EEE1CE091A for ; Fri, 16 Jun 2023 15:52:55 +0000 (UTC) Message-ID: <700dda53aa77b7a27e800df55d19d86ad1902bef.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 4/5] cargo.eclass: Support separating crate names/versions via slash From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Fri, 16 Jun 2023 17:52:51 +0200 In-Reply-To: References: <20230616120739.8656-1-mgorny@gentoo.org> <20230616120739.8656-5-mgorny@gentoo.org> Organization: Gentoo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: cd296979-7b07-4872-b65d-f2dab5e3c2ba X-Archives-Hash: 25511c88910f4db3bfb9aa26437cdc68 On Fri, 2023-06-16 at 17:48 +0300, Denis Lisov wrote: > Hello Micha=C5=82, >=20 > On Fri, Jun 16, 2023 at 3:09=E2=80=AFPM Micha=C5=82 G=C3=B3rny wrote: > > Support specifying crate names and versions separated by forward slashe= s > > rather than hyphens. Since slashes are not valid in crate names, this > > makes splitting the tokens trivial and free of regular expressions. > > Effectively, the slash variant is roughly 180% faster: >=20 > As a developer using Rust I want to note that Cargo has a concept of > "package ID specification"[1] that usually uses pkgname@version > syntax, but AFAIK there's no prior art for using pkgname/version in > the ecosystem. Could it make sense to use pkgname@version for > consistency? >=20 I suppose so. The only reason I've used slash is because that could be used directly in URL. --=20 Best regards, Micha=C5=82 G=C3=B3rny