public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zurab Kvachadze <zurabid2016@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC PATCH v2 04/20] www-servers/nginx: add nginx.tmpfiles for managing /var/tmp/nginx
Date: Tue, 30 Jul 2024 08:01:52 +0000	[thread overview]
Message-ID: <6xv3cz7rj4losgfwrnqwme2k7fosutrzgq7mfm6ehlibheannm@h2ryuhz4yljz> (raw)
In-Reply-To: <a9d6f3bd-b76f-4b27-8118-8c5e64f18941@bricart.de>

On Tue, 2024-07-30 at 09:12 +0000, Christian Bricart wrote:
> just my 2¢ here and sorry if I might have overlookt a rationale earlier
> 
> why moving nginx's temp dir to "generic purpose" /var/tmp/… and not keeping
> it at /var/lib/nginx/tmp/* ?

TLDR: Because /var/tmp is designated for temporary files, unlike /var/lib.

The Filesystem Hierarchy Standard (FHS)[1] describes /var/tmp as a directory
storing "temporary files preserved between reboots"[2], which is much closer to
our purpose of storing temporary NGINX files. Conversely, /var/lib stores
persistent information (databases, etc.), not temporary files.

Note: While FHS is not an authoritative standard for Gentoo, it is a good set of
sensible guidelines for a software packager.

[1]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html
[2]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s15.html

> Especially, when there even is/would be a tmpfiles entry taking care of it's
> existence and ownership.
> 
> Christian
> 
> Am 29.07.24 um 23:52 schrieb Zurab Kvachadze:
> > This places the burden on creating and cleaning /var/tmp/nginx in
> > world-writable /var/tmp on systemd-tmpfiles(8).
> > 
> > Signed-off-by: Zurab Kvachadze <zurabid2016@gmail.com>
> > ---
> >   www-servers/nginx/files/nginx.tmpfiles | 2 ++
> >   1 file changed, 2 insertions(+)
> >   create mode 100644 www-servers/nginx/files/nginx.tmpfiles
> > 
> > diff --git a/www-servers/nginx/files/nginx.tmpfiles b/www-servers/nginx/files/nginx.tmpfiles
> > new file mode 100644
> > index 000000000000..af9cdd26973f
> > --- /dev/null
> > +++ b/www-servers/nginx/files/nginx.tmpfiles
> > @@ -0,0 +1,2 @@
> > +D /var/tmp/nginx 0755 root root
> > +x /var/tmp/nginx


  reply	other threads:[~2024-07-30  8:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 21:52 [gentoo-dev] [RFC PATCH v2 00/20] Rework NGINX packaging in Gentoo by introducing nginx{,-module}.eclass Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 01/20] nginx.eclass: Add new eclass for building the NGINX server Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 02/20] nginx-module.eclass: Add new eclass for building NGINX external modules Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 03/20] www-servers/nginx: add myself as a proxy maintainer; update metadata.xml Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 04/20] www-servers/nginx: add nginx.tmpfiles for managing /var/tmp/nginx Zurab Kvachadze
2024-07-30  7:12   ` Christian Bricart
2024-07-30  8:01     ` Zurab Kvachadze [this message]
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 05/20] www-servers/nginx: add nginx-r5.initd Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 06/20] www-servers/nginx: add nginx-r1.confd Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 07/20] www-servers/nginx: add nginx-r2.service Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 08/20] www-servers/nginx: add nginx-r2.logrotate Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 09/20] www-servers/nginx: add nginx-r4.conf Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 10/20] profiles/desc: reword and update nginx_modules_http.desc Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 11/20] profiles/desc: reword and update nginx_modules_mail.desc Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 12/20] profiles/desc: reword and update nginx_modules_stream.desc Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 13/20] profiles/categories: Add www-nginx category for external NGINX modules Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 14/20] www-servers/nginx: revbump 1.26.1-r1 to 1.26.1-r2, use nginx.eclass Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 15/20] www-servers/nginx: revbump 1.27.0-r1 to 1.27.0-r2, " Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 16/20] www-servers/nginx: add 9999 live version, " Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 17/20] www-nginx/ngx_devel_kit: new package, add 0.3.3 Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 18/20] www-nginx/ngx-echo: new package, add 0.63 Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 19/20] www-nginx/ngx-encrypted-session: new package, add 0.09 Zurab Kvachadze
2024-07-29 21:52 ` [gentoo-dev] [RFC PATCH v2 20/20] www-nginx/ngx-set-misc: new package, add 0.33 Zurab Kvachadze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6xv3cz7rj4losgfwrnqwme2k7fosutrzgq7mfm6ehlibheannm@h2ryuhz4yljz \
    --to=zurabid2016@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox