[gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike Pagano]

This change will support moving the genpatches tarballs from /space/distfiles-local to
the devspace ~developer/public_html/dist/genpatches

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
 eclass/kernel-2.eclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index c5f35cd3e..0bc4f35de 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -295,7 +295,9 @@ handle_genpatches() {
                        UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
                        debug-print "genpatches tarball: $tarball"
                fi
-               GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
+               GENPATCHES_URI+=" ${use_cond_start}https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} 
+                       ${use_cond_start}https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} 
+                       ${use_cond_start}https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"
        done
 }
 
-- 
2.21.0

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

>>>>> On Wed, 09 Oct 2019, Mike Pagano wrote:

> -               GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
> +               GENPATCHES_URI+=" ${use_cond_start}https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} 
> +                       ${use_cond_start}https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} 
> +                       ${use_cond_start}https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"

Why is the USE conditional repeated three times? These URLs could all be
inside the same block.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: [gentoo-dev] [PATCH v2 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike Pagano]

Thanks for the suggestion. This is version 2

This change will support moving the genpatches tarballs from /space/distfiles-local to
the devspace ~developer/public_html/dist/genpatches.


Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
 eclass/kernel-2.eclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index c5f35cd3e..4b861beec 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -295,7 +295,9 @@ handle_genpatches() {
                        UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
                        debug-print "genpatches tarball: $tarball"
                fi
-               GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
+               GENPATCHES_URI+=" ${use_cond_start}https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}
+                       https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}
+                       https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"
        done
 }

--
2.21.0

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

Re: [gentoo-dev] [PATCH v2 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1542 bytes --]

On Wed, 2019-10-09 at 15:31 -0400, Mike Pagano wrote:
> Thanks for the suggestion. This is version 2
> 
> This change will support moving the genpatches tarballs from /space/distfiles-local to
> the devspace ~developer/public_html/dist/genpatches.
> 
> 
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>  eclass/kernel-2.eclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> index c5f35cd3e..4b861beec 100644
> --- a/eclass/kernel-2.eclass
> +++ b/eclass/kernel-2.eclass
> @@ -295,7 +295,9 @@ handle_genpatches() {
>                         UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
>                         debug-print "genpatches tarball: $tarball"
>                 fi
> -               GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
> +               GENPATCHES_URI+=" ${use_cond_start}https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}
> +                       https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}
> +                       https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"

Given that yours is the only name I see on woodpecker, do we need to
proactively add all dead URLs in there?  I'd rather have people add them
when they actually going to use them (and I think that would qualify
as the kind of change not needing ml review then).

>         done
>  }
> 
> --
> 2.21.0
> 

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike Pagano]

This change will support moving the genpatches tarballs from /space/distfiles-local to
the devspace ~developer/public_html/dist/genpatches.

Co-authored-by: Thomas Deutschmann <whissi@gentoo.org>

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
 eclass/kernel-2.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index c5f35cd3e..62e6c23e1 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -295,7 +295,7 @@ handle_genpatches() {
      UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
      debug-print "genpatches tarball: $tarball"
    fi
-   GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
+   GENPATCHES_URI+=" ${use_cond_start}$(echo https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
  done
 }

-- 
2.21.0

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Alec Warner]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <mpagano@gentoo.org> wrote:

> This change will support moving the genpatches tarballs from
> /space/distfiles-local to
> the devspace ~developer/public_html/dist/genpatches
>

I think it would help if you discussed why we were making this change. (I
mean I can guess why, but it's not obvious.)

-A


>
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>  eclass/kernel-2.eclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> index c5f35cd3e..0bc4f35de 100644
> --- a/eclass/kernel-2.eclass
> +++ b/eclass/kernel-2.eclass
> @@ -295,7 +295,9 @@ handle_genpatches() {
>                         UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
>                         debug-print "genpatches tarball: $tarball"
>                 fi
> -               GENPATCHES_URI+="
> ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
> +               GENPATCHES_URI+=" ${use_cond_start}
> https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end}
> +                       ${use_cond_start}
> https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end}
> +                       ${use_cond_start}
> https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"
>         done
>  }
>
> --
> 2.21.0
>
> --
> Mike Pagano
> Gentoo Developer - Kernel Project
> Gentoo Sources - Member
> E-Mail     : mpagano@gentoo.org
> GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
> Public Key :
> http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>
>

[-- Attachment #2: Type: text/html, Size: 2925 bytes --]

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

>>>>> On Thu, 10 Oct 2019, Mike Pagano wrote:

> +   GENPATCHES_URI+=" ${use_cond_start}$(echo https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"

The ~ should be backslash-escaped or quoted, otherwise it will be
expanded if there's a user mpagano or whissi on the system. :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike Pagano]

On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote:
>    On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <[1]mpagano@gentoo.org>
>    wrote:
> 
>      This change will support moving the genpatches tarballs from
>      /space/distfiles-local to
>      the devspace ~developer/public_html/dist/genpatches
> 
>    I think it would help if you discussed why we were making this change.
>    (I mean I can guess why, but it's not obvious.)
>    -A
>    Â

I was informed that use of /space/distfiles-local is deprecated in favor
of devspace.


https://devmanual.gentoo.org/general-concepts/mirrors/index.html





> 
>      Signed-off-by: Mike Pagano <[2]mpagano@gentoo.org>
>      ---
>      Â eclass/kernel-2.eclass | 4 +++-
>      Â 1 file changed, 3 insertions(+), 1 deletion(-)
>      diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
>      index c5f35cd3e..0bc4f35de 100644
>      --- a/eclass/kernel-2.eclass
>      +++ b/eclass/kernel-2.eclass
>      @@ -295,7 +295,9 @@ handle_genpatches() {
>      Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  UNIPATCH_LIST_GENPATCHES+="
>      ${DISTDIR}/${tarball}"
>      Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  debug-print "genpatches tarball:
>      $tarball"
>      Â  Â  Â  Â  Â  Â  Â  Â  fi
>      -Â  Â  Â  Â  Â  Â  Â  Â GENPATCHES_URI+="
>      ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
>      +Â  Â  Â  Â  Â  Â  Â  Â GENPATCHES_URI+="
>      ${use_cond_start}[3]https://dev.gentoo.org/~mpagano/dist/genpatches/
>      ${tarball}${use_cond_end}
>      +Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â
>      Â ${use_cond_start}[4]https://dev.gentoo.org/~whissi/dist/genpatches
>      /${tarball}${use_cond_end}
>      +Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â
>      Â ${use_cond_start}[5]https://dev.gentoo.org/~alicef/dist/genpatches
>      /${tarball}${use_cond_end}"
>      Â  Â  Â  Â  done
>      Â }
>      --
>      2.21.0
>      --
>      Mike Pagano
>      Gentoo Developer - Kernel Project
>      Gentoo Sources - Member
>      E-Mail     : [6]mpagano@gentoo.org
>      GnuPG FPÂ  Â : EEE2 601D 0763 B60F 848CÂ  9E14 3C33 C650 B576 E4E3
>      Public Key :
>      [7]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
> 
> References
> 
>    1. mailto:mpagano@gentoo.org
>    2. mailto:mpagano@gentoo.org
>    3. https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end}
>    4. https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end}
>    5. https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}
>    6. mailto:mpagano@gentoo.org
>    7. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

Re: [gentoo-dev] [PATCH v4 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike Pagano]

This change will support moving the genpatches tarballs from /space/distfiles-local to
the devspace ~developer/public_html/dist/genpatches.

Additional modifications based on feedback.

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
 eclass/kernel-2.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index c5f35cd3e..42307b963 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -295,7 +295,7 @@ handle_genpatches() {
      UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
      debug-print "genpatches tarball: $tarball"
    fi
-   GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
+   GENPATCHES_URI+=" ${use_cond_start}$(echo https://dev.gentoo.org/\~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
  done
 }

-- 
2.21.0

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mikle Kolyada]

[-- Attachment #1.1: Type: text/plain, Size: 923 bytes --]


On 10.10.2019 13:04, Mike Pagano wrote:
> On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote:
>>    On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <[1]mpagano@gentoo.org>
>>    wrote:
>>
>>      This change will support moving the genpatches tarballs from
>>      /space/distfiles-local to
>>      the devspace ~developer/public_html/dist/genpatches
>>
>>    I think it would help if you discussed why we were making this change.
>>    (I mean I can guess why, but it's not obvious.)
>>    -A
>>    Â
> I was informed that use of /space/distfiles-local is deprecated in favor
> of devspace.
>
>
> https://devmanual.gentoo.org/general-concepts/mirrors/index.html
>
>

This is not really true,  (otherwise we would have to upload literally
8500 tarballs for texlive to my devspace).

I'd say narrowing an eclass' URIs to the selected group of people is
even worse for long-term usage.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Thomas Deutschmann]

[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]

On 2019-10-10 10:56, Ulrich Mueller wrote:
>>>>>> On Thu, 10 Oct 2019, Mike Pagano wrote:
> 
>> +   GENPATCHES_URI+=" ${use_cond_start}$(echo https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
> 
> The ~ should be backslash-escaped or quoted, otherwise it will be
> expanded if there's a user mpagano or whissi on the system. :-)

Just curious, are you sure? I think this is wrong:

Tilde expansion only happens when string to expand starts with "~" but
this is not the case here (string starts with "https...").

I also tried that code and it's working fine for me...


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Alec Warner]

[-- Attachment #1: Type: text/plain, Size: 3444 bytes --]

On Thu, Oct 10, 2019 at 3:04 AM Mike Pagano <mpagano@gentoo.org> wrote:

> On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote:
> >    On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <[1]mpagano@gentoo.org>
> >    wrote:
> >
> >      This change will support moving the genpatches tarballs from
> >      /space/distfiles-local to
> >      the devspace ~developer/public_html/dist/genpatches
> >
> >    I think it would help if you discussed why we were making this change.
> >    (I mean I can guess why, but it's not obvious.)
> >    -A
> >    Ā
>
> I was informed that use of /space/distfiles-local is deprecated in favor
> of devspace.
>
> https://devmanual.gentoo.org/general-concepts/mirrors/index.html


That policy was made in 2011; so clearly it's not super urgent nor
stringently applied. Which is to say, I'm not sure it needs to be a policy.

-A


>
>
>
>
>
>
> >
> >      Signed-off-by: Mike Pagano <[2]mpagano@gentoo.org>
> >      ---
> >      Ā eclass/kernel-2.eclass | 4 +++-
> >      Ā 1 file changed, 3 insertions(+), 1 deletion(-)
> >      diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> >      index c5f35cd3e..0bc4f35de 100644
> >      --- a/eclass/kernel-2.eclass
> >      +++ b/eclass/kernel-2.eclass
> >      @@ -295,7 +295,9 @@ handle_genpatches() {
> >      Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  UNIPATCH_LIST_GENPATCHES+="
> >      ${DISTDIR}/${tarball}"
> >      Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  debug-print "genpatches tarball:
> >      $tarball"
> >      Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  fi
> >      -Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā GENPATCHES_URI+="
> >      ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
> >      +Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā GENPATCHES_URI+="
> >      ${use_cond_start}[3]
> https://dev.gentoo.org/~mpagano/dist/genpatches/
> >      ${tarball}${use_cond_end}
> >      +Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā
> >      Ā ${use_cond_start}[4]
> https://dev.gentoo.org/~whissi/dist/genpatches
> >      /${tarball}${use_cond_end}
> >      +Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā  Ā
> >      Ā ${use_cond_start}[5]
> https://dev.gentoo.org/~alicef/dist/genpatches
> >      /${tarball}${use_cond_end}"
> >      Ā  Ā  Ā  Ā  done
> >      Ā }
> >      --
> >      2.21.0
> >      --
> >      Mike Pagano
> >      Gentoo Developer - Kernel Project
> >      Gentoo Sources - Member
> >      E-MailĀ  Ā  Ā : [6]mpagano@gentoo.org
> >      GnuPG FPĀ  Ā : EEE2 601D 0763 B60F 848CĀ  9E14 3C33 C650 B576 E4E3
> >      Public Key :
> >      [7]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
> >
> > References
> >
> >    1. mailto:mpagano@gentoo.org
> >    2. mailto:mpagano@gentoo.org
> >    3.
> https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end}
> >    4.
> https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end}
> >    5.
> https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}
> >    6. mailto:mpagano@gentoo.org
> >    7. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>
> --
> Mike Pagano
> Gentoo Developer - Kernel Project
> Gentoo Sources - Member
> E-Mail     : mpagano@gentoo.org
> GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
> Public Key :
> http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>
>

[-- Attachment #2: Type: text/html, Size: 6022 bytes --]

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike Pagano]

On Fri, Oct 11, 2019 at 11:28:48AM -0700, Alec Warner wrote:
>    On Thu, Oct 10, 2019 at 3:04 AM Mike Pagano <[1]mpagano@gentoo.org>
>    wrote:
> 
>      On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote:
>      >Â  Â  On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano
>      <[1][2]mpagano@gentoo.org>
>      >Â  Â  wrote:
>      >
>      >Â  Â  Â  This change will support moving the genpatches tarballs
>      from
>      >Â  Â  Â  /space/distfiles-local to
>      >Â  Â  Â  the devspace ~developer/public_html/dist/genpatches
>      >
>      >Â  Â  I think it would help if you discussed why we were making
>      this change.
>      >Â  Â  (I mean I can guess why, but it's not obvious.)
>      >Â  Â  -A
>      >Â  Â  Ä
>      I was informed that use of /space/distfiles-local is deprecated in
>      favor
>      of devspace.
>      [3]https://devmanual.gentoo.org/general-concepts/mirrors/index.html
> 
>    That policy was made in 2011; so clearly it's not super urgent nor
>    stringently applied. Which is to say, I'm not sure it needs to be a
>    policy.
>    -A
>    Â

Sounds like maybe a separate thread you can start to debate the policy.
I was called out by infra on IRC to do this, so I did it.

I have no horse in this race.




> 
>      >
>      >Â  Â  Â  Signed-off-by: Mike Pagano <[2][4]mpagano@gentoo.org>
>      >Â  Â  Â  ---
>      >Â  Â  Â  Ä eclass/kernel-2.eclass | 4 +++-
>      >Â  Â  Â  Ä 1 file changed, 3 insertions(+), 1 deletion(-)
>      >Â  Â  Â  diff --git a/eclass/kernel-2.eclass
>      b/eclass/kernel-2.eclass
>      >Â  Â  Â  index c5f35cd3e..0bc4f35de 100644
>      >Â  Â  Â  --- a/eclass/kernel-2.eclass
>      >Â  Â  Â  +++ b/eclass/kernel-2.eclass
>      >Â  Â  Â  @@ -295,7 +295,9 @@ handle_genpatches() {
>      >Â  Â  Â  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ
>      UNIPATCH_LIST_GENPATCHES+="
>      >Â  Â  Â  ${DISTDIR}/${tarball}"
>      >Â  Â  Â  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ
>      debug-print "genpatches tarball:
>      >Â  Â  Â  $tarball"
>      >Â  Â  Â  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  fi
>      >Â  Â  Â  -ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  Ä GENPATCHES_URI+="
>      >Â  Â  Â
>      ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
>      >Â  Â  Â  +ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  Ä GENPATCHES_URI+="
>      >Â  Â  Â
>      ${use_cond_start}[3][5]https://dev.gentoo.org/~mpagano/dist/genpatch
>      es/
>      >Â  Â  Â  ${tarball}${use_cond_end}
>      >Â  Â  Â  +ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  Ä
>      >Â  Â  Â  Ä
>      ${use_cond_start}[4][6]https://dev.gentoo.org/~whissi/dist/genpatche
>      s
>      >Â  Â  Â  /${tarball}${use_cond_end}
>      >Â  Â  Â  +ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  ÄÂ  Ä
>      >Â  Â  Â  Ä
>      ${use_cond_start}[5][7]https://dev.gentoo.org/~alicef/dist/genpatche
>      s
>      >Â  Â  Â  /${tarball}${use_cond_end}"
>      >Â  Â  Â  ÄÂ  ÄÂ  ÄÂ  ÄÂ  done
>      >Â  Â  Â  Ä }
>      >Â  Â  Â  --
>      >Â  Â  Â  2.21.0
>      >Â  Â  Â  --
>      >Â  Â  Â  Mike Pagano
>      >Â  Â  Â  Gentoo Developer - Kernel Project
>      >Â  Â  Â  Gentoo Sources - Member
>      >Â  Â  Â  E-MailÄÂ  ÄÂ  Ä : [6][8]mpagano@gentoo.org
>      >Â  Â  Â  GnuPG FPÄÂ  Ä : EEE2 601D 0763 B60F 848CÄÂ  9E14 3C33 C650
>      B576 E4E3
>      >Â  Â  Â  Public Key :
>      >Â  Â  Â
>      [7][9]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>      >
>      > References
>      >
>      >Â  Â  1. mailto:[10]mpagano@gentoo.org
>      >Â  Â  2. mailto:[11]mpagano@gentoo.org
>      >Â  Â  3.
>      [12]https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_
>      cond_end}
>      >Â  Â  4.
>      [13]https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_c
>      ond_end}
>      >Â  Â  5.
>      [14]https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_c
>      ond_end}
>      >Â  Â  6. mailto:[15]mpagano@gentoo.org
>      >Â  Â  7.
>      [16]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>      --
>      Mike Pagano
>      Gentoo Developer - Kernel Project
>      Gentoo Sources - Member
>      E-Mail     : [17]mpagano@gentoo.org
>      GnuPG FPÂ  Â : EEE2 601D 0763 B60F 848CÂ  9E14 3C33 C650 B576 E4E3
>      Public Key :
>      [18]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
> 
> References
> 
>    1. mailto:mpagano@gentoo.org
>    2. mailto:mpagano@gentoo.org
>    3. https://devmanual.gentoo.org/general-concepts/mirrors/index.html
>    4. mailto:mpagano@gentoo.org
>    5. https://dev.gentoo.org/~mpagano/dist/genpatches/
>    6. https://dev.gentoo.org/~whissi/dist/genpatches
>    7. https://dev.gentoo.org/~alicef/dist/genpatches
>    8. mailto:mpagano@gentoo.org
>    9. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>   10. mailto:mpagano@gentoo.org
>   11. mailto:mpagano@gentoo.org
>   12. https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end}
>   13. https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end}
>   14. https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}
>   15. mailto:mpagano@gentoo.org
>   16. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
>   17. mailto:mpagano@gentoo.org
>   18. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Ulrich Mueller]

>>>>> On Fri, 11 Oct 2019, Thomas Deutschmann wrote:

> Tilde expansion only happens when string to expand starts with "~" but
> this is not the case here (string starts with "https...").

I stand corrected.

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

[Mike]

On 10/9/19 7:14 PM, Mike Pagano wrote:
> This change will support moving the genpatches tarballs from /space/distfiles-local to
> the devspace ~developer/public_html/dist/genpatches.
> 
> Co-authored-by: Thomas Deutschmann <whissi@gentoo.org>
> 
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>   eclass/kernel-2.eclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> index c5f35cd3e..62e6c23e1 100644
> --- a/eclass/kernel-2.eclass
> +++ b/eclass/kernel-2.eclass
> @@ -295,7 +295,7 @@ handle_genpatches() {
>        UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
>        debug-print "genpatches tarball: $tarball"
>      fi
> -   GENPATCHES_URI+=" ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
> +   GENPATCHES_URI+=" ${use_cond_start}$(echo https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
>    done
>   }
> 


This one committed. Thanks for all the review feedback.

-- 
2.21.0

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail     : mpagano@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index