From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id CB720138334 for ; Thu, 13 Jun 2019 13:01:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B8A3EE09BA; Thu, 13 Jun 2019 13:01:22 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 54D4EE09AD for ; Thu, 13 Jun 2019 13:01:22 +0000 (UTC) Received: from [192.168.1.100] (c-98-218-46-55.hsd1.md.comcast.net [98.218.46.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mjo) by smtp.gentoo.org (Postfix) with ESMTPSA id 1FF33345FFB for ; Thu, 13 Jun 2019 13:01:21 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH v4 08/19] user.eclass: Factor out finding nologin into separate function To: gentoo-dev@lists.gentoo.org References: <20190611162347.2989-1-mgorny@gentoo.org> <20190611162347.2989-9-mgorny@gentoo.org> <312d136a-3f25-013a-0c2e-93a5aa0f659e@gentoo.org> From: Michael Orlitzky Message-ID: <6ae45adb-2e3a-df7e-b024-3a471ebd6eba@gentoo.org> Date: Thu, 13 Jun 2019 09:01:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Archives-Salt: 455a693e-3b1a-44dc-bfce-59777f4571c7 X-Archives-Hash: e9cb7b8646639239c30a496880b2bf87 On 6/13/19 1:33 AM, Michał Górny wrote: >> >>> + eshell=$(user_get_nologin) >> >> Then this would have to become >> >> eshell=$(userland_get_nologin "${USERLAND}") > > Do you have any real use for that? > No. It's a better design IMO since you can e.g. test the function by passing it an argument rather than by setting a global variable (which has other consequences). But no immediate application.