* [gentoo-dev] [PATCH] linux-info.eclass : Support valid Make files
@ 2021-09-02 19:42 Mike Pagano
2021-09-02 22:10 ` Sam James
0 siblings, 1 reply; 8+ messages in thread
From: Mike Pagano @ 2021-09-02 19:42 UTC (permalink / raw
To: gentoo-dev
Support the possibility that the Makefile could be
one of the following and should be checked in
the order described here:
https://www.gnu.org/software/make/manual/make.html
Order of checking and valid Makefiles names:
GNUMakefile, makefile, Makefile
Bug: https://bugs.gentoo.org/663368
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
eclass/linux-info.eclass | 33 +++++++++++++++++++++++++++++----
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
index 0b6df1bf5..2dfc8979f 100644
--- a/eclass/linux-info.eclass
+++ b/eclass/linux-info.eclass
@@ -80,6 +80,15 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
# There are also a couple of variables which are set by this, and shouldn't be
# set by hand. These are as follows:
+# @ECLASS-VARIABLE: KERNEL_MAKEFILE
+# @INTERNAL
+# @DESCRIPTION:
+# According to upstream documentation, by default, when make looks for the makefile, it tries
+# the following names, in order: GNUmakefile, makefile and Makefile. Set this variable to the
+# proper Makefile name or the eclass will search in this order for it.
+# See https://www.gnu.org/software/make/manual/make.html
+: ${KERNEL_MAKEFILE:=""}
+
# @ECLASS-VARIABLE: KV_FULL
# @OUTPUT_VARIABLE
# @DESCRIPTION:
@@ -510,7 +519,9 @@ get_version() {
qeinfo " ${KV_DIR}"
fi
- if [ ! -s "${KV_DIR}/Makefile" ]
+ get_makefile
+
+ if [ ! -s "${KERNEL_MAKEFILE}" ]
then
if [ -z "${get_version_warning_done}" ]; then
get_version_warning_done=1
@@ -526,9 +537,6 @@ get_version() {
# do we pass KBUILD_OUTPUT on the CLI?
local OUTPUT_DIR=${KBUILD_OUTPUT}
- # keep track of it
- KERNEL_MAKEFILE="${KV_DIR}/Makefile"
-
if [[ -z ${OUTPUT_DIR} ]]; then
# Decide the function used to extract makefile variables.
local mkfunc=$(get_makefile_extract_function "${KERNEL_MAKEFILE}")
@@ -971,3 +979,20 @@ linux-info_pkg_setup() {
[ -n "${CONFIG_CHECK}" ] && check_extra_config;
}
+
+# @FUNCTION: get_makefile
+# @DESCRIPTION:
+# Support the possibility that the Makefile could be one of the following and should
+# be checked in the order described here:
+# https://www.gnu.org/software/make/manual/make.html
+# Order of checking and valid Makefiles names: GNUMakefile, makefile, Makefile
+get_makefile() {
+
+ if [[ -s "${KV_DIR}"/GNUMakefile ]]; then
+ KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
+ elif [[ -s "${KV_DIR}"/makefile ]]; then
+ KERNEL_MAKEFILE="${KV_DIR}/makefile"
+ else
+ KERNEL_MAKEFILE="${KV_DIR}/Makefile"
+ fi
+}
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [gentoo-dev] [PATCH] linux-info.eclass : Support valid Make files
2021-09-02 19:42 [gentoo-dev] [PATCH] linux-info.eclass : Support valid Make files Mike Pagano
@ 2021-09-02 22:10 ` Sam James
2021-09-02 22:54 ` [gentoo-dev] [PATCH v2] " Mike
0 siblings, 1 reply; 8+ messages in thread
From: Sam James @ 2021-09-02 22:10 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]
> On 2 Sep 2021, at 20:42, Mike Pagano <mpagano@gentoo.org> wrote:
>
> Support the possibility that the Makefile could be
> one of the following and should be checked in
> the order described here:
>
> https://www.gnu.org/software/make/manual/make.html
>
> Order of checking and valid Makefiles names:
> GNUMakefile, makefile, Makefile
>
> Bug: https://bugs.gentoo.org/663368
>
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
> eclass/linux-info.eclass | 33 +++++++++++++++++++++++++++++----
> 1 file changed, 29 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
> index 0b6df1bf5..2dfc8979f 100644
> --- a/eclass/linux-info.eclass
> +++ b/eclass/linux-info.eclass
> @@ -80,6 +80,15 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
> # There are also a couple of variables which are set by this, and shouldn't be
> # set by hand. These are as follows:
> +# @ECLASS-VARIABLE: KERNEL_MAKEFILE
> +# @INTERNAL
> +# @DESCRIPTION:
> +# According to upstream documentation, by default, when make looks for the makefile, it tries
> +# the following names, in order: GNUmakefile, makefile and Makefile. Set this variable to the
> +# proper Makefile name or the eclass will search in this order for it.
> +# See https://www.gnu.org/software/make/manual/make.html
> +: ${KERNEL_MAKEFILE:=""}
Thanks for adding the reference! I'm often an advocate for adding _more_ links and explanation
because while it's sometimes a bit dull to add, it makes life a lot easier later on when researching.
> +
> # @ECLASS-VARIABLE: KV_FULL
> # @OUTPUT_VARIABLE
> # @DESCRIPTION:
> @@ -510,7 +519,9 @@ get_version() {
> qeinfo " ${KV_DIR}"
> fi
> - if [ ! -s "${KV_DIR}/Makefile" ]
> + get_makefile
> +
> + if [ ! -s "${KERNEL_MAKEFILE}" ]
> then
Can you use Bash tests instead?
(https://devmanual.gentoo.org/tools-reference/bash/#single-versus-double-brackets-in-bash)
Best,
sam
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [gentoo-dev] [PATCH v2] linux-info.eclass : Support valid Make files
2021-09-02 22:10 ` Sam James
@ 2021-09-02 22:54 ` Mike
2021-09-02 23:28 ` [gentoo-dev] [PATCH v3] " Mike
0 siblings, 1 reply; 8+ messages in thread
From: Mike @ 2021-09-02 22:54 UTC (permalink / raw
To: gentoo-dev
Support the possibility that the Makefile could be
one of the following and should be checked in the order described here:
https://www.gnu.org/software/make/manual/make.html
Order of checking and valid Makefiles names:
GNUMakefile, makefile, Makefile
Bug: https://bugs.gentoo.org/663368
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
eclass/linux-info.eclass | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
index 0b6df1bf5..7e225236f 100644
--- a/eclass/linux-info.eclass
+++ b/eclass/linux-info.eclass
@@ -80,6 +80,15 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
# There are also a couple of variables which are set by this, and shouldn't be
# set by hand. These are as follows:
+# @ECLASS-VARIABLE: KERNEL_MAKEFILE
+# @INTERNAL
+# @DESCRIPTION:
+# According to upstream documentation, by default, when make looks for the makefile, it tries
+# the following names, in order: GNUmakefile, makefile and Makefile. Set this variable to the
+# proper Makefile name or the eclass will search in this order for it.
+# See https://www.gnu.org/software/make/manual/make.html
+: ${KERNEL_MAKEFILE:=""}
+
# @ECLASS-VARIABLE: KV_FULL
# @OUTPUT_VARIABLE
# @DESCRIPTION:
@@ -510,7 +519,9 @@ get_version() {
qeinfo " ${KV_DIR}"
fi
- if [ ! -s "${KV_DIR}/Makefile" ]
+ get_makefile
+
+ if [ ! -s "${KERNEL_MAKEFILE}" ]
then
if [ -z "${get_version_warning_done}" ]; then
get_version_warning_done=1
@@ -526,9 +537,6 @@ get_version() {
# do we pass KBUILD_OUTPUT on the CLI?
local OUTPUT_DIR=${KBUILD_OUTPUT}
- # keep track of it
- KERNEL_MAKEFILE="${KV_DIR}/Makefile"
-
if [[ -z ${OUTPUT_DIR} ]]; then
# Decide the function used to extract makefile variables.
local mkfunc=$(get_makefile_extract_function "${KERNEL_MAKEFILE}")
@@ -971,3 +979,17 @@ linux-info_pkg_setup() {
[ -n "${CONFIG_CHECK}" ] && check_extra_config;
}
+
+# @FUNCTION: get_makefile
+# @DESCRIPTION:
+# Support the possibility that the Makefile could be one of the following and should
+# be checked in the order described here:
+# https://www.gnu.org/software/make/manual/make.html
+# Order of checking and valid Makefiles names: GNUMakefile, makefile, Makefile
+get_makefile() {
+
+ [[ -s "${KV_DIR}"/GNUMakefile ]] && KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
+ [[ -s "${KV_DIR}"/makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/makefile"
+ [[ -s "${KV_DIR}"/Makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/Makefile"
+
+}
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [gentoo-dev] [PATCH v3] linux-info.eclass : Support valid Make files
2021-09-02 22:54 ` [gentoo-dev] [PATCH v2] " Mike
@ 2021-09-02 23:28 ` Mike
2021-09-03 7:00 ` Michał Górny
2021-09-03 9:06 ` Ulrich Mueller
0 siblings, 2 replies; 8+ messages in thread
From: Mike @ 2021-09-02 23:28 UTC (permalink / raw
To: gentoo-dev
Support the possibility that the Makefile could be
one of the following and should be checked in the order described here:
https://www.gnu.org/software/make/manual/make.html
Order of checking and valid Makefiles names:
GNUMakefile, makefile, Makefile
Bug: https://bugs.gentoo.org/663368
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
eclass/linux-info.eclass | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
index 0b6df1bf5..a6159eac2 100644
--- a/eclass/linux-info.eclass
+++ b/eclass/linux-info.eclass
@@ -80,6 +80,15 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
# There are also a couple of variables which are set by this, and shouldn't be
# set by hand. These are as follows:
+# @ECLASS-VARIABLE: KERNEL_MAKEFILE
+# @INTERNAL
+# @DESCRIPTION:
+# According to upstream documentation, by default, when make looks for the makefile, it tries
+# the following names, in order: GNUmakefile, makefile and Makefile. Set this variable to the
+# proper Makefile name or the eclass will search in this order for it.
+# See https://www.gnu.org/software/make/manual/make.html
+: ${KERNEL_MAKEFILE:=""}
+
# @ECLASS-VARIABLE: KV_FULL
# @OUTPUT_VARIABLE
# @DESCRIPTION:
@@ -510,7 +519,9 @@ get_version() {
qeinfo " ${KV_DIR}"
fi
- if [ ! -s "${KV_DIR}/Makefile" ]
+ get_makefile
+
+ if [[ ! -s "${KERNEL_MAKEFILE}" ]]
then
if [ -z "${get_version_warning_done}" ]; then
get_version_warning_done=1
@@ -526,9 +537,6 @@ get_version() {
# do we pass KBUILD_OUTPUT on the CLI?
local OUTPUT_DIR=${KBUILD_OUTPUT}
- # keep track of it
- KERNEL_MAKEFILE="${KV_DIR}/Makefile"
-
if [[ -z ${OUTPUT_DIR} ]]; then
# Decide the function used to extract makefile variables.
local mkfunc=$(get_makefile_extract_function "${KERNEL_MAKEFILE}")
@@ -971,3 +979,17 @@ linux-info_pkg_setup() {
[ -n "${CONFIG_CHECK}" ] && check_extra_config;
}
+
+# @FUNCTION: get_makefile
+# @DESCRIPTION:
+# Support the possibility that the Makefile could be one of the following and should
+# be checked in the order described here:
+# https://www.gnu.org/software/make/manual/make.html
+# Order of checking and valid Makefiles names: GNUMakefile, makefile, Makefile
+get_makefile() {
+
+ [[ -s "${KV_DIR}"/GNUMakefile ]] && KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
+ [[ -s "${KV_DIR}"/makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/makefile"
+ [[ -s "${KV_DIR}"/Makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/Makefile"
+
+}
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [gentoo-dev] [PATCH v3] linux-info.eclass : Support valid Make files
2021-09-02 23:28 ` [gentoo-dev] [PATCH v3] " Mike
@ 2021-09-03 7:00 ` Michał Górny
2021-09-03 9:06 ` Ulrich Mueller
1 sibling, 0 replies; 8+ messages in thread
From: Michał Górny @ 2021-09-03 7:00 UTC (permalink / raw
To: gentoo-dev
On Thu, 2021-09-02 at 19:28 -0400, Mike wrote:
> Support the possibility that the Makefile could be
> one of the following and should be checked in the order described here:
>
> https://www.gnu.org/software/make/manual/make.html
>
> Order of checking and valid Makefiles names:
> GNUMakefile, makefile, Makefile
>
> Bug: https://bugs.gentoo.org/663368
>
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
> eclass/linux-info.eclass | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
> index 0b6df1bf5..a6159eac2 100644
> --- a/eclass/linux-info.eclass
> +++ b/eclass/linux-info.eclass
> @@ -80,6 +80,15 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
> # There are also a couple of variables which are set by this, and shouldn't be
> # set by hand. These are as follows:
>
> +# @ECLASS-VARIABLE: KERNEL_MAKEFILE
> +# @INTERNAL
> +# @DESCRIPTION:
> +# According to upstream documentation, by default, when make looks for the makefile, it tries
> +# the following names, in order: GNUmakefile, makefile and Makefile. Set this variable to the
> +# proper Makefile name or the eclass will search in this order for it.
> +# See https://www.gnu.org/software/make/manual/make.html
> +: ${KERNEL_MAKEFILE:=""}
> +
> # @ECLASS-VARIABLE: KV_FULL
> # @OUTPUT_VARIABLE
> # @DESCRIPTION:
> @@ -510,7 +519,9 @@ get_version() {
> qeinfo " ${KV_DIR}"
> fi
>
> - if [ ! -s "${KV_DIR}/Makefile" ]
> + get_makefile
> +
> + if [[ ! -s "${KERNEL_MAKEFILE}" ]]
> then
> if [ -z "${get_version_warning_done}" ]; then
> get_version_warning_done=1
> @@ -526,9 +537,6 @@ get_version() {
> # do we pass KBUILD_OUTPUT on the CLI?
> local OUTPUT_DIR=${KBUILD_OUTPUT}
>
> - # keep track of it
> - KERNEL_MAKEFILE="${KV_DIR}/Makefile"
> -
> if [[ -z ${OUTPUT_DIR} ]]; then
> # Decide the function used to extract makefile variables.
> local mkfunc=$(get_makefile_extract_function "${KERNEL_MAKEFILE}")
> @@ -971,3 +979,17 @@ linux-info_pkg_setup() {
>
> [ -n "${CONFIG_CHECK}" ] && check_extra_config;
> }
> +
> +# @FUNCTION: get_makefile
Please prefix it so it doesn't pollute the global namespace.
> +# @DESCRIPTION:
> +# Support the possibility that the Makefile could be one of the following and should
> +# be checked in the order described here:
> +# https://www.gnu.org/software/make/manual/make.html
> +# Order of checking and valid Makefiles names: GNUMakefile, makefile, Makefile
> +get_makefile() {
> +
> + [[ -s "${KV_DIR}"/GNUMakefile ]] && KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
> + [[ -s "${KV_DIR}"/makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/makefile"
> + [[ -s "${KV_DIR}"/Makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/Makefile"
> +
> +}
--
Best regards,
Michał Górny
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [gentoo-dev] [PATCH v3] linux-info.eclass : Support valid Make files
2021-09-02 23:28 ` [gentoo-dev] [PATCH v3] " Mike
2021-09-03 7:00 ` Michał Górny
@ 2021-09-03 9:06 ` Ulrich Mueller
2021-09-03 14:25 ` [gentoo-dev] [PATCH v4] " Mike Pagano
1 sibling, 1 reply; 8+ messages in thread
From: Ulrich Mueller @ 2021-09-03 9:06 UTC (permalink / raw
To: Mike; +Cc: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
>>>>> On Fri, 03 Sep 2021, Mike wrote:
> - if [ ! -s "${KV_DIR}/Makefile" ]
> + get_makefile
> +
> + if [[ ! -s "${KERNEL_MAKEFILE}" ]]
<nitpick>
No quotation marks needed in [[ ]].
</nitpick
> + [[ -s "${KV_DIR}"/GNUMakefile ]] && KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
> + [[ -s "${KV_DIR}"/makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/makefile"
> + [[ -s "${KV_DIR}"/Makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/Makefile"
Ditto.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [gentoo-dev] [PATCH v4] linux-info.eclass : Support valid Make files
2021-09-03 9:06 ` Ulrich Mueller
@ 2021-09-03 14:25 ` Mike Pagano
2021-09-04 17:47 ` Mike Pagano
0 siblings, 1 reply; 8+ messages in thread
From: Mike Pagano @ 2021-09-03 14:25 UTC (permalink / raw
To: gentoo-dev
Thanks to Sam, mgorny and Ulm for the review.
Incorporated all requested changes
Support the possibility that the Makefile could be
one of the following and should be checked in
the order described here:
https://www.gnu.org/software/make/manual/make.html
Order of checking and valid Makefiles names:
GNUMakefile, makefile, Makefile
Bug: https://bugs.gentoo.org/663368
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
eclass/linux-info.eclass | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
index 0b6df1bf5..1379b6008 100644
--- a/eclass/linux-info.eclass
+++ b/eclass/linux-info.eclass
@@ -80,6 +80,15 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
# There are also a couple of variables which are set by this, and shouldn't be
# set by hand. These are as follows:
+# @ECLASS-VARIABLE: KERNEL_MAKEFILE
+# @INTERNAL
+# @DESCRIPTION:
+# According to upstream documentation, by default, when make looks for the makefile, it tries
+# the following names, in order: GNUmakefile, makefile and Makefile. Set this variable to the
+# proper Makefile name or the eclass will search in this order for it.
+# See https://www.gnu.org/software/make/manual/make.html
+: ${KERNEL_MAKEFILE:=""}
+
# @ECLASS-VARIABLE: KV_FULL
# @OUTPUT_VARIABLE
# @DESCRIPTION:
@@ -510,7 +519,9 @@ get_version() {
qeinfo " ${KV_DIR}"
fi
- if [ ! -s "${KV_DIR}/Makefile" ]
+ kernel_get_makefile
+
+ if [[ ! -s ${KERNEL_MAKEFILE} ]]
then
if [ -z "${get_version_warning_done}" ]; then
get_version_warning_done=1
@@ -526,9 +537,6 @@ get_version() {
# do we pass KBUILD_OUTPUT on the CLI?
local OUTPUT_DIR=${KBUILD_OUTPUT}
- # keep track of it
- KERNEL_MAKEFILE="${KV_DIR}/Makefile"
-
if [[ -z ${OUTPUT_DIR} ]]; then
# Decide the function used to extract makefile variables.
local mkfunc=$(get_makefile_extract_function "${KERNEL_MAKEFILE}")
@@ -971,3 +979,17 @@ linux-info_pkg_setup() {
[ -n "${CONFIG_CHECK}" ] && check_extra_config;
}
+
+# @FUNCTION: kernel_get_makefile
+# @DESCRIPTION:
+# Support the possibility that the Makefile could be one of the following and should
+# be checked in the order described here:
+# https://www.gnu.org/software/make/manual/make.html
+# Order of checking and valid Makefiles names: GNUMakefile, makefile, Makefile
+kernel_get_makefile() {
+
+ [[ -s ${KV_DIR}/GNUMakefile ]] && KERNEL_MAKEFILE="${KV_DIR}/GNUMakefile"
+ [[ -s ${KV_DIR}/makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/makefile"
+ [[ -s ${KV_DIR}/Makefile ]] && KERNEL_MAKEFILE="${KV_DIR}/Makefile"
+
+}
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [gentoo-dev] [PATCH v4] linux-info.eclass : Support valid Make files
2021-09-03 14:25 ` [gentoo-dev] [PATCH v4] " Mike Pagano
@ 2021-09-04 17:47 ` Mike Pagano
0 siblings, 0 replies; 8+ messages in thread
From: Mike Pagano @ 2021-09-04 17:47 UTC (permalink / raw
To: gentoo-dev
On 9/3/21 10:25 AM, Mike Pagano wrote:
> Thanks to Sam, mgorny and Ulm for the review.
>
Committed
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-04 17:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-02 19:42 [gentoo-dev] [PATCH] linux-info.eclass : Support valid Make files Mike Pagano
2021-09-02 22:10 ` Sam James
2021-09-02 22:54 ` [gentoo-dev] [PATCH v2] " Mike
2021-09-02 23:28 ` [gentoo-dev] [PATCH v3] " Mike
2021-09-03 7:00 ` Michał Górny
2021-09-03 9:06 ` Ulrich Mueller
2021-09-03 14:25 ` [gentoo-dev] [PATCH v4] " Mike Pagano
2021-09-04 17:47 ` Mike Pagano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox