From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D723E13832E for ; Sun, 21 Aug 2016 00:23:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B3814E0B31; Sun, 21 Aug 2016 00:23:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A020DE0B2A for ; Sun, 21 Aug 2016 00:22:59 +0000 (UTC) Received: from [192.168.1.2] (c-73-53-75-119.hsd1.wa.comcast.net [73.53.75.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zlg) by smtp.gentoo.org (Postfix) with ESMTPSA id A4BE133F9D2 for ; Sun, 21 Aug 2016 00:22:58 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH] kernel-2.eclass: introduce K_FROM_GIT for sources that derive from git repos To: gentoo-dev@lists.gentoo.org References: <40b687e0-4d53-9a84-aa05-dc34f72049a3@gentoo.org> From: Daniel Campbell Message-ID: <699594ea-6bf0-b83b-9d5f-7902407d0d08@gentoo.org> Date: Sat, 20 Aug 2016 17:22:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <40b687e0-4d53-9a84-aa05-dc34f72049a3@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u4IfACroILjF88P5vKBhOw3lM3jbNMuqR" X-Archives-Salt: 3cbeadff-755f-4f11-8ae5-e5473ba9f133 X-Archives-Hash: 525565c53aadfacc9a478fb2e44183f1 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u4IfACroILjF88P5vKBhOw3lM3jbNMuqR Content-Type: multipart/mixed; boundary="jDA2bpcLXajtUG9K6TC9XwvovSHrj6Qns" From: Daniel Campbell To: gentoo-dev@lists.gentoo.org Message-ID: <699594ea-6bf0-b83b-9d5f-7902407d0d08@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] kernel-2.eclass: introduce K_FROM_GIT for sources that derive from git repos References: <40b687e0-4d53-9a84-aa05-dc34f72049a3@gentoo.org> In-Reply-To: <40b687e0-4d53-9a84-aa05-dc34f72049a3@gentoo.org> --jDA2bpcLXajtUG9K6TC9XwvovSHrj6Qns Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/20/2016 05:13 AM, Joshua Kinard wrote: > All, >=20 > It looks like that sometime around Linux 3.15, some kind of a quirk was= > introduced where a patch that contains the removal of a symlink followe= d by the > addition of a file with the same name as the symlink causes patch's --d= ry-run > phase to fail, which kills 'epatch'. See Bug #507656. >=20 > A workaround was added to kernel-2.eclass, around line 1093, that hardc= odes a > check for sys-kernel/git-sources, to avoid this issue. Well, > sys-kernel/mips-sources is also affected by the same issue. I'm close = to > releasing a newer mips-sources, having spent the last few months > re-writing/refactoring chunks of old SGI IP27/BRIDGE code, and rather t= han add > another hardcode to kernel-2, I instead created a new variable, K_FROM_= GIT, > that will replace the hardcode. >=20 > When set to a value, it triggers the workaround, which still affects cu= rrent > kernels. This results in a cleaner implementation instead of a hardcod= ed > ebuild, should future kernel packages sourced from a git repo get added= =2E >=20 > Patch is attached for review. >=20 > Thanks! >=20 lgtm, but I'm curious over the targeting of -rc releases. Are the only releases after 15 in the 3.x series -rc? If not, you're going to run into problems where a kernel is >=3D3.15 but not an rc. Otherwise it seems better than hardcoding it imo. --=20 Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 --jDA2bpcLXajtUG9K6TC9XwvovSHrj6Qns-- --u4IfACroILjF88P5vKBhOw3lM3jbNMuqR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXuPRgAAoJEAEkDpRQOeFwoR0QAIYD8m3roURX75KMAILolr1V jevvX8hY1H4jEp3O0OrTkofu4CXoOZkJcFyKE4Fd7BydR2tuFNA5mBSrdSWypMTj 2epBsGEca4RfUqX1JlPoCDCShWudEEX6gdPa/iqcCaSo9LFawJvtlSJ3NGdz6ct0 g4pZx5d5kRmHNEpNbaPw4QrqUNO92Sj7rt8CkLM9qcrXltS5oviwG1eJ23xRFaz6 P3GWCWhjLiICm9CBSbaEdz5SN9gmBfU10j8+jUTa10pKi3nOYpTggIMdFWh1AUG/ e1hUi3Oe1OayarnQGLcrBvbsIIrosUJ2g99f2JdamEh9M6ksnkf5Ax39FMdu0VEu yKKCIIEaUA+0wh18LTi+GRCJ2Q6PHooGSWAvCmAOmXPNvQAjU5ziL7c2akKu9QiB ETkxqTIDQ/Nu/49VmNAZuKK4PtfMcMlbhWwxKJo3CO7uucJSSNEKCveNwLa4RibQ zw2UK+vjsXPogkppSIz4y+K4d2gSwqbzc8LEUo1WRZuFDZauCWjQPLkms+G5K+SZ sUrpBrpXVyxUWW7uj2t7RT32MJzPBa326BKegd/cVADp+46jri9vjsjvSfyW40qs ac3j4t/SAQwzYsBW5S3497gXfyE6885SXN4lkFFRv1nPY/D6Trj8MM39qVas+PVL LTkhkS/5NMP10x4R3Zga =+zLs -----END PGP SIGNATURE----- --u4IfACroILjF88P5vKBhOw3lM3jbNMuqR--