From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CB44513825A for ; Sun, 15 May 2016 23:07:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 37CF814232; Sun, 15 May 2016 23:07:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0A35321C043 for ; Sun, 15 May 2016 23:07:37 +0000 (UTC) Received: from [192.168.1.2] (c-73-53-75-119.hsd1.wa.comcast.net [73.53.75.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zlg) by smtp.gentoo.org (Postfix) with ESMTPSA id 55E423408B8 for ; Sun, 15 May 2016 23:07:36 +0000 (UTC) Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ To: gentoo-dev@lists.gentoo.org References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> <20160515035327.37fcb81c@tundra.gateway.pace.com> <0c9bfc1f-eae9-b193-62ac-f10995efffff@gentoo.org> From: Daniel Campbell Message-ID: <667c681d-9c00-dd8c-8432-fc4a41f32b95@gentoo.org> Date: Sun, 15 May 2016 16:07:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OGXqICct3rFC0KdGLepjfAEv7wH9O3Aid" X-Archives-Salt: e88428d8-b232-4a24-b779-2e1ee4bac877 X-Archives-Hash: abc27f5555c25dc753f2733e3a1f759f This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OGXqICct3rFC0KdGLepjfAEv7wH9O3Aid Content-Type: multipart/mixed; boundary="IIJATpMoftv99NI1Fs1XXN3Quj8QgpobK" From: Daniel Campbell To: gentoo-dev@lists.gentoo.org Message-ID: <667c681d-9c00-dd8c-8432-fc4a41f32b95@gentoo.org> Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> <20160515035327.37fcb81c@tundra.gateway.pace.com> <0c9bfc1f-eae9-b193-62ac-f10995efffff@gentoo.org> In-Reply-To: --IIJATpMoftv99NI1Fs1XXN3Quj8QgpobK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/15/2016 03:55 PM, Duncan wrote: > Daniel Campbell posted on Sun, 15 May 2016 04:04:57 -0700 as excerpted:= >=20 >> If the dev in question hasn't done that before, then it's entirely >> possible they *thought* they tested, or tested it *before* making some= >> other edit and absent-mindedly committed. >=20 > Again, legacy CVS thought pattern. In git, commit !=3D push, and it's = the=20 > push that's critical. >=20 > Commit all you want without testing. Just test (and fix if necessary) = > before you push those commits up to the gentoo master repo. =3D:^) >=20 > (Of course, rebasing to fold the broken commit and its fix into one=20 > before pushing doesn't hurt, either.) >=20 Sorry. I've actually been using git for years, but since I got started with Gentoo on CVS and I try to be careful with my commits to the gentoo repo, I conflated them. You're right, the push is what matters the most. --=20 Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 --IIJATpMoftv99NI1Fs1XXN3Quj8QgpobK-- --OGXqICct3rFC0KdGLepjfAEv7wH9O3Aid Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXOQExAAoJEAEkDpRQOeFwP48QAMwTOLgTvyBL0YgJ1p2MEAbm E815xZ0TfwlIuvURjw/7MPWs3H7tfvB4VyRXbcb3pcpbPpxXTSdmuVv/ShuwdsgS dq4d5n/4gJKPJyMDEuU5gWLtZ7ISfOBS62qMWgRT4Sm2gA1PBV0/0NsgRI5mMHW1 gYDTpbjn7SNCCPQ2PEtA1yUSIC2j3ZG5XzKZuvnsXxA5Ql8X/F8+izF9aM5axx1v SJ4ZLxogVHY3mLvMUClCGRG12gi6yudBe1GXOrKNrydS2wCphhDabo+eJUuA1kfb xo2+KSodAcsBa5cBJFeaI+KJsmqQmYCWCb1vnSdwhf4siz4FdHJkjdSaQ5nTLVTS kBa3d2KuCcGGd/5eBuX7gZwvHa6OfkfLL8iDaBd4p+R7zKIfpIspXZPzA9Cs9b/9 WrNslyGCG5BafS8eBY0D3eZWIeyspstUU3Q39jqTp/VdDTfxt6kFDhuyKFovhfaB YkXet15Ji72XjSfqBnleX6K0+1n4jyFX/WceEE+s6ciWo9+h/P5pHd66Nrpb4Xlj 1pgV3mu/NBQ3bi/xTaL1aFx5DW0YbX2/+3z5RXDq9I6Ak2WyjGSeK8QiXclX6iNZ 1YJum4tWYQVKLMRvNONgF6Jtgig2B1DaU0X4UzQNL6GBD2KvsVrV3cOa3TQOwaMm Trs6b9CyJzISlt5A45ht =yCS5 -----END PGP SIGNATURE----- --OGXqICct3rFC0KdGLepjfAEv7wH9O3Aid--