[gentoo-dev] unprefixed eqawarn

[gentoo-dev] unprefixed eqawarn

[Agostino Sarubbo]

[-- Attachment #1.1: Type: text/plain, Size: 2070 bytes --]

Hello all,

the truth is that I should have separated this email into two threads. However they have a 
relation, so let's discuss them in one place.


The first:

While is not mandatory begin an eqawarn with "QA Notice" and thus there are no rules 
about that I think it helps while grepping on build logs.
All of us agree that is should be fixed in the eqawarn function, but it won't happen soon.
So, if you are interested to get bug reports (at least from me) about unprefixed eqawarn, 
please add the usual "QA Notice:" prefix as we did in https://bugs.gentoo.org/728046[1]
If you think that add "QA Notice:" will break existing scripts or so, please let us know.

I'm adding as attachment the list of eqawarn that miss the 'QA Notice' prefix.


The second:

By filing bugs for eqawarn/qa notice, I have been pointed out, for some class of issues, 
that a bugreport is not needed.

At this point, since bugs can be filed by everyone, I think is better introduce something 
that make clear that we do not expect a bugreport about a particular issue.

An example is here:

eqawarn "QA (Dev) Notice: ........"
eqawarn "......"
eqawarn "......"
eqawarn "Please remember that QA (Dev) Notice do not deserve a bugreport"

In other words a "QA (Dev) Notice:" is supposed to be one or more of the following:
- something useful for maintainer at the bump time
- something that is not worth for a bugreport
- something that is not worth for an immediate fix
- something that will disappear soon with a new version of a package


Two side notes:
1)
I have tried to introduce that on irc in #gentoo-qa to get a feedback about that, but I have 
not received a response, so this should be the proper place.
So this is NOT to point the finger to people that did not answer, but it's just to say that I'm 
not expecting something like: "why you didn't discuss this with us first" from qa ;)


2)
@ionen already pointed out to me that configure.in qa notice in autotools.eclass no dot 
deserve a qa notice.


What do you think?

Agostino

--------
[1] https://bugs.gentoo.org/728046

[-- Attachment #1.2: Type: text/html, Size: 4501 bytes --]

[-- Attachment #2: eqawarn.txt --]
[-- Type: text/plain, Size: 2511 bytes --]

autotools.eclass:
eqawarn "This package has a configure.in file which has long been deprecated.  Please"
eqawarn "Running '${1}' in ${EBUILD_PHASE_FUNC} phase"

chromium-2.eclass:
eqawarn "L10N warning: no .pak file for ${lang} (${lang}.pak not found)"
eqawarn "L10N warning: no ${lang} in LANGS"

distutils-r1.eclass:
eqawarn "Non-PEP517 builds are deprecated for ebuilds using plain distutils."
eqawarn "${build_backend} backend is deprecated.  Please see:"
eqawarn "Python extension modules (*$(get_modname)) found installed. Please set:"

ecm.eclass:
eqawarn "Build system was modified by ECM_TEST=forceoptional-recursive."

flag-o-matic.eclass:
eqawarn "Appending an empty argument to LIBS is invalid! Skipping."
eqawarn "Appending non-library to LIBS (${flag}); Other linker flags should be passed via LDFLAGS"

go-module.eclass:
eqawarn "This ebuild uses EGO_SUM which is deprecated"

gstreamer-meson.eclass:
eqawarn "QA: IUSE=orc is missing while plugin supports it"
eqawarn "QA: IUSE=orc is present while plugin does not support it"
eqawarn "QA: IUSE=introspection is missing while plugin supports it"
eqawarn "QA: IUSE=introspection is present while plugin does not support it"

haskell-cabal.eclass:
eqawarn "No Setup.lhs or Setup.hs found. Either add Setup.hs to package or call cabal-mksetup from ebuild"

java-pkg-simple.eclass:
eqawarn "Need at least JDK 9 to compile module-info.java in src_compile."

java-utils-2.eclass:
eqawarn "java-pkg_ensure-dep: ${dev_error}"
eqawarn "java-pkg_ensure-dep: ${dev_error}"

python-r1.eclass:
eqawarn "python_foreach_impl has been called directly while using distutils-r1."

python-utils-r1.eclass:
eqawarn "The directory ${fn} occludes package installed for ${EPYTHON}."
eqawarn "    ${l}"
eqawarn "For more information on occluded packages, please see:"

rpm.eclass:
eqawarn 'do not use ${DISTDIR} with rpm_unpack -- it is added for you'
eqawarn 'do not use full paths with rpm_unpack -- use ./ paths instead'

ruby-fakegem.eclass:
eqawarn "${CATEGORY}/${PF}: Unknown test recipe '${RUBY_FAKEGEM_RECIPE_TEST}' specified, using 'none'"
eqawarn "Generating generic fallback gemspec *without* dependencies"

ruby-ng.eclass:
eqawarn "RUBY_PATCHES is no longer supported, use PATCHES instead"
eqawarn "Missing test dependency dev-ruby/rspec"

toolchain.eclass:
eqawarn "Snapshot release with pre-generated info pages found!"

wxwidgets.eclass:
eqawarn "This package relies on the deprecated GTK 2 slot, which will go away soon (https://bugs.gentoo.org/618642)"