From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-99851-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 27E9C158008
	for <garchives@archives.gentoo.org>; Thu, 15 Jun 2023 10:03:09 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 18665E096C;
	Thu, 15 Jun 2023 10:03:06 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id CE13BE0961
	for <gentoo-dev@lists.gentoo.org>; Thu, 15 Jun 2023 10:03:05 +0000 (UTC)
Message-ID: <60a77251-2390-ba0c-abde-1f78f65a5602@gentoo.org>
Date: Thu, 15 Jun 2023 12:03:02 +0200
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [gentoo-dev] [PATCH 2/2] kernel-build.eclass: add
 USE="modules-sign"
Content-Language: en-US, nl-NL
To: gentoo-dev@lists.gentoo.org
References: <d0a2ef46-14b5-29dc-8c52-9fa6fedb86ed@gentoo.org>
 <a0be0bc7-b5f9-cd6f-5e9c-66a75a510c6a@gentoo.org>
From: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Organization: Gentoo Linux
In-Reply-To: <a0be0bc7-b5f9-cd6f-5e9c-66a75a510c6a@gentoo.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Archives-Salt: ef502655-b1e4-473a-b6d2-ef951267f6d3
X-Archives-Hash: 7f998ace3952790b464b1c536cf059c7

On 15/06/2023 11:59, Florian Schmaus wrote:
> On 15.06.23 11:50, Andrew Ammerlaan wrote:
>> +pkg_postinst() {
>> +    kernel-build_pkg_postinst
>> +    if use modules-sign; then
>> +        if [[ -z "${MODULES_SIGN_KEY}" ]]; then
>> +            ewarn ""
> 
> You can drop the empty string argument and simply just write ewarn.

Thanks,

> And I am not sure if we really need a leading empty ewarn line, but this 
> appears to be a common idiom.

IMO It looks a bit better because kernel-build_pkg_postinst will also 
print some elog messages. The empty line makes it clearer that this is a 
separate message.

Best regards,
Andrew