Re: [gentoo-dev] [PATCH 2/2] kernel-build.eclass: add USE="modules-sign"

[Andrew Ammerlaan <andrewammerlaan@gentoo.org>]

On 15/06/2023 11:59, Florian Schmaus wrote:
> On 15.06.23 11:50, Andrew Ammerlaan wrote:
>> +pkg_postinst() {
>> +    kernel-build_pkg_postinst
>> +    if use modules-sign; then
>> +        if [[ -z "${MODULES_SIGN_KEY}" ]]; then
>> +            ewarn ""
> 
> You can drop the empty string argument and simply just write ewarn.

Thanks,

> And I am not sure if we really need a leading empty ewarn line, but this 
> appears to be a common idiom.

IMO It looks a bit better because kernel-build_pkg_postinst will also 
print some elog messages. The empty line makes it clearer that this is a 
separate message.

Best regards,
Andrew