From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3DAE0139085 for ; Fri, 27 Jan 2017 12:09:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2B79EE0DB7; Fri, 27 Jan 2017 12:08:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C9298E0D84 for ; Fri, 27 Jan 2017 12:08:48 +0000 (UTC) Received: from [10.100.0.6] (host-37-191-238-78.lynet.no [37.191.238.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: k_f) by smtp.gentoo.org (Postfix) with ESMTPSA id C2F8D341645 for ; Fri, 27 Jan 2017 12:08:47 +0000 (UTC) Subject: Re: [gentoo-dev] berkdb and gdbm in global USE defaults References: <1485503640.22895.2.camel@gentoo.org> <20170127083223.GK42019@gentoo.org> To: gentoo-dev@lists.gentoo.org From: Kristian Fiskerstrand Message-ID: <5fa433b9-5057-b8e4-64f9-27ef2c67c400@gentoo.org> Date: Fri, 27 Jan 2017 13:08:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rfVWW6NjoCMrILj1dK4MLEbHJG8TgGlwe" X-Archives-Salt: 24210ad8-bce1-4a56-a9af-f3ec70c4ffaa X-Archives-Hash: 7a42e7f3b38fa05abbe5010beb6666e7 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rfVWW6NjoCMrILj1dK4MLEbHJG8TgGlwe Content-Type: multipart/mixed; boundary="WuDaA1jvNWkDvI3REN8wlotBa3Mlj616t" From: Kristian Fiskerstrand Reply-To: k_f@gentoo.org To: gentoo-dev@lists.gentoo.org Message-ID: <5fa433b9-5057-b8e4-64f9-27ef2c67c400@gentoo.org> Subject: Re: [gentoo-dev] berkdb and gdbm in global USE defaults References: <1485503640.22895.2.camel@gentoo.org> <20170127083223.GK42019@gentoo.org> In-Reply-To: --WuDaA1jvNWkDvI3REN8wlotBa3Mlj616t Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2017 01:01 PM, Dirkjan Ochtman wrote: > On Fri, Jan 27, 2017 at 8:54 AM, Mart Raudsepp wrote:= >> =C3=9Chel kenal p=C3=A4eval, N, 26.01.2017 kell 22:33, kirjutas Mike G= ilbert: >>> I recently ran into a REQUIRED_USE constraint that required I select >>> between berkdb and gdbm for an email client. >> There shouldn't be a REQUIRED_USE constraint that forces you to select= >> one or the other. The maintainer should be giving the choice of both, >> but if only one can be chosen, the maintainer should make the choice >> for you by preferring one of them. Likely gdbm, given berkdb licensing= >> saga. > I'm not sure this makes sense to me. If the package will actually > select one implementation out of a set, it makes sense to me that the > maintainer for that package makes that choice explicit towards the > user. In that case, setting REQUIRED_USE accordingly seems exactly > right. The maintainer should set a good default, but if the user's USE > settings are inconclusive in getting to the choice of implementation, > it's better to whine explicitly than try to guess implicitly what the > user wanted. I tend to agree with this sentiment, explicit over implicit behavior ensures better debugging ability and security considerations. >=20 > On Fri, Jan 27, 2017 at 9:32 AM, Fabian Groffen wr= ote: >> Replying here because I think said email client is the one I recently >> added REQUIRED_USE constraints for. >> >> Reason I added it is because it greatly simplified the ebuild: it's no= t >> just bdb and gdbm, but also tokyocabinet, qdbm and lmdb, with as resul= t >> a lot of if-else-casing which implemented the implicit defaults before= =2E >> I didn't realise changing this to REQUIRED_USE resulted in a conflict = on >> default profiles, because I (obviously) have a package.use entry for t= he >> package. > I don't see Mike saying you got it wrong here. Reading your email, I > think you did the right thing. Yup --=20 Kristian Fiskerstrand OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3 --WuDaA1jvNWkDvI3REN8wlotBa3Mlj616t-- --rfVWW6NjoCMrILj1dK4MLEbHJG8TgGlwe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEtOrRIMf4mkrqRycHJQt6/tY3nYUFAliLOEoACgkQJQt6/tY3 nYVJ/wf/beCdLEGxIqi7uzbrzg3nEUCifySnxuQAzEyVVGJfczhjvLRITkkb2FHp +ocYbahYmsGYXDQ2M2keSGfWHnHcJkUFr6H67g564WTJkjGy5BkZ1uyyq89QhGTQ +Bl7KPglQy0zyMJR3o51qTz4jBkb7p0K6jKHrAn4WuWpeGWYsf1c4PUYE1P3Uono Culdee/mcgUcvUmM7166JAkrFy/fy4JuSowyLH8JUPr+dqVQbR1/k/fJgvMF72rf XDLhIFxWAOVSw6Y3A4fqBxXIz38Mx7RfHCyVZyQr26ATKGx40btGI54nXT7vT/qK +82IYKoMdyQinL6pXDFulTu80G7hgg== =jKq0 -----END PGP SIGNATURE----- --rfVWW6NjoCMrILj1dK4MLEbHJG8TgGlwe--